Received-SPF: pass (google.com: domain of linux-kernel+bounces-97211-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 8 Mar 2024 17:06:00 +0200
From: Louis Peens <louis.peens@corigine.com>
To: Duoming Zhou <duoming@zju.edu.cn>
Cc: linux-kernel@vger.kernel.org, yinjun.zhang@corigine.com,
	netdev@vger.kernel.org, oss-drivers@corigine.com,
	christophe.jaillet@wanadoo.fr, horms@kernel.org, pabeni@redhat.com,
	edumazet@google.com, davem@davemloft.net, kuba@kernel.org,
	arefev@swemel.ru
Subject: Re: [PATCH v2] nfp: flower: handle acti_netdevs allocation failure
Message-ID: <ZespWEukbuJZcdI8@LouisNoVo>
References: <20240308142540.9674-1-duoming@zju.edu.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308142540.9674-1-duoming@zju.edu.cn>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jS7YS1eLRk9dQXN7PqltOucUzlTdJShLQm3Q50j46LrDagomS0VoVSD/B/e0?=
 =?us-ascii?Q?qOxOXUIl1wFLuqrWnvDlvlyANsmrBcc30tj1UFW4UqdAp0zjwD8iZFd7TWIm?=
 =?us-ascii?Q?x/9cIGBuPp7RJ9hbL8No3luc/4m7JZLdksL7Nu1nuNPo/C+d6jcg1wYIfoPG?=
 =?us-ascii?Q?14o/sWOthHc4rEz62v9OCJJB6JoPrqMIWIALcvawLTd3Tz8PsYvF/wmBGItF?=
 =?us-ascii?Q?VkgQDoMp0VHoyuUyRDYmtQ8zHJGIVFMfrdyu9c+aPrs2BPIawasXT0YPBLqf?=
 =?us-ascii?Q?dFi+byLzYsNiyOYew7M6ryWXZgbdIzbEohbesHB+u03VO1/iLD3386ZexqV0?=
 =?us-ascii?Q?5GQ/BOeHYmC0Wl7Tj4oAXMGgDRWePV0hgJ84GH0ttO1LZ6KQf23JTi7SBxrD?=
 =?us-ascii?Q?htIngSnP8VDnDaHdvVKtp/CGOg6S0KXBwM99maBeFf8rFKci4ciDt7uWb+sh?=
 =?us-ascii?Q?pZ5/a3CCeWwbAbZaLi8qz7hWaB0BAYGZojslOQiDPuw6aISGKCe9966Qmwb8?=
 =?us-ascii?Q?B5hS1q6H9ecfNAWSWUllakBbIMG6SPlP8VlZd8D+LvkqNw36o+Z46+p2cKBl?=
 =?us-ascii?Q?jNZ9MqNtX76fkC2uWz0nxeOtdF3DjJFCYM2NpZMjPFlvsQ09nfeIcnircU6O?=
 =?us-ascii?Q?GSqoY9OvefbgjINMHefzTWyRCVDgRsETj5eEaVqBKXj1UV7sXGE/LGH830B5?=
 =?us-ascii?Q?f6Fb0ikmsXUleFKeAAvafYEYsJmUlr93BRO+JbsYi4Pzkv9Cb7mmIEQdXKiN?=
 =?us-ascii?Q?tCm7wpp7cn5oFT2BqeVwMEQST3ICw7WGXTsbb64Et1tDHyi4oVWf9OGZI/f9?=
 =?us-ascii?Q?QT7i/V2TjwEVky7SqzEu+EriioUaTdXPDyD+ZoM8WJoWToJd4SDbFoaMDVNv?=
 =?us-ascii?Q?OwNwMqSYNgB4ke7tUn67vboQHUWZxocHKmUl5PPqthoRXk9Kq90sIN/PitcK?=
 =?us-ascii?Q?UXviEM6QLj5JT600yZ6QtFrds4BsHqIO2sz5mlV6UBmDV3bRmYyLh12Uq8CB?=
 =?us-ascii?Q?6vdeot+Nu+qROE4N2Wi1Y3B+7RQaeTHOROau6Gve2ymu2+IMBuAXePmqQgCT?=
 =?us-ascii?Q?hEHK6vHl1PRkjLHWt9SNTHjUYfP87z6fP0Yobuyq8u0CDfxgyIlx/ceeqHTS?=
 =?us-ascii?Q?UX+0PhJUf8UEsVzUmIqHB0uQt3onOfnlZQtGOkWjK0v4BVvhJuZ8ocQ4cSq2?=
 =?us-ascii?Q?OwTQoFc70V4SxTOPRFQnlu7Mc1/Ufc/VHKPA5XwkSyeXDsuLR63z5X/ofbp4?=
 =?us-ascii?Q?KFHsNcVOOBwxI9zxES4tFI/7ztGRq8CTuq45tiXLK8OM6fBz1XubRmqJLmLY?=
 =?us-ascii?Q?Lscahpg/C3Bh7JqqaFDg0p3OtPckhgAiyVtgPg+VV49FIV24U38Cy5sqlxrh?=
 =?us-ascii?Q?D2wuLVNHXSxm5HL4Sr/uH9Z5j1P7K7qEKI4hhSP0BEwD9Z7oeE0brXnNm9c9?=
 =?us-ascii?Q?RO23zA+47Y09oNPRQLdfnpgi99ckxz/sQgZF9Y6CjhuVr57geB/+/YdfkCkR?=
 =?us-ascii?Q?4Kd5PkkdACv/NSGGSs2uBOTyPw1bLtKbfSq3gddjuSMGtj2jj2WMZMueHx6K?=
 =?us-ascii?Q?D8tiT9z0lyISOM/QtwChvngacX8I2K0dKm3/D4xmuO8wbwhh+aH2Q26cOwUg?=
 =?us-ascii?Q?qQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31653fcd-5dbb-4f50-548c-08dc3f815b47
X-MS-Exchange-CrossTenant-AuthSource: BL0PR13MB4403.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 15:06:39.8387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W7vfzQfoV2N2bSpa18gF1NnulFgHL6mhOd50LAYVbybpYIqxFT+39OeZrcrJ7MNNps0cAoi0aYotwLNSvHCVgVunJ26aXqn590bljljBoMc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR13MB3815

On Fri, Mar 08, 2024 at 10:25:40PM +0800, Duoming Zhou wrote:
> [Some people who received this message don't often get email from duoming@zju.edu.cn. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> The kmalloc_array() in nfp_fl_lag_do_work() will return null, if
> the physical memory has run out. As a result, if we dereference
> the acti_netdevs, the null pointer dereference bugs will happen.
> 
> This patch adds a check to judge whether allocation failure occurs.
> If it happens, the delayed work will be rescheduled and try again.
> 
> Fixes: bb9a8d031140 ("nfp: flower: monitor and offload LAG groups")
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> ---
> Changes in v2:
>   - Remove print warnings on allocation failures.
Thanks Duoming. Just a reminder for next time, it is recommended to add
the tree name to the patch summary ([PATCH net] or [PATCH net-next])
when submitting to netdev. Since this contains a "Fixes" tag it should
probably have been aimed at 'net'.

Reviewed-by: Louis Peens <louis.peens@corigine.com>
> 
>  drivers/net/ethernet/netronome/nfp/flower/lag_conf.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c b/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> index 361d7c495e2..2c7bd6e80d9 100644
> --- a/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> +++ b/drivers/net/ethernet/netronome/nfp/flower/lag_conf.c
> @@ -337,6 +337,11 @@ static void nfp_fl_lag_do_work(struct work_struct *work)
> 
>                 acti_netdevs = kmalloc_array(entry->slave_cnt,
>                                              sizeof(*acti_netdevs), GFP_KERNEL);
> +               if (!acti_netdevs) {
> +                       schedule_delayed_work(&lag->work,
> +                                             NFP_FL_LAG_DELAY);
> +                       continue;
> +               }
> 
>                 /* Include sanity check in the loop. It may be that a bond has
>                  * changed between processing the last notification and the
> --
> 2.17.1
>