Received-SPF: pass (google.com: domain of linux-kernel+bounces-97212-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 8 Mar 2024 15:07:02 +0000
From: Conor Dooley <conor@kernel.org>
To: Julien Massot <julien.massot@collabora.com>
Cc: linux-media@vger.kernel.org, kernel@collabora.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	mchehab@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	sakari.ailus@iki.fi
Subject: Re: [PATCH v4 2/4] dt-bindings: media: add Maxim MAX96714 GMSL2
 Deserializer
Message-ID: <20240308-footnote-landmass-e1efcaf72a6d@spud>
References: <20240305152608.287527-1-julien.massot@collabora.com>
 <20240305152608.287527-3-julien.massot@collabora.com>
 <20240307-retract-aloof-9ff1fde79a82@spud>
 <8f6972a1-e174-4c0e-808e-afece9b529bf@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Twd3rreSHEktHljN"
Content-Disposition: inline
In-Reply-To: <8f6972a1-e174-4c0e-808e-afece9b529bf@collabora.com>


--Twd3rreSHEktHljN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 08, 2024 at 03:08:12PM +0100, Julien Massot wrote:
> On 3/7/24 20:21, Conor Dooley wrote:
> > On Tue, Mar 05, 2024 at 04:26:06PM +0100, Julien Massot wrote:
> > > Add DT bindings for Maxim MAX96714 GMSL2 Deserializer.
> > >=20
> > > Signed-off-by: Julien Massot <julien.massot@collabora.com>
> > > ---
> > > Change since v3:
> > >   - Renamed file to maxim,max96714.yaml dropped the 'f' suffix
> >=20
> > Why? The filename should match the compatible, which /does/ have an f.
> All the work has been done on MAX96714F variant of this Maxim GMSL2
> deserializer.
> The driver and the binding remain suitable for all variants of this chips=
et,
> since they share the same
> register mapping, similar features etc..
>=20
> MAX96714 exists in different variant: MAX96714 / MAX96714F / MAX96714K th=
at
> will be easy
> to add support for this binding and driver later.

Either document the non-f version if it really is that similar, using
all of the same properties, or name the file after the version you've
actually documented. I don't see why this particular case should be
given an exception to how bindings are named.

What is the actual difference between the f and non f versions? Is it
visible to software?

> The MAX96714 name looks the most suitable.
> Please have a look at this discussion on the V3 version
> https://lore.kernel.org/lkml/ZdXYpc2csVnhtZH9@valkosipuli.retiisi.eu


--Twd3rreSHEktHljN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZespkwAKCRB4tDGHoIJi
0qDHAQCSxd1xjjCo/nZv8eEWqflQQ8O36V8Sw0ttdF9jgDLs2wEA30sl7I0RGbXs
U1XvYdo1uUEMwWHYkc+terFhxnOUug4=
=desQ
-----END PGP SIGNATURE-----

--Twd3rreSHEktHljN--