Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp627397lqc; Fri, 8 Mar 2024 07:24:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWAlGUch/vCdOsPIbkURabmdXRcMDHVrTx8J2ts8y3Di1DzxGQIzfR4KDu93b7pMvXkm7pBxXTO1rQFOF089HIkcozSjxFhht0mU2jx8A== X-Google-Smtp-Source: AGHT+IH8k7OrbuzWgguiokfAvvPYscgXibVTmFmOpYp0Qn+m568g+p1lp/noNPnXHAuCCwPaGNZc X-Received: by 2002:a50:8e5a:0:b0:567:1263:e31f with SMTP id 26-20020a508e5a000000b005671263e31fmr520486edx.10.1709911455637; Fri, 08 Mar 2024 07:24:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709911455; cv=pass; d=google.com; s=arc-20160816; b=qBMHFUM4zy38A7oEnkPlSexriPHg2saESPYXfCJ19Jorjg4K9LwGSXlluEPCQO3Psv wp0RpDGBiWmrL8W6i2XZfaUlf2WQKXYbDfZOI4r6aSgEXSGECQ1UfAxCdxbop6pNRrFR jqPqPPJrMlz2nDK0beSel1E1p1z+yKI/stRJTQpIFKcbEDJwluOWT7ISzn9mW5u0t6pf 1UOZug8nY4/Ef7lJ4/GD74qQKienZWHBI0cAyoK6pd1PBvb5TsreLi/otkqOiz82S+Ry 2mpeI3PCv6SuuWJE1IWjkNHG50Kmx0IsN0km8g1h5JTT0Vjwz/nZcNGwoPxR9suqaDJn kRdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=u8T17NYzEuAkboRvcuTr0+eQzl1hJHiDAxPi1WwB8vQ=; fh=ks6kOT06+Iw3Aad9Fc7BAqmA5m2h5+B+V/iIH/8sWfw=; b=gjm6Z04PAJCnhPANO9pejog9ZFyoEo70/RAY48/d4f/RproQw/YHYx8Wp5B+sG0SSc UO2DuHU2jyUufHbX29+xh5f73uqm+JpcJBEV/zT9wUM9UfwnGZPEWx31ehk8ov/1Vnx7 tUZU9L3QW6NUUeGTDMrSoMq8ED49NXz3oTkfyWOEU03yzP76wEI+qAemNrpoEPJld9ys OU5UjVSHswIke+HphmspTEnR+E+azbIHGUI/aG2RHRTN+fypL7epdJ6Xa2tVXc6cPhje CnS7755UoLRcyeMsKWEpqxVdwLDwpbqKPhjIk10pqk5Sj3WTCf3GJYm86goxw1mGRo49 1kIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hdCY2uow; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-97225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id h15-20020a05640250cf00b00566dc670917si6916319edb.487.2024.03.08.07.24.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 07:24:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hdCY2uow; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-97225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 34E381F24254 for ; Fri, 8 Mar 2024 15:24:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B044A1DFE8; Fri, 8 Mar 2024 15:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hdCY2uow" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656781DDF1 for ; Fri, 8 Mar 2024 15:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709911441; cv=none; b=W41jW5wqS2tkS0hPjbROQR2EZ8MwycKwQ/4Mc4gSGuF3YaN3BUqH+E1isrK3LSKjiB+fJTXpMjgZ21OHDLv1VQULsNXu5qBXSdXBfFmqMbz2BsOkFOm+/b5j/HI90M2Ec2g1s2P084HAvvpTAOV8mgLX/PpIstr2L4YJ3S+pe34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709911441; c=relaxed/simple; bh=D7fa23jwhdR/0Ruut/uLrO8UufA0ppltESXABl7U58o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yk9MJa8eJdSMh/NPdPONjzb2NM7UIjcYREOPBArbkDhsZWdqBnssFIcSFk8yIYSs2olB/CMmAvdnE+LnYBopE+hDg2i/olZVd4toTxrJ+1FF3XS6Iw7Tpen/r5R7Gr23gX9l0F7j9qaEpCIzo1M9txqjyYkMi1p1hRtH7garxG8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hdCY2uow; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709911440; x=1741447440; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=D7fa23jwhdR/0Ruut/uLrO8UufA0ppltESXABl7U58o=; b=hdCY2uownEkkReeLz/26nzJOSzX/HIH8iFg8dPBf/pI5Nk101bLsxGxX 3jsYfGAdgl+ZY2IAalyDLGh0mMK2hC6MIdehPblKMo8uSaG4+G8vdPJsl zFrzrguqoZ8bqkmPkWagjZNrwvpmwGs8G/TCIfPdbTC38fv4v2XOc/qy0 jpru7fNNroVh6JAkmo4sZF9NtnrUGG6pwxhLz05ycIS5IK5ABeciqdgs8 vvleE57dgiT46S/jzUgKOhwaumTU8jw5BiVhHuREHMBpdLg0I5LV/3IUe wUiGit9m/bgpBq+kMY/TOcL9cktMJ3d2Rre3+Xa1LLzl2vi7Ooi3k9Xt7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,11006"; a="5234621" X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="5234621" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:23:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,109,1708416000"; d="scan'208";a="47949762" Received: from mananmeh-mobl.amr.corp.intel.com (HELO [10.212.139.209]) ([10.212.139.209]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2024 07:23:59 -0800 Message-ID: <35b670e2-9ef5-4d3a-b6ea-f8016dfa088d@intel.com> Date: Fri, 8 Mar 2024 07:23:58 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] x86/mm: make sure LAM is up-to-date during context switching Content-Language: en-US To: Andy Lutomirski , Yosry Ahmed , Andrew Morton Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Peter Zijlstra (Intel)" , "Kirill A. Shutemov" , the arch/x86 maintainers , linux-mm@kvack.org, Linux Kernel Mailing List References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-3-yosryahmed@google.com> <420fcb06-c3c3-4e8f-a82d-be2fb2ef444d@app.fastmail.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <420fcb06-c3c3-4e8f-a82d-be2fb2ef444d@app.fastmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/7/24 17:34, Andy Lutomirski wrote: >> Fix this by making sure we write a new CR3 if LAM is not >> up-to-date. No problems were observed in practice, this was found >> by code inspection. > I think it should be fixed with a much bigger hammer: explicit IPIs. > Just don't ever let it get out of date, like install_ldt(). I guess it matters whether the thing that matters is having a persistent inconsistency or a temporary one. IPIs will definitely turn a permanent one into a temporary one. But this is all easier to reason about if we can get rid of even the temporary inconsistency. Wouldn't this be even simpler than IPIs? static inline unsigned long set_tlbstate_lam_mode(struct mm_struct *mm) { unsigned long lam = READ_ONCE(mm->context.lam_cr3_mask); + /* LAM is for userspace only. Ignore it for kernel threads: */ + if (tsk->flags & PF_KTHREAD) + return 0; this_cpu_write(cpu_tlbstate.lam, lam >> X86_CR3_LAM_U57_BIT); this_cpu_write(tlbstate_untag_mask, mm->context.untag_mask); return lam; }