Received-SPF: pass (google.com: domain of linux-kernel+bounces-97246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 8 Mar 2024 10:42:29 -0500
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Gang Li <gang.li@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Muchun Song <muchun.song@linux.dev>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Jane Chu <jane.chu@oracle.com>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com
Subject: Re: [PATCH v6 4/8] padata: dispatch works on different nodes
Message-ID: <yi422qqkfhf23x4wekpycxmsjodbwcw7aw2avjfh37dkapocg7@f7nn3mtdldbq>
References: <20240222140422.393911-1-gang.li@linux.dev>
 <20240222140422.393911-5-gang.li@linux.dev>
 <7g53p42favkoibzg4w3ly3ypdjdy6oymhj74ekwk62bwx4rlaj@seoavjygfadq>
 <9b044d9b-d3b1-4fb3-8b05-2a54c2b45716@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9b044d9b-d3b1-4fb3-8b05-2a54c2b45716@linux.dev>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?qegA+UsutnxYXMmkmlp1PXJ+VQxteDLy7rjdX/69wPfsEajTI7Xz2u0Cn+BD?=
 =?us-ascii?Q?5582pl1VUciwz66bTV9WFtZH3nSk85pqxdQ++QvPPuas8x782P+a+APJTJlf?=
 =?us-ascii?Q?vfxzdBWPYU411X3rZssEwkHagmS64giv0NBokRTQJLr9lnGCXw0d6SIGgO6R?=
 =?us-ascii?Q?pSM4DjgNZfkfaSqVIyga9AaDivbRbaOBViC+sPp8psfbt6NQAQycD6N68Ge2?=
 =?us-ascii?Q?mN/jWueTn9NRx7zTS7bgwhFTpQFzJMf8JwSMgiV5EnlbU2wX8clTsOUVrgzP?=
 =?us-ascii?Q?2iBYkMLqe+5tA6AUm+SuLhKA8mieR7m5a8pqsq2PlilkCsdCRFS5fGw3cF2x?=
 =?us-ascii?Q?j5VmkSOXnLLAwKzp3QGTpKYbjKqi3kjQM4/qFni1Pq8qPjUz0ymjwOwK47hO?=
 =?us-ascii?Q?X1HX6/F9iyIBEWHDRlLTeh0sP0PjsSLVHKClm4/YgXY/a6Dj4GUl6i2sUoQR?=
 =?us-ascii?Q?fKR0bQktsLkfVYSaqjmZHNfx8B479SkYdZ7DZBJJnu25Ensqe9pERV4a0+eC?=
 =?us-ascii?Q?jgVGGX5Ak3hdV3PrUUVVH8tIoolZqai14V6/zKx5Ad+E9QZEOdhhJFTOzDh+?=
 =?us-ascii?Q?o/0oDtyujthy4ryIDJEmjQdjqTDKiOWks/jBLE9XXdA3NMA7V5HnUWb5Eemv?=
 =?us-ascii?Q?a0cTIzxVHIzunNqkRfA3hUbRGFzMsqA3C5y4WN7FQyswJLhERV3CSFqEI1xJ?=
 =?us-ascii?Q?D9JSJCnBxZ5eNVsutPnV1V6aN/Jry3tMoJXRYluV9AyW1+0rj0y9NcM1Jh4D?=
 =?us-ascii?Q?IecxBUJ6p9W2gu3iAMMIDkCLCFhEeBOoBst6adLVT/8X5zyNITIzRJl1mjz8?=
 =?us-ascii?Q?NjbN6EAsdUNQTUpgaZTv2YB8Sv92ZvH9tUdc82nOshUEyg97lv9V61+JN7yg?=
 =?us-ascii?Q?WYcckhvV6tsi2tUSo/8i2dt/dsqwGDt66+AXXotXIPX0WeAKctO3zLWm/YXc?=
 =?us-ascii?Q?MKJj4WoYjyAgv9YLFRJrG/GRmO0h0fMcJah4MOCBIIHuYFHJkg4Jz6akG3lr?=
 =?us-ascii?Q?HeEX5DC8OT+/RD7yUFXBbOqONBFyQq9vT8ZgSoFU1ZgiWSGWH6qpA5DoZXMm?=
 =?us-ascii?Q?9Zz12WEJngfShlz87gE7NHYaltiK7NdhwOMjImCHa2DH+9hIyAbWMCT29sW9?=
 =?us-ascii?Q?5TF+C0w9f5sqpSF2dtsoWU1BH9OelqPMtCdEzxReSrwAiDJCkRfi9mymkZRu?=
 =?us-ascii?Q?aOHw4oGc4VmT4vGR+I94Z1ZfsQ8co1HEqE6yhHPLsRPnIPX6jyndmC1wn7OE?=
 =?us-ascii?Q?BA01YN+jp+YI19JbOSYUvcTsSJS42c5q/53CrEyRyzxZI3Yb90TxxMSyyUHV?=
 =?us-ascii?Q?Uv2ssE3c6LoRL8Bk36hZwByBJ/RnAMlbF0GP2WXaQwj80n3JYolALVwZR0NJ?=
 =?us-ascii?Q?ZMODxdwQ280Q3pAxjIEWybzAeIxWxLAeAcw1Z8nt1RXWzbtVr4k3Hg8wVYPc?=
 =?us-ascii?Q?sFwjnYauchra71yEiDS71OCqhnzjKd7mQb5lHdkfgsXUwShr35jn5TL+w612?=
 =?us-ascii?Q?wGkac3ZFWs1FObDQMe9JRiS6MXtpAWKevNNrGfwBiA9+5QuA1Bq2RMH7iKqC?=
 =?us-ascii?Q?E2mBYIINSRkMNinUvgTXoNBNZ3ZLFoHeUObaVp9DyI64mnVBio7WUjpjkvvT?=
 =?us-ascii?Q?BA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZGYHrpYyTzxWf7q6l1VnTlmSLnJuPDNZDmfTqEPhTgSp/E1e+RqxQg2eLdTslYoCo1jb5uWqH1YRfEa5CrFubdrJ2kWtGXKGZi3lm4vRsOvN/eBmONnUwdLUrqsg+Q9SbdNbDiSJ89+SLc2X/VDZcVqWXeg6ydjicLyv8mZppPHLu1ub8e0mPtMystH/iOqmNhwdt4DM90V69KQo95/d+ZQgixLqU6lkdCU0v2S2Oq7kXWlyNveKLcjdrqXRdMA6XaJCqq206eWWXN2kVajIeJ3NQKdjOn6cPciOmkvRSBRgIqGWTB5MvIFEBu5lMIkW71eBAxftYXggDwkN0l8PMHbZ9NEMmi/Zvaa6lQ6GbZVRxm+31F4LvCO4JKXecXd2/0bCOr4whvWJWwpxrYNnEZZRkSDrY1g8KLoA7y905B7qkJe8thd3iHzqDufyMhalT0m4I1RKnCOUGtpwUnSfVsiuzWjQkWFka4FtlOqvGPnZp1lhrnDvml4ydTHl0pZfn8/aFMFMb1PJ1E/OsZ4MB4ykM0HFoXdiQTAFKPhmeI/WG4oUl6ZrO9tHWz4zAyMWo73dZBMe0X+u/FD2ljdZ4CWe5kX6dyHigf0g06Rts6U=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73447de9-12f7-44a7-53b8-08dc3f865e85
X-MS-Exchange-CrossTenant-AuthSource: SA1PR10MB5711.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 15:42:32.6166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UKYCjUCivldJ+6x5fplupNMgnAiOuVl3GN8nJqRz9FgjC5LNi1GywIUBEhDhYs7h7h1WMQhFVw3XvmNeesqwL1cS1puviNFOhlHhoONaPSA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5760
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403080125
X-Proofpoint-ORIG-GUID: H2nPdYsK4qIaXCLZZAf47UehX2-WQeXN
X-Proofpoint-GUID: H2nPdYsK4qIaXCLZZAf47UehX2-WQeXN

Hello Gang,

On Tue, Mar 05, 2024 at 10:49:47AM +0800, Gang Li wrote:
> On 2024/2/28 05:24, Daniel Jordan wrote:
> > On Thu, Feb 22, 2024 at 10:04:17PM +0800, Gang Li wrote:
> > > @@ -517,7 +518,16 @@ void __init padata_do_multithreaded(struct padata_mt_job *job)
> > >   	ps.chunk_size = roundup(ps.chunk_size, job->align);
> > >   	list_for_each_entry(pw, &works, pw_list)
> > > -		queue_work(system_unbound_wq, &pw->pw_work);
> > > +		if (job->numa_aware) {
> > > +			int old_node = atomic_read(&last_used_nid);
> > > +
> > > +			do {
> > > +				nid = next_node_in(old_node, node_states[N_CPU]);
> > > +			} while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid));
> > 
> > There aren't concurrent NUMA-aware _do_multithreaded calls now, so an
> > atomic per work seems like an unnecessary expense for guarding against
> 
> Hi Daniel,
> 
> Yes, this is not necessary. But I think this operation is infrequent, so
> the burden shouldn't be too great?

I can only guess, but I bet you're right.  It's also that people might
wonder what the atomic guards against, so non-atomic would make the code
a bit easier to understand.  Either way, looks fine.

Acked-by: Daniel Jordan <daniel.m.jordan@oracle.com>