Received-SPF: pass (google.com: domain of linux-kernel+bounces-97247-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 8 Mar 2024 16:44:29 +0100
From: Michael =?UTF-8?B?QsO8c2No?= <m@bues.ch>
To: Rand Deeb <rand.sec96@gmail.com>
Cc: deeb.rand@confident.ru, jonas.gorski@gmail.com, khoroshilov@ispras.ru,
 kvalo@kernel.org, linux-kernel@vger.kernel.org,
 linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
 voskresenski.stanislav@confident.ru, james.dutton@gmail.com
Subject: Re: [PATCH v3] ssb: Fix potential NULL pointer dereference in
 ssb_device_uevent
Message-ID: <20240308164429.0a01fc41@barney>
In-Reply-To: <CAN8dotkp7tQ6znKM5=1iM08hLvjLK-VbQm9LuqcGBf0e3ok=kg@mail.gmail.com>
References: <20240307223849.13d5b58b@barney>
 <20240307232927.171197-1-rand.sec96@gmail.com>
 <20240308060943.2410ef2e@barney>
 <CAN8dotkp7tQ6znKM5=1iM08hLvjLK-VbQm9LuqcGBf0e3ok=kg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/UBAVpEGvFW.8SZN79fr457G";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/UBAVpEGvFW.8SZN79fr457G
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 8 Mar 2024 14:36:56 +0300
Rand Deeb <rand.sec96@gmail.com> wrote:
> Adding a redundant null
> check goes against code clarity instead of enhancing it.

You keep on moving goal posts.
The check is already there. Therefore, this is about removal of this NULL c=
heck.
Which is not acceptable.

> I respect your opinion, but it seems we are stuck in a while(1) loop
> without a break.

Don't worry. I'll ignore this thread from now on.

--=20
Michael B=C3=BCsch
https://bues.ch/

--Sig_/UBAVpEGvFW.8SZN79fr457G
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAmXrMl0ACgkQ9TK+HZCN
iw6djg//cErRxyXC6LYNIJ79g3Zqn0XiRGBUoxnpKZvv+kUJ+2qe14ne/H9CIEqT
m+KyOI++0XWwWkrMEPvO01psTr3ra6WHeGFwYmVngj+hSmJ3mODWl+w+WCLeL6hU
hhXabKrwaXs+2ZGAYDA8dyE6ihMSLsPpNElsUY1x6Y1id9NkkrSMkPXh/jCpa4lO
Vzy5qXISAyQ4NIZajqH6e4oUjwuixr9oghFOkSe/FW7UI8aZ+Cci9F/YI2sJL9SD
ThWiVfhEK9iiUtGulfW7gsknP0uEO9bj9oZj5KSd5Wvg4zhep59es/TzBJCYFLyF
QShqke8zkRpRX1FaZLqhrSj2m9bnTSi5OmuwENBsuOELjDwbIPOx8+DHU4q6VMgq
F+FZkHdzCNiAWHwWfc9Fi8brFdguVFN84FrvRaHkze76y0zh10uBDAHVeeY5ADDB
rp/Kr0fPQxq/YoWqbbqZggE6CdoxrWQG6JypC+OwFeEGkLL5rFAnMwmC4nAbJAov
+UE1Qd5OcgGsH7p/7BbVDlf6IWBYhqxBsFAMKzjPF/MeqBzhYYi8rwVxP4VOpgjL
kJmgb5n+MtuLD5lCvdY+P+Rbn7M2JeAIaoDnA/QdgGB6Fs52+4SeHuPIDf9WXFDW
q3kjTBJNfmDk7SykJn9jAt6Tv8Bl+IuTIB2XigrFy4PETaX2CNE=
=6clV
-----END PGP SIGNATURE-----

--Sig_/UBAVpEGvFW.8SZN79fr457G--