Received-SPF: pass (google.com: domain of linux-kernel+bounces-97256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 08 Mar 2024 16:49:29 +0100
From: michael <michael@5challer.de>
To: "Kai-Heng Feng" <kai.heng.feng@canonical.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>, "bhelgaas" <bhelgaas@google.com>,
	"linux-pci" <linux-pci@vger.kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"regressions" <regressions@lists.linux.dev>,
	"macro" <macro@orcam.me.uk>, "ajayagarwal" <ajayagarwal@google.com>,
	"sathyanarayanan.kuppuswamy" <sathyanarayanan.kuppuswamy@linux.intel.com>,
	"gregkh" <gregkh@linuxfoundation.org>,
	"hkallweit1" <hkallweit1@gmail.com>,
	"michael.a.bottini" <michael.a.bottini@linux.intel.com>,
	"johan+linaro" <johan+linaro@kernel.org>
Message-ID: <18e1ebf2b92.bedd9a071161871.3718292789549008231@5challer.de>
In-Reply-To: <CAAd53p6GEPJe3rNNrUAah5PdLXspKh5Gz9tFstR6SFCREs+9=Q@mail.gmail.com>
References: <954f0b86-dd9e-4d84-8d67-fba7e80bc94e@5challer.de>
 <20240105155100.GA1861423@bhelgaas> <CAAd53p5Eg4J9bRtAHY+JZ11cy1D0TnKmAaLfzcRJzw15VRBxXw@mail.gmail.com>
 <9f0f9de4-2d34-4ff3-a901-c3e4b48e4ab0@5challer.de> <CAAd53p6GEPJe3rNNrUAah5PdLXspKh5Gz9tFstR6SFCREs+9=Q@mail.gmail.com>
Subject: Re: [Regression] [PCI/ASPM] [ASUS PN51] Reboot on resume attempt
 (bisect done; commit found)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Importance: Medium
User-Agent: Zoho Mail

Hi Kai-Heng,

 ---- On Thu, 07 Mar 2024 07:51:05 +0100  Kai-Heng Feng  wrote ---=20
 > Hi Michael,
 >=20
 > Sorry for the belated response.
 >=20
No worries.

 > On Wed, Jan 10, 2024 at 8:40=E2=80=AFPM Michael Schaller michael@5challe=
r.de> wrote:
 > >
 > >
 > > On 10.01.24 04:43, Kai-Heng Feng wrote:
 > > > On Fri, Jan 5, 2024 at 11:51=E2=80=AFPM Bjorn Helgaas helgaas@kernel=
org> wrote:
 > > >>
 > > >> On Fri, Jan 05, 2024 at 12:18:32PM +0100, Michael Schaller wrote:
 > > >>> On 05.01.24 04:25, Kai-Heng Feng wrote:
 > > >>>> Just wondering, does `echo 0 > /sys/power/pm_asysnc` help?
 > > >>>
 > > >>> Yes, `echo 0 | sudo tee /sys/power/pm_async` does indeed also resu=
lt in a
 > > >>> working resume. I've tested this on kernel 6.6.9 (which still has =
commit
 > > >>> 08d0cc5f3426). I've also attached the relevant dmesg output of the
 > > >>> suspend/resume cycle in case this helps.
 > > >>
 > > >> Thanks for testing that!
 > > >>
 > > >>> Furthermore does this mean that commit 08d0cc5f3426 isn't at fault=
 but
 > > >>> rather that we are dealing with a timing issue?
 > > >>
 > > >> PCI does have a few software timing requirements, mostly related to
 > > >> reset and power state (D0/D3cold).  ASPM has some timing parameters=
,
 > > >> too, but I think they're all requirements on the hardware, not on
 > > >> software.
 > > >>
 > > >> Adding an arbitrary delay anywhere shouldn't break anything, and ot=
her
 > > >> than those few required situations, it shouldn't fix anything eithe=
r.
 > > >
 > > > At least it means 8d0cc5f3426 isn't the culprit?
 > > >
 > > > Michael, does the issue happen when iwlwifi module is not loaded? It
 > > > can be related to iwlwifi firmware.
 > > >
 > > > Kai-Heng
 > > >
 > > The issue still happens if the iwlwifi module has been blacklisted and
 > > after a reboot. This was again with vanilla kernel 6.6.9 and I've
 > > confirmed via dmesg that iwlwifi wasn't loaded.
 >=20
 > Can you please give latest mainline kernel a try? With commit
 > f93e71aea6c60ebff8adbd8941e678302d377869 (Revert "PCI/ASPM: Remove
 > pcie_aspm_pm_state_change()") reverted.
 >=20
 > Also do you have efi-pstore enabled? Is there anything logged in
 > /var/lib/systemd/pstore (assuming systemd is used)?
 >=20
I'm happy to test once I'm out of the hospital (long COVID). I should be ba=
ck home in 5 weeks.

Michael

 > Kai-Heng
 >=20
 > >
 > > I've also checked if there is a newer firmware but Ubuntu 23.10 is
 > > already using the newest firmware available from
 > > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmwar=
e.git/log/iwlwifi-8265-36.ucode
 > > (version 36.ca7b901d.0 according to dmesg).
 > >
 > > Michael
 > >
 > > >>
 > > >> Bjorn
 >=20