Received-SPF: pass (google.com: domain of linux-kernel+bounces-97267-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <0efda75a-dde6-42e0-86dc-993f0d1c4730@infradead.org>
Date: Fri, 8 Mar 2024 08:02:27 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next] ACPI: Add kernel-doc comments to
 handle_eject_request function
Content-Language: en-US
To: Yang Li <yang.lee@linux.alibaba.com>, rafael@kernel.org, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240308073214.11262-1-yang.lee@linux.alibaba.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240308073214.11262-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/7/24 23:32, Yang Li wrote:
> This patch adds proper kernel-doc comments to the
> handle_eject_request function in the ACPI dock subsystem.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

LGTM. Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/acpi/dock.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index a89bdbe00184..a7c00ef78086 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -380,6 +380,8 @@ static int dock_in_progress(struct dock_station *ds)
>  
>  /**
>   * handle_eject_request - handle an undock request checking for error conditions
> + * @ds: The dock station to undock.
> + * @event: The ACPI event number associated with the undock request.
>   *
>   * Check to make sure the dock device is still present, then undock and
>   * hotremove all the devices that may need removing.

-- 
#Randy