Received-SPF: pass (google.com: domain of linux-kernel+bounces-97269-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ec91a9ff-7c64-4428-b32d-c65d7a5a1ed3@gmx.de>
Date: Fri, 8 Mar 2024 17:04:49 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] platform/x86: wmi: Support reading/writing 16 bit
 EC values
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, "Rafael J. Wysocki"
 <rafael@kernel.org>, lenb@kernel.org, linux-acpi@vger.kernel.org,
 platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <20240307195753.2961-1-W_Armin@gmx.de>
 <21fd57a2-d8c3-779c-7090-b7cdfc8198be@linux.intel.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <21fd57a2-d8c3-779c-7090-b7cdfc8198be@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:/twEZbo7cPw=;zH/K0U78ml8Acbw9oc6kY6gf+mD
 ZGC0SLF+n2cNgzsHXXvRhSNqdLD7XzgfEqhR9VOwexp02rWCeGFhQfbIAYcC6IW26nBhHTcC6
 AND1zXD+8gCl7ocJARDrwljV3ojCC1nAa5tQCj1lYj7OGLN+ABk2soFiRSkP6dn3URVufpE7k
 fBf8zYz5BUMQ9+Yy1v3YH3AdBBDvj4JhFIE0T/u5gPuUck2oOGFC3o8jo89+b8IqXpkuRX8uK
 D0x/7Y65I1kCBqzOIDDWBqoI/au1BlZDqhcLBpU+cwJ6wD7h0/woKbBlG1HTMpiO7O1c+wYEr
 Qug8e4jdzQLY2Ttig9QAPTnuPWblNcwlpi8ZwcmUQGOZREzNHe3W8hu6XuqqnGy+juSo5WLo2
 e+RnN9b4lv3TZc+GLFYCc5j7ndC4eZCrvHNqbW+pCuFK8urcwRUXSsfqb+2wxy+HSPy30j2JQ
 ptfaErPcSpmGggeSvFGwgCxviwQS13JSRmg2idrR7u/BnFwBS9+n4hdPVmoFsNy5tkp1vOSTR
 P3jsP+oJqgCUkAXPx+7GCcH7bKAyhkAgdBW+DGls0t53f9F7Qv5fMWigDa9PO1eZ2Y5sAG0TC
 4Y2l9RW3Sjee1fl7VlHpQ6eKf7jWolB8Co2HQIqMMPaHUUzpxb5fUS3yFY6zQm8gCLUvRoVr0
 5VLOz5soEI6FOC4TV5m5MahYDE5SiRjwhIQ4uIj+WO4FeIhSpvOMY7DNfKvHHoSWPFKxHsXw+
 eN68aqLGJ6JBAgbDQ3w3S61BK39LGUMTf1dd4DFq8rLIaHWKOjGfQSiR8Vri1V4gyuEN63oeH
 Qy1pnUEUJ1fFR1WfhxVcikzAwPpcvza8b5HqH0AUVOZzs=

Am 08.03.24 um 09:01 schrieb Ilpo J=C3=A4rvinen:

> On Thu, 7 Mar 2024, Armin Wolf wrote:
>
>> The ACPI EC address space handler currently only supports
>> reading/writing 8 bit values. Some firmware implementations however
>> want to access for example 16 bit values, which is prefectly legal
>> according to the ACPI spec.
>>
>> Add support for reading/writing such values.
>>
>> Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus.
>>
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>> @@ -1162,27 +1188,28 @@ acpi_wmi_ec_space_handler(u32 function, acpi_ph=
ysical_address address,
>>   			  u32 bits, u64 *value,
>>   			  void *handler_context, void *region_context)
>>   {
>> -	int result =3D 0;
>> -	u8 temp =3D 0;
>> +	int bytes =3D bits / BITS_PER_BYTE;
>> +	int ret;
>> +
>> +	if (!value)
>> +		return AE_NULL_ENTRY;
>>
>> -	if ((address > 0xFF) || !value)
>> +	if (bytes > sizeof(*value))
>>   		return AE_BAD_PARAMETER;
>>
>> -	if (function !=3D ACPI_READ && function !=3D ACPI_WRITE)
>> +	if (address > U8_MAX || address + bytes > U8_MAX)
> This doesn't look correct. With address =3D 0xff and bits =3D 8 this wil=
l
> return AE_BAD_PARAMETER, is that intensional?
>
You are absolutely correct, i will send an updated series soon.

Thanks,
Armin Wolf