Received-SPF: pass (google.com: domain of linux-kernel+bounces-97270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <44f53dce-1299-4fb0-9c4e-dbf0f5b3a351@oracle.com>
Date: Fri, 8 Mar 2024 11:06:58 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] KVM: x86: Print names of apicv inhibit reasons in
 traces
Content-Language: en-US
To: kvm@vger.kernel.org
Cc: seanjc@google.com, pbonzini@redhat.com, linux-kernel@vger.kernel.org,
        joao.m.martins@oracle.com, boris.ostrovsky@oracle.com,
        suravee.suthikulpanit@amd.com, mlevitsk@redhat.com
References: <20240214223554.1033154-1-alejandro.j.jimenez@oracle.com>
From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
In-Reply-To: <20240214223554.1033154-1-alejandro.j.jimenez@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eXFDaDAyM0dBY2hYTXhDbGpoSnRmcXk3aGdmZ1lodVV2eEZDZEllOFZFenpo?=
 =?utf-8?B?eEpJbVdUSXArM0dEcnk5QTRFcUNzVVF6NG5ucUd1Yzk4WUFOYlJENFUzUi9U?=
 =?utf-8?B?WDd6VG1VcnQ1QXBINkhqS0w5RG10d0IrN1plMTc3L05WZHdva0E0Wnc5cHo1?=
 =?utf-8?B?ZnF5R2g1U2gwOGVlQnBXUjdDSksxQVFvd3E4VEI5YVJTQnVNdTFKRCtQV3FF?=
 =?utf-8?B?MXJKZTliRkdSRjIwMWdZZWdoUCtlaWVISUtLTVJhemhwSVhobkQvY3lwZmU3?=
 =?utf-8?B?V1AxNm1RT0FiRjhEdG1IblhkL3dmQ2MxK1g2K2prSDljWmhHYnNQQnRwRmMz?=
 =?utf-8?B?QjcwTFdNeGdyY2grV3JaazVob2lzV254UGtUNnBudS85aXFTQTJCa2lXWXZp?=
 =?utf-8?B?azRhK0dtR01TalRYSWlqZ1RhK1RzT2hJMTNNdWt0K2RQanB6NTlCaUFHYkVQ?=
 =?utf-8?B?cVZpZmxGbmN4WVFnaFptV0VzK3EySTJ6ak8yeVJ5dnk2YUhIUzJUWkRsaUt5?=
 =?utf-8?B?T1VNYXJuL2s1TVBOakl6MjZxd2htajV4aDY1SGNGKzErZ2VOUEtBNXR5eHk2?=
 =?utf-8?B?d0w5ckcvQWYxa3paSzFiMU9CdlZTa0k2ZGFYYTFYRzkzcWJrSVQzdUV1TEdG?=
 =?utf-8?B?WjhYYmVKeXppOXNkSThDNkk4N3hFK1FsMVdxVWlHc0tQRnFBdFhJRWhYOXlC?=
 =?utf-8?B?bFJnclhObXNHRmVqd0FsV2pDOFBWaFBTZmUwdGRzOFFRaHFhSEZNZUZpVmZo?=
 =?utf-8?B?Q0grREUyaUJSdElIQWdUVzUvR3NFcEkzamdGbW1sd2pwbmd4ZlJFUnlrby9U?=
 =?utf-8?B?ZUZOUXp2NE5DZXp6VDlDbCtlcGd3VkhZcjZ3OERlanlJMENGWGNCK0R6WDVz?=
 =?utf-8?B?UnlaOEZMeWpIMmVqbUdkZFVrZnRnVG9JaElNOEx3QTJ2S2NjOFllOUJmdnA3?=
 =?utf-8?B?RGtzd3RGMWpUZDdPUzBkNVdIV1J6UHg3MDZ4ZHpCV0hwTmRwTVZlSDBTamdy?=
 =?utf-8?B?UmcxSmlrVTQ4ZmdRV1RLZGNKNlVIR08xNUFaWnBqMUltTG1id3JzRmtRQTg1?=
 =?utf-8?B?RVVJVUlsenNtSGlRbEpwSzBhcWdUWDRQalJ1MzQ2L1lKWklydXNhTTdPekF4?=
 =?utf-8?B?aDExRkx5V1pXVlgxbFd6RXpTL2kvbitUZElRWWlaaXc1MHM1RnNIS2svSGYz?=
 =?utf-8?B?Y0tIV3djY3RxSFB0ZmxIT0ZGLzVqTTRvNHc4RDdqZFFlQjJlTDBRRTUzWjNC?=
 =?utf-8?B?Y2xnOHZaRFg0bjNJODF0cnphY3kxdXlYcm5CQmM3SjZMa25UZGc5SWcvTTFT?=
 =?utf-8?B?dVZvWG45Q25OdVlYVkZuei9nQ1doSW93TFdOUHhWWnJlejVQYTFaeFRoa3FF?=
 =?utf-8?B?WW9vcEc1d3VRSDRudVo0c0dGa29XY1F5dk9UbFF0YmNiTVFWOGJBczFYQ2w3?=
 =?utf-8?B?eE1TdjBjTTg4WmxFTklhOGF0MlJwM1JNLzhyRFp4TFl5U0huUUh0SXdBQzZw?=
 =?utf-8?B?dEc3QUJVYUJVb291TTNETncyREV0ei94YytkOVpvekdKa0FzVzY2Yk56SXRC?=
 =?utf-8?B?ZGJqQVBhalNCTVBKOW1qaWFxS2JxNEVweFVFUGo2UThGMUJrSFNzT3paanRP?=
 =?utf-8?B?NWpVNG8vS2NEOFdzSSt1TWxSWDZRSUJCdWh6VTU0engvd0NuT0NIZFVYdHQ5?=
 =?utf-8?B?dUc1NExBdE5XUkhXVzRxSEdrcS8zNVNwSHpmcWsrRVo1MXNQWGRoZ1NWeERO?=
 =?utf-8?B?V0RVMTdlUkNqR0wvdlhRdUtDNlZ4ZzByRmdkWlZvN3JYTWp5MWh3N3RmdTlv?=
 =?utf-8?B?cFZVQTVIYkVYSllKR0J4SkdDS1o3Y2lJd0hKUGRuZENJU055eHdrVWxOeDV2?=
 =?utf-8?B?V3YwcUZZaTdyb1JHV1F3YU84Y25ZUmJyMDFwUkVqelJ3K0srdHNNZ1Fha3d1?=
 =?utf-8?B?eitzMytFcWJMV01GbTZyZmVEcFRZV093YWQ4RU9obzN3ZzhJRzMvVThOVVlE?=
 =?utf-8?B?YW1ROElkK2ZQWXBwYUpHVXF1WFF5cW9IK2Jua3o0T2pzcDVqKzNGbkVGMEZT?=
 =?utf-8?B?ZlB2blE0OHNTSHYzTXBlbGoxRTN1ZE5wNkJraisvQVdYYTVrbmZKcENnczBa?=
 =?utf-8?B?U1g3dmw3UVdWM1JQWm1sQm9RakwwZVRpNlkvOE1NWVVEelFXbS8yVENGTTlY?=
 =?utf-8?B?ZVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	o4YkBHHlXj0D4EOZ4OVsQ7g+rro4Pye1kCV+10JCIGyoh56zbthhA5CjaB8YF4/TYj+J5zwrkibcWNOyRJdVBxeFLOSFnm0uc5hI1i2GIjp26QyRouYsQNFmgnmql/JzqSNdmJ3c/kLUe8eUO5XYkuh+V5YYm8YKqajQv6VLca9dBBv0Joi6YFgeOpxHpuNPS0tre8v0asfACc53j33ubXNtZcjRqfUNXtUQSd+tXb7FDzN51IUI7lw312IN4r/rhUKvxc1cVX2Bo4YMch4tN6uUuravxSySrNAerBRR5lNZFBPXyhVWkLAhrwumyL7nPOkuWKgnd4YB3HD/hKs+p+ogM015dzM0GY9fxiBOXiPoLIE3mv850DYmW1I2M5m2DtbRagVYxXaUHwxoDQukboeTB4MEft5ccny2hmeE8qJ1Hzhl/LhYlz7YDcaDSTVbUp6Y2Zi0O04WA1BqakDFAcgW3o8K7yijyLgDgdZgpZllbbM56B8BZzvOfF6WV0O+lVebnkB5HUnIhxs15l9MozVpVKz9uMTw1swQNI/esFy3sa6N/MMvoVmstohA0WunsK1GsK/8qloOliqZ1wUFLI1iUOZ4YoLvV6pjKj7J4M0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 053ceae3-5eb1-4039-6304-08dc3f89cb9f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5280.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 16:07:04.1707
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KzAEC6MlvqysFg7Vtu/gVpweBrKh7bCviobHIPEA/3F7dQPsqZtdiN8Jfhs/KR/ZVaGZRVuIOcM06laMiFI7o0c601hvXrjzypeOQ25c9Bw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7974
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403080129
X-Proofpoint-ORIG-GUID: pvL-3l7zilbGkkrlOdosCOSQbsNQZXBL
X-Proofpoint-GUID: pvL-3l7zilbGkkrlOdosCOSQbsNQZXBL


On 2/14/24 17:35, Alejandro Jimenez wrote:
> Use the tracing infrastructure helper __print_flags() for printing flag
> bitfields, to enhance the trace output by displaying a string describing
> each of the inhibit reasons set.
> 
> The kvm_apicv_inhibit_changed tracepoint currently shows the raw bitmap
> value, requiring the user to consult the source file where the inhbit
> reasons are defined to decode the trace output.
> 
> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
> 
> ---
> checkpatch reports an error:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> but that seems common for other patches that also use a macro to define an array
> of struct trace_print_flags used by __print_flags().
> 
> I did not include an example of the new traces in the commit message since they
> are longer than 80 columns, but perhaps that is desirable. e.g.:
> 
> qemu-system-x86-6961    [055] .....  1779.344065: kvm_apicv_inhibit_changed: set reason=2, inhibits=0x4 ABSENT
> qemu-system-x86-6961    [055] .....  1779.356710: kvm_apicv_inhibit_changed: cleared reason=2, inhibits=0x0
> 
> qemu-system-x86-9912    [137] ..... 57106.196107: kvm_apicv_inhibit_changed: set reason=8, inhibits=0x300 IRQWIN|PIT_REINJ
> qemu-system-x86-9912    [137] ..... 57106.196115: kvm_apicv_inhibit_changed: cleared reason=8, inhibits=0x200 PIT_REINJ
> ---
>   arch/x86/kvm/trace.h | 28 ++++++++++++++++++++++++++--
>   1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index b82e6ed4f024..8469e59dfce2 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -1372,6 +1372,27 @@ TRACE_EVENT(kvm_hv_stimer_cleanup,
>   		  __entry->vcpu_id, __entry->timer_index)
>   );
>   
> +/*
> + * The inhibit flags in this flag array must be kept in sync with the
> + * kvm_apicv_inhibit enum members in <asm/kvm_host.h>.
> + */
> +#define APICV_INHIBIT_FLAGS \
> +	{ BIT(APICV_INHIBIT_REASON_DISABLE),		 "DISABLED" }, \
> +	{ BIT(APICV_INHIBIT_REASON_HYPERV),		 "HYPERV" }, \
> +	{ BIT(APICV_INHIBIT_REASON_ABSENT),		 "ABSENT" }, \
> +	{ BIT(APICV_INHIBIT_REASON_BLOCKIRQ),		 "BLOCKIRQ" }, \
> +	{ BIT(APICV_INHIBIT_REASON_PHYSICAL_ID_ALIASED), "PHYS_ID_ALIASED" }, \
> +	{ BIT(APICV_INHIBIT_REASON_APIC_ID_MODIFIED),	 "APIC_ID_MOD" }, \
> +	{ BIT(APICV_INHIBIT_REASON_APIC_BASE_MODIFIED),	 "APIC_BASE_MOD" }, \
> +	{ BIT(APICV_INHIBIT_REASON_NESTED),		 "NESTED" }, \
> +	{ BIT(APICV_INHIBIT_REASON_IRQWIN),		 "IRQWIN" }, \
> +	{ BIT(APICV_INHIBIT_REASON_PIT_REINJ),		 "PIT_REINJ" }, \
> +	{ BIT(APICV_INHIBIT_REASON_SEV),		 "SEV" }, \
> +	{ BIT(APICV_INHIBIT_REASON_LOGICAL_ID_ALIASED),	 "LOG_ID_ALIASED" } \
> +
> +#define show_inhibit_reasons(inhibits) \
> +	__print_flags(inhibits, "|", APICV_INHIBIT_FLAGS)
> +
>   TRACE_EVENT(kvm_apicv_inhibit_changed,
>   	    TP_PROTO(int reason, bool set, unsigned long inhibits),
>   	    TP_ARGS(reason, set, inhibits),
> @@ -1388,9 +1409,12 @@ TRACE_EVENT(kvm_apicv_inhibit_changed,
>   		__entry->inhibits = inhibits;
>   	),
>   
> -	TP_printk("%s reason=%u, inhibits=0x%lx",
> +	TP_printk("%s reason=%u, inhibits=0x%lx%s%s",
>   		  __entry->set ? "set" : "cleared",
> -		  __entry->reason, __entry->inhibits)
> +		  __entry->reason, __entry->inhibits,
> +		  __entry->inhibits ? " " : "",
> +		  __entry->inhibits ?
> +		  show_inhibit_reasons(__entry->inhibits) : "")
>   );
>   
>   TRACE_EVENT(kvm_apicv_accept_irq,
> 
> base-commit: 7455665a3521aa7b56245c0a2810f748adc5fdd4
ping..