Received-SPF: pass (google.com: domain of linux-kernel+bounces-97319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Valentin Schneider <vschneid@redhat.com>
To: Vincent Guittot <vincent.guittot@linaro.org>, Ingo Molnar
 <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Shrikanth Hegde <sshegde@linux.ibm.com>,
 Peter Zijlstra <peterz@infradead.org>, Dietmar Eggemann
 <dietmar.eggemann@arm.com>, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 6/9] sched/balancing: Update run_rebalance_domains()
 comments
In-Reply-To: <CAKfTPtAwh-khpNw-=oku3VU8xR6qVpoL2hrzEF6u1AZ7WQ+3Cw@mail.gmail.com>
References: <20240304094831.3639338-1-mingo@kernel.org>
 <20240304094831.3639338-7-mingo@kernel.org>
 <xhsmhbk7tdkac.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
 <CAKfTPtCNnTVFdf85sRdJxPhdNZxc8qKcnHL3sznjg-KBVn8Bew@mail.gmail.com>
 <ZerlUU4kAv580rLh@gmail.com>
 <CAKfTPtAwh-khpNw-=oku3VU8xR6qVpoL2hrzEF6u1AZ7WQ+3Cw@mail.gmail.com>
Date: Fri, 08 Mar 2024 17:45:09 +0100
Message-ID: <xhsmhy1asd65m.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 08/03/24 12:57, Vincent Guittot wrote:
> On Fri, 8 Mar 2024 at 11:15, Ingo Molnar <mingo@kernel.org> wrote:
>>
>> Okay - I updated it to:
>>
>>   /*
>>    * This softirq handler is triggered via SCHED_SOFTIRQ from two places:
>>    *
>>    * - directly from the local scheduler_tick() for periodic load balancing
>>    *
>>    * - indirectly from a remote scheduler_tick() for NOHZ idle balancing
>>    *   through the SMP cross-call nohz_csd_func()
>>    */
>>   static __latent_entropy void run_rebalance_domains(struct softirq_action *h)
>>
>> Does this work with everyone?
>
> yes looks good for me
>

Ditto!