Received-SPF: pass (google.com: domain of linux-kernel+bounces-97333-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <67aa0476-e449-414c-8953-a5d3d0fe6857@oracle.com>
Date: Fri, 8 Mar 2024 16:52:16 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 03/10] fs: Initial atomic write support
To: Jens Axboe <axboe@kernel.dk>, kbusch@kernel.org, hch@lst.de,
        sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com,
        djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20240226173612.1478858-1-john.g.garry@oracle.com>
 <20240226173612.1478858-4-john.g.garry@oracle.com>
 <1f68ab8c-e8c2-4669-a59a-65a645e568a3@kernel.dk>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <1f68ab8c-e8c2-4669-a59a-65a645e568a3@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?cDIwcU82aHZYaUhLcjdPREwwNHZlekduSERSdHJ2bGhNT0JxcHdGc1R0Q1lk?=
 =?utf-8?B?TjhTN2FTQlJGWWppdHk5cFFOa1k0WEpHbVZLWFEvdWZvY0tzU1h4YkY4Y09a?=
 =?utf-8?B?TzJtd1YwNmUyNGxVaW1EeDNQcW5aUGt6SW5PNmc5a1o5RUFLRFd2T3F1VTJa?=
 =?utf-8?B?TEF6TE5kQU9LcVRWcGNzVUdPN1FZcU8vZytSZEpIWkhsalVXUWhYczFDK3M5?=
 =?utf-8?B?dFVBS2RpM0xrL2gyVi93amxtU0x3eGtSSDlSc2dIeHBnMUU1MWVSbnlkNldF?=
 =?utf-8?B?M1BYYjd5RStoU0p1eGVhSXVXSVdETFNERlZIVXB4emw0QUxKa1pQRWREOXp6?=
 =?utf-8?B?a3FrNUkzb1A5U2ZIWGxWNTRydnVnWk8vUlRjQllncy9Ea2dzRWRBUmZub3NB?=
 =?utf-8?B?MFlnV083SHlYai9kL045aWFMNzFhUkdnZjRFS1I4M0pINmVKMjZmc2ZGZlQy?=
 =?utf-8?B?RDRnTnZ1MktjT2dUVFBNN2xKL2hNYUM2TjFSK2d5Zzd3b2Ywc1ZQdjBEVDJn?=
 =?utf-8?B?ZjBNMTlGcnBuRUdwWjNZT0lLWStsNUUyZ1lTWlNxTlFLbGFKTkxHdm9abTVw?=
 =?utf-8?B?YkVReGM1bm5GbUp1Q1UydHc4czdaaHJIaXZRdUhPd1B1SEM1VisrMmFwL1A2?=
 =?utf-8?B?Q3VNaks1cVA4WUhOVkpQL0c1eXh6NFdsdElzYVJPcUx6KzdxVi9KWmszeEwy?=
 =?utf-8?B?OUNLUjRZSkxSTmY4Y1lnMi85N0QxNEYyL0l3b25sWUV6MlFWMFdHWVljYUZE?=
 =?utf-8?B?RVRPNmdTdXdvMjVjR3o3QmNLYUwyOHNEWjRTT2tjdWJwSXl4V0U2b216Nnpl?=
 =?utf-8?B?L3FCbnhZNVRYTmE0MThxNUlLSEgvd2pmaXRiZ2RJbEtWZG5zS2dMWGx2MDZ4?=
 =?utf-8?B?VlRleFNyU1R6OXZ6blZqbmt1V242L2FXWG1FenNkSmNPMVdOREwvM0tUYkNV?=
 =?utf-8?B?dk5pYVAxdEJPbVRTN21wZ2NZMUxIU0pYSzZxNnJ1Yldrdk5NOTUyWGFXOTlY?=
 =?utf-8?B?NWtCNFhZRXdneVRMd2lSdzJLZGxlbDJ2UnNib3dlbXdDZWlQMTQvYUhtc0Zj?=
 =?utf-8?B?blhxLzdQb1lBOStIdkZEbGl5d0dXWWxhNE9GMUNHNzJJK2xVeG55V3ZQZGFL?=
 =?utf-8?B?aDMrYzRxTFUvcHVnV1dFdUw3ejZqSUZSRXVMa2JmeExiUDdLM2phWXFNSm5W?=
 =?utf-8?B?RFh4T1JheUUycUUyL3lsSHpsV21YQXlaMkJycEp1dFIyTGxaM0g4ZGhjSUdN?=
 =?utf-8?B?M3lwRGFjWDZ6VnZpQ0xkVHIrS1BKbG9FcWNrWGx0SGpxRnhwRlEvbU1vbWVa?=
 =?utf-8?B?WFNuN2d1TkZzN01mNk91Nm1lVGtjbE5ZSW9PNDFycHJiTUd5WlBrZ0hoTEdx?=
 =?utf-8?B?VTUzMnNlaVRJZThlRWs3VVYxRWtwdTdTUFVmc1k5a3VRek5zMVhUWW8vT1FV?=
 =?utf-8?B?RWlBeVU5OUo5TjdGUFVqUHBDekpIWmJuL2dZU1ltL1lwQUJtK0toSXhNcnc5?=
 =?utf-8?B?cDJ5WUhhNmY0d0NVV0c4VzZZYlA3dW5kMVR1eW5yTzd0VDZJaWlSWGs5OWlX?=
 =?utf-8?B?dE4xS1REcjZtREtES2dHaEFkU0ZGTWZXL2I5SW1QUTNtVzU0UnRoNjFnZU1E?=
 =?utf-8?B?K3d3cmNYNE5hMFBFNU5OSmhGWkV5OXloTThoaFRINFRFay9oTFFPdnp6RnRR?=
 =?utf-8?B?QXBTdGEvcVJLbDlTaG41OTVHTkRna1VFVTJiMlJKSzl4UG1seERmYXR6V0pp?=
 =?utf-8?B?Qlh5MUhmM0wrNVVJbjRxUC94SG4yQTk5SjVjK1o3ZDFMZnJ6YVZ3Z2lkcG55?=
 =?utf-8?B?ejlpYVgrRlRPRC9EeUYzN2dVeTUrVzhkbGgxTCtEcy9BZE9IaUN0SExBWUpN?=
 =?utf-8?B?ZFROOG5vOStSc1U4VEJnR0hzQzZXbklPMUhYb1JaL1dxcWIxaVUvVFd3ajlH?=
 =?utf-8?B?RG9sbWJMUHJLY1M4aTNGTUlRM2hhNWNPcDgwVEltdHhINFIrUzA0Q3BmWmxL?=
 =?utf-8?B?czgxT1pySTJEN3NRTmtLZHVEZE4xUFJoQTdvSERVUytlZU1FMC9seHhHTlZi?=
 =?utf-8?B?TjVYNHJOOFRvWUFlakx0aUIxOUY2bFlxR2NoK08vcmhMZUFjZmQ2c0JFZjB4?=
 =?utf-8?Q?TDcqUMu/am0BADZuJkAr8E7Wp?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	o5FTYdO17qic26cnr8XA9S0P0yn1EXTAnHb6LyYNfbmaExFugKorewyDmii/XFrKayQVPLa/M/tXtvYFynE2BT4heiq2uI/QZaN4SCTsuuVaKDfj+pNNKL9xQLjZlNxkuO3F7nsCP60RFhB9vWRpz7LH1+kRL19OMWbyM2m3NhoDnPfuxHf8NMkOAjyDv73/+88GZ4p96GPXngy+fdBxVRI1njcIs9hDEXmRPZfskQCfqzBiMMj3h5nS5vG+R2TW5wVfeRfODI1rbbmtNzOJCAlff13CiU4YqiE67VdLftVsxReuWfbX7oDNeDO25cQqu2ZrkuXEEBH2wnW2c+HrcQR7zdzO0UCbRiVLdHL7z3mAbRca3vhiiP2RERjrDX4XTd9atR1ZcAmxxEPB1WD9QUDk7wnVZZQY6bhmrzCsqlJz5bWVSqan4XGHypHQ3L4h4u6awXST6peNdFYTVPpGkJX9t+AKPKvqWQsZW2qJZDScsdgJcM+OI3P/qtXdcMOmHDuIp75ZL1US6ZxdfTWqxqA4EsALMObfPFUwh8vAAJd3Q/MPW72iM46mMwIy8latTMlKWUNP4oFaFhtvcC/0SfvZ8xmUIexqf7FFEytqMsw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: acb233fe-1d5e-48f7-4385-08dc3f901fab
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 16:52:22.0970
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wKu3pZWmtKQXXPzAn90lPQd3qJTnuAw2LvdnffEbbfolRsX0lMDcQUjfW3Uy98gaJS0sMn9/XtO6XtqFmvyFEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6103
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403080134
X-Proofpoint-ORIG-GUID: PkyvtIplIwiCo8UOrXD0ZlbfgYlbvmfL
X-Proofpoint-GUID: PkyvtIplIwiCo8UOrXD0ZlbfgYlbvmfL

On 08/03/2024 16:34, Jens Axboe wrote:
> On 2/26/24 10:36 AM, John Garry wrote:
>> diff --git a/io_uring/rw.c b/io_uring/rw.c
>> index d5e79d9bdc71..099dda3ff151 100644
>> --- a/io_uring/rw.c
>> +++ b/io_uring/rw.c
>> @@ -719,7 +719,7 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode)
>>   	struct kiocb *kiocb = &rw->kiocb;
>>   	struct io_ring_ctx *ctx = req->ctx;
>>   	struct file *file = req->file;
>> -	int ret;
>> +	int ret, rw_type = (mode == FMODE_WRITE) ? WRITE : READ;
>>   
>>   	if (unlikely(!file || !(file->f_mode & mode)))
>>   		return -EBADF;
>> @@ -728,7 +728,7 @@ static int io_rw_init_file(struct io_kiocb *req, fmode_t mode)
>>   		req->flags |= io_file_get_flags(file);
>>   
>>   	kiocb->ki_flags = file->f_iocb_flags;
>> -	ret = kiocb_set_rw_flags(kiocb, rw->flags);
>> +	ret = kiocb_set_rw_flags(kiocb, rw->flags, rw_type);
>>   	if (unlikely(ret))
>>   		return ret;
>>   	kiocb->ki_flags |= IOCB_ALLOC_CACHE;
> Not sure why you took the lazy way out here rather than just pass it in,
> now there's another branhc in the hot path. NAK.

Are you saying to change io_rw_init_file() to this:

io_rw_init_file(struct io_kiocb *req, fmode_t mode, int rw_type)

And the callers can hardcode rw_type?

Thanks,
John