Received-SPF: pass (google.com: domain of linux-kernel+bounces-97338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 8 Mar 2024 16:58:16 +0000
From: Conor Dooley <conor@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v6 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <20240308-croon-goofball-797d091e981a@spud>
References: <20240308-asrc_8qxp-v6-0-e08f6d030e09@nxp.com>
 <20240308-asrc_8qxp-v6-3-e08f6d030e09@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="AtYEuJt27XJncbRZ"
Content-Disposition: inline
In-Reply-To: <20240308-asrc_8qxp-v6-3-e08f6d030e09@nxp.com>


--AtYEuJt27XJncbRZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 08, 2024 at 10:30:52AM -0500, Frank Li wrote:
> Some sai only connect one direction dma (rx/tx) in SOC. For example:
> imx8qxp sai5 only connect tx dma channel. So allow only one "rx" or "tx"
> for dma-names.
>=20
> Remove description under dmas because no user use index to get dma channe=
l.
> All user use 'dma-names' to get correct dma channel. dma-names already in
> 'required' list.
>=20
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Please drop my ack from this, this isn't the patch I acked originally
and we were having a conversation as recently as yesterday on v4 about
this patch because Rob didn't like this approach. His suggestion is
better than the one I gave on v4 that you have used here.

Please give it a few days between resubmissions, and do not send new
versions of a series every day. It is very confusing to have different
conversions on three versions of this patch in my inbox all at the same
time.

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Docum=
entation/devicetree/bindings/sound/fsl,sai.yaml
> index 2456d958adeef..93e7737a49a7b 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> @@ -81,15 +81,13 @@ properties:
> =20
>    dmas:
>      minItems: 1
> -    items:
> -      - description: DMA controller phandle and request line for RX
> -      - description: DMA controller phandle and request line for TX
> +    maxItems: 2
> =20
>    dma-names:
>      minItems: 1
> +    maxItems: 2
>      items:
> -      - const: rx
> -      - const: tx
> +      enum: [ rx, tx ]
> =20
>    interrupts:
>      items:
>=20
> --=20
> 2.34.1
>=20

--AtYEuJt27XJncbRZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZetDpwAKCRB4tDGHoIJi
0p1zAPwOVqZkJw5DaQiuRLY7UuKy72/FOl/NK/YmqCZ4DyG7uQEA+Ki09p+Lossj
bxiyf19v0Oygl2gWDK2Oq8f11MiHpgA=
=OJXG
-----END PGP SIGNATURE-----

--AtYEuJt27XJncbRZ--