Received-SPF: pass (google.com: domain of linux-kernel+bounces-97350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 8 Mar 2024 10:03:18 -0700
From: Alex Williamson <alex.williamson@redhat.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "eric.auger@redhat.com"
 <eric.auger@redhat.com>, "clg@redhat.com" <clg@redhat.com>, "Chatre,
 Reinette" <reinette.chatre@intel.com>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] vfio/pci: Disable auto-enable of exclusive INTx IRQ
Message-ID: <20240308100318.0794f51a.alex.williamson@redhat.com>
In-Reply-To: <BN9PR11MB5276DBB5FBC36939EB39A3CA8C272@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240306211445.1856768-1-alex.williamson@redhat.com>
	<20240306211445.1856768-2-alex.williamson@redhat.com>
	<BL1PR11MB527189373E8756AA8697E8D78C202@BL1PR11MB5271.namprd11.prod.outlook.com>
	<20240307132348.5dbc57dc.alex.williamson@redhat.com>
	<BN9PR11MB5276DBB5FBC36939EB39A3CA8C272@BN9PR11MB5276.namprd11.prod.outlook.com>
Organization: Red Hat
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 8 Mar 2024 07:23:21 +0000
"Tian, Kevin" <kevin.tian@intel.com> wrote:

> > From: Alex Williamson <alex.williamson@redhat.com>
> > Sent: Friday, March 8, 2024 4:24 AM
> >=20
> > On Thu, 7 Mar 2024 08:39:16 +0000
> > "Tian, Kevin" <kevin.tian@intel.com> wrote:
> >  =20
> > > > From: Alex Williamson <alex.williamson@redhat.com>
> > > > Sent: Thursday, March 7, 2024 5:15 AM
> > > >
> > > > Currently for devices requiring masking at the irqchip for INTx, ie.
> > > > devices without DisINTx support, the IRQ is enabled in request_irq()
> > > > and subsequently disabled as necessary to align with the masked sta=
tus
> > > > flag.  This presents a window where the interrupt could fire between
> > > > these events, resulting in the IRQ incrementing the disable depth t=
wice.
> > > > This would be unrecoverable for a user since the masked flag preven=
ts
> > > > nested enables through vfio.
> > > >
> > > > Instead, invert the logic using IRQF_NO_AUTOEN such that exclusive =
INTx
> > > > is never auto-enabled, then unmask as required.
> > > >
> > > > Fixes: 89e1f7d4c66d ("vfio: Add PCI device driver")
> > > > Signed-off-by: Alex Williamson <alex.williamson@redhat.com> =20
> > >
> > > CC stable? =20
> >=20
> > I've always found that having a Fixes: tag is sufficient to get picked
> > up for stable, so I typically don't do both.  If it helps out someone's
> > process I'd be happy to though.  Thanks,
> >  =20
>=20
> According to "Documentation/process/submitting-patches.rst":
>=20
>   Note: Attaching a Fixes: tag does not subvert the stable kernel rules
>   process nor the requirement to Cc: stable@vger.kernel.org on all stable
>   patch candidates. For more information, please read
>   Documentation/process/stable-kernel-rules.rst.
>=20
> Probably it's fine as long as the stable kernel maintainers don't complai=
n. =F0=9F=98=8A

I think the stable maintainers are far more aggressive than the
documentation would suggest, but it doesn't hurt to include the Cc,
I'll add it next version.  Thanks,

Alex