Received-SPF: pass (google.com: domain of linux-kernel+bounces-97362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <8fde7b95-fed0-4cfd-a47e-455cccf1a190@oracle.com>
Date: Fri, 8 Mar 2024 17:15:21 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 03/10] fs: Initial atomic write support
To: Jens Axboe <axboe@kernel.dk>, kbusch@kernel.org, hch@lst.de,
        sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com,
        djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
        dchinner@redhat.com, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com, ritesh.list@gmail.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <20240226173612.1478858-1-john.g.garry@oracle.com>
 <20240226173612.1478858-4-john.g.garry@oracle.com>
 <1f68ab8c-e8c2-4669-a59a-65a645e568a3@kernel.dk>
 <67aa0476-e449-414c-8953-a5d3d0fe6857@oracle.com>
 <eef12540-84b6-4591-a797-6cfea7b28d48@kernel.dk>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <eef12540-84b6-4591-a797-6cfea7b28d48@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TFVQVjB6L0t0a2sxYnIzTEIrYnBEYm5UV3dlMjU3Y2FPR1NBQjV3Q2tKWWtn?=
 =?utf-8?B?SGN5alRnck5JYVI1TllMa0loZjJ2ZTl0OThKMGExeHZmLzZPcFgrNkZCblkv?=
 =?utf-8?B?d2VrL1A3UDFPVVJZUk55VEJQa3VRZXFBVCthRXZsZ2pCczE3Y2lmbXJjRWd1?=
 =?utf-8?B?Y2E4S3YzdHNDdDVuQTJxVXlQaDZUeU1sZzlDWmE1ZlNTeW5BQXB3TUptWGp2?=
 =?utf-8?B?dG9kbVhGbnVXSkRCUmtHVGtTVFVIYlQyRXVFTzBxTzBzSi8rWXZ3aHNOZHhJ?=
 =?utf-8?B?RmhOalg3OVIxRWFPcytCbTNPQzBpSFliMWJsMFl2Ky9Hait2MS83RlRsOG1E?=
 =?utf-8?B?SkFlT1IyMElxaFZwRG01eVpneHdJS0t4SDhUNmdiaTgycVZUR3EyWXkrSEk1?=
 =?utf-8?B?ZmVtMWdvTW9uaklrbnhZUktPbkFaWTRPaVlSVzM5bFJoK1VWSkFmc3h1S0Ft?=
 =?utf-8?B?MDFGT1l6Y04reTZzQi9YZGthL1JQT0pvVy8yV0NFMlE2b1ZreFIyekdtNG11?=
 =?utf-8?B?YlJXMlJjSEtaSTZieHZJaXRHOXF4RDlLaTlWNjZMVTRvZzNtK1MvNU5qQU9j?=
 =?utf-8?B?SkRGKy9wNHRoWGh4L21ENHduNFJoTmh4TGFXdE1rZzI2VzFycGx6VkovQ1NU?=
 =?utf-8?B?N3lsWE9yVGVFdzZNNW80TDY5WUFBZy9wRnluMDJSb1VmdUszZmFlaFBEalNz?=
 =?utf-8?B?UXB1N0llVTlGOU1TQ3hhWFFXMzZaaDg0M2VyRWZVQlRlNXBJVjNYckZCRkh0?=
 =?utf-8?B?YktYclJnVlUwTlE0SDEzYm5CZDVmTW53M09LdkQzeDQ5SmlXcFB4T1YyZWYw?=
 =?utf-8?B?dU1laTcxQkNvRUFvQ1JzZ2dDNFdObmNUYi9IQ2FNa3dpa3owNGM0OHFqeXRJ?=
 =?utf-8?B?aDl1Mkt3RkIrRlhBZGs1OXN1T1NCVWJKT3hucnNPUEFJeEhVU1dIZGNlOUQy?=
 =?utf-8?B?b1V1MkpFTDlWaVRQTHdwV0FtdndnY1pvZGkyNnEycVpZbE1KMHl4Ym9ZRDd0?=
 =?utf-8?B?dGhhbERjdmJkYm1tQXFkVFpDNGpzMW9vM0JJa25KNWtaUUNhOGtxcndrYXUv?=
 =?utf-8?B?RFZXVGU5QmZIUHBIQkJhYXlRWDh0b1NncXAxc1BjWWw3MFJwOUpVMmtzRERL?=
 =?utf-8?B?ektHTXMza0FKL2xiQTJwaGxPMDRGODVjaS9EZzM5cUdiU0VyZ2dJelN2dHNl?=
 =?utf-8?B?MzRUR0xQd3l2Z3c3NEYzSVc5YWVjTVJDSTZERHJPWGQrcG11dVZIS2RrREFW?=
 =?utf-8?B?NGRzNHc3YWxaQVlJenloRTJTUzN4SzdZbnZUb09YR0Y4VThuVXpsdlhidWpu?=
 =?utf-8?B?T0xzL0dJNndhYnhCZXp1NEtoS3pOT3hCeER3Z0ttWDFSYmhHbnh0NHlRc2k3?=
 =?utf-8?B?MXJlZGJJQzJjRjRwSkd3RGF5QzFkcFNROGVLUGNJb0t2SnExS0dKTkhSQ1hW?=
 =?utf-8?B?cnZXYzY3YmJxSFRydVlxVGZOMWxyanUyRWEvMXJOejJoSWRGVFRMZ21odnFT?=
 =?utf-8?B?aFA1clc4ZGxRd0FlODhBV0RJSVZaMjhzNlNtamZNT0pQd0N2MW00c1Z2eVRO?=
 =?utf-8?B?ZWIrNm5LOXYxNkYrMldkQnNGdk9KeUh6WDNsTkdyUHBOd1VYMExWUmxJRXVu?=
 =?utf-8?B?QlYyblhmaW1LNkU1YUlCRjVNa0IwbTlhTjJCN0J5RG1OTnoxR2FrbmdDbmZN?=
 =?utf-8?B?Nk5pSWVpbWE0bDVVNWN3TjZxOGRBeDlUYWlrR3lueTEvc0EwT3JiVkxGVHYv?=
 =?utf-8?B?Y29LN2JUd3hYayt1M3RYMHpjRVZlMDZEKzJrWkNLeU5OTzg2VWNYTm1OR0xo?=
 =?utf-8?B?MFIwUmU5SXF0VnFHYzBYbXRJamJncXBwbnVyb2VsNDNNWHE0Z0g3YWgwNW1O?=
 =?utf-8?B?YnhCdmdxWnJJT01RTVcvUnNVTUhpbW5VRTZUYnZOdjd2QnpYaHRQOUswcmhp?=
 =?utf-8?B?U0NFQ0tBSVBGdTBwZytJcWhtTmsybkxrWjN0b2sxWGxLcG44Tm4rcHFURnd0?=
 =?utf-8?B?cy9LYXNSUTJpZnZ4ZUQ2Z2lzclFZMWx5R2JaLzIyeVlLRTNXelozRXFDaDlY?=
 =?utf-8?B?Uy80eklpWThNejhYNXFWbzc2SnNzVGswUGUyTW41cXVwN0NLZit5TG1xbDdO?=
 =?utf-8?B?VW5BTVZ5cDl0ekR6RHFlY1ltWjA0bitocjZDRFFYamRYUFpnMktXbVBhdjdr?=
 =?utf-8?B?SEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	oGJLbrcxkChio5G+5+QAgwTpCz3e9Br5c7IhILB8lRmxSfBeky3/YIqrbkDQqiOIpTSSlPN3IVgxBVT54j7etGaaTCk+aKayV9pOCr0V5YnaFbSb4dcIIpqPVKltGjMHV0EdM5NC5Yuumhc0toddoy8ZSjcmOgoMRjdvAUInk8Fn0SDJZDojtKii3HpXZvEZJfEDDybCCLRt1WFw4sZc6/Z5Gfetp+PoSGlNYm2JC1E3FMaTXyR8F8U9YW3uT2LP+3yw5ACeIQ8y3FByJzSnwKMzT4p3N38NwtMuyjAw5tCSaPdeJTXaYla0A92H6/LChimXjl8fxGnpMdyLxxeBO1PO2QfDdXl24u6mNXUTDO5Kue3lSCVXAxPSlwHt0uuW1Dk8V3S2XED+5DiuO9JyjbIOTHbpOJd5Z+KKqXp4pLt6BW0tub7teMoX7zVxx+UqPJQ5akfQsZyWWyuWYqW8XUCUMuF/EP452fv/3ISU00+/3cIImJqV5KIs28ULOiLnOV7VVfUYqpAAtY8U+p1b2wdGCS1kZ6VL1BwJZHEpmIJDwShyAqdltdXETsYPNUbSu2cYHCS6ZheGzongvhiRVp91w7M38StLfuC8LlqkIx0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65341a53-f80a-4ad5-bbe4-08dc3f935925
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 17:15:27.0085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ExPPbV42Vsx8g8bKCB+DCJb/TthDuKJLcDjsECrdURmv8kX+w7jbVvGGREoPiMQVWnIqrD06FZC9LomWbbF6uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7591
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-08_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403080137
X-Proofpoint-GUID: qAkaUOvEcGE5W-AVY4TFaEcS1HFT8DcR
X-Proofpoint-ORIG-GUID: qAkaUOvEcGE5W-AVY4TFaEcS1HFT8DcR

On 08/03/2024 17:05, Jens Axboe wrote:
>> And the callers can hardcode rw_type?
> Yep, basically making the change identical to the aio one. Not sure why
> you did it differently in those two spots.

In the aio code, rw_type was readily available. For io_uring it was not, 
and I chose to derive from something locally available. But that's a bit 
awkward and is not good for performance, so I'll follow your suggestion.

Thanks,
John