Received-SPF: pass (google.com: domain of linux-kernel+bounces-97379-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ec15db92-24bb-46eb-963c-e872ff2ac9e3@intel.com>
Date: Fri, 8 Mar 2024 09:20:33 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/17] x86/resctrl : Support AMD Assignable Bandwidth
 Monitoring Counters (ABMC)
Content-Language: en-US
To: <babu.moger@amd.com>, Peter Newman <peternewman@google.com>
CC: James Morse <james.morse@arm.com>, <corbet@lwn.net>,
	<fenghua.yu@intel.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
	<bp@alien8.de>, <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	<hpa@zytor.com>, <paulmck@kernel.org>, <rdunlap@infradead.org>,
	<tj@kernel.org>, <peterz@infradead.org>, <yanjiewtw@gmail.com>,
	<kim.phillips@amd.com>, <lukas.bulwahn@gmail.com>, <seanjc@google.com>,
	<jmattson@google.com>, <leitao@debian.org>, <jpoimboe@kernel.org>,
	<rick.p.edgecombe@intel.com>, <kirill.shutemov@linux.intel.com>,
	<jithu.joseph@intel.com>, <kai.huang@intel.com>, <kan.liang@linux.intel.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<sandipan.das@amd.com>, <ilpo.jarvinen@linux.intel.com>,
	<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <eranian@google.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <1ae73c9a-cec4-4496-86c6-3ffcef7940d6@amd.com>
 <32a588e2-7b09-4257-b838-4268583a724d@intel.com>
 <088878bd-7533-492d-838c-6b39a93aad4d@amd.com>
 <9b20589b-6220-4ae7-bfc4-4a826b7114b1@intel.com>
 <5ddb7031-a828-4001-bfdf-5477cb85e9ed@amd.com>
 <1738493b-3248-4c9e-82a8-1599a033440d@intel.com>
 <369ab28a-f3fa-4359-8e73-4dcf214c9b6e@amd.com>
 <54687d59-d0e4-4fe7-b25f-dc1fead01ea1@intel.com>
 <11487a31-908e-d474-50c6-65617d417deb@amd.com>
 <c73f444b-83a1-4e9a-95d3-54c5165ee782@intel.com>
 <55b545fd-2851-0d0f-ac37-ec59838fb4b4@amd.com>
 <1f366890-d9ff-4ac4-9af9-1ea3128a87fc@intel.com>
 <41ca7504-c3fb-ddb6-e149-4ff82019d678@amd.com>
 <CALPaoCi=PCWr6U5zYtFPmyaFHU_iqZtZL-LaHC2mYxbETXk3ig@mail.gmail.com>
 <1d3e8b68-28fa-419b-b129-0c39df34f718@intel.com>
 <CALPaoChJPkfrMgFDhtZqwK7O8=A71CKLzQjEMG6LbgB9RhdzvA@mail.gmail.com>
 <e90ce54c-a830-4ba5-8b28-aeef06705d01@intel.com>
 <46065d68-8334-4b76-bc68-c2695e7b98de@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <46065d68-8334-4b76-bc68-c2695e7b98de@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnlvTTQrbzA4REV0ZlpuRkVCMXFEekdXV2IyNnJRTm5oTWJrSk1iWGpSazNt?=
 =?utf-8?B?SzhhYWpWV25IVnJnVkFEenRIK1VYdEF1d3F2Y0ZRdWphYXl0VGgxazRudi8y?=
 =?utf-8?B?dnYrOUZUVEptdUJRd3ZqT21BbENFalhBSk9lNGJ6VHRUNHB4U2k0TFJYazlI?=
 =?utf-8?B?cWFLcGlrSENUYXBEd1BDRUZUY1dKaXlTYTBMTWdQVGt1ZzhSN2NTNEUwNzg4?=
 =?utf-8?B?M3BQK2FsUmFlbld5OFcvTDNrVVZKbWtCeUpRK1BLaVJlZmRZUXJoY0VvMFNx?=
 =?utf-8?B?QVhQM3hMTGFDY0tGOVVTclh3c1I4V0lubkk5VktFb1JVdnBiZWV3Qy92V3FN?=
 =?utf-8?B?ZjIrdGtFL2U2cU44Ujc2WDBHeFdTTzdsaVlXUG5LN0J1SkVWZ29qWDArVjZE?=
 =?utf-8?B?VzYxUzF0NWxvWlZ5TUFxYzZkeEJ3RFRTTGhITmVSVDdka0RPS09oOGhGOEpX?=
 =?utf-8?B?WnNjeGRjY3BWd2lkUVRmV3Y2aUptZytaY2tHSGMwR0kvNjNZVTFwSXBhM0ZN?=
 =?utf-8?B?THNGUmFteWdlWDR1eEdGY1l2ZEpDWkZuR2ttVnE2OEJESWoyNWRoMnNUcWdZ?=
 =?utf-8?B?THcwd2xoOXY1cmQvbVFTZmtXVUlOVXJQVkRNK2lWR29nemFMV2UyMEhQdVF5?=
 =?utf-8?B?UHA0SWsvajg5WlpEbmZQck11cDVTQk8xaS8wMnRQeG1ObkhKL3h6a245UG9w?=
 =?utf-8?B?LytWMG85bk1yYXcvcUZuWTl3QldaMkpZTmV4aEUrUHBUVnQ2dFAwejFYRGdR?=
 =?utf-8?B?d3I1ZGpsUHJCTkVtanU3bDI2c0pVcUduMi96QjUybWQ0VDJmT01yOTd0aTcv?=
 =?utf-8?B?V2NiemNoWllLTU5URjhMZk9LcGUwVVd4UFU2RDNNNkxiVUNKMnpRSlRUWVhr?=
 =?utf-8?B?ZmNXOElZamc0dEZLVlAxT1dZNGFPS1pnWExkaEtxUHk4RExwVjBGLzVPWHRG?=
 =?utf-8?B?Wk16QTFnL2trWktRTlltdnJsUERaUklmTXBMNkhkSmdWOFRlZ0hzdXJZOTJp?=
 =?utf-8?B?QndScERpeHppWVVIYmszbEo1NmczS0theUcyU2dkQ3YvZUNCYXZtNE9hNWkx?=
 =?utf-8?B?OVlnc0FaR0VWYkVwUTREQ3crNmw3cWR6dTY1eXZUZlk0ajVzM2V6QU9KanE3?=
 =?utf-8?B?NTRPeDM1MXNscFR4am1odyt6cHk1WGFEZ2VOejE5cFFuOFBMN211cDNiQ3hz?=
 =?utf-8?B?Q1hKNitLZithcWdNWlpzMkFaOUg0NDRuSGRaSlVIUTRQMkNWV21JeC9uK21z?=
 =?utf-8?B?U09ud1lvdEUzRUhUMDR1aDBiTjFpQk5tZmFxN1dEdmJrcjRHNTZuYWlieHQ2?=
 =?utf-8?B?d2QzYlpGdW11Q3FiaXlHK2Nyd2QzZE0zVTB5dnhqUzkxT1FSRXJxWXIxNGVS?=
 =?utf-8?B?c2VvSXRVM0hNWnZ2d21qbmNYZEY4WjV5aDcxa2NhdFFTNzRHQjFqL01QQnMw?=
 =?utf-8?B?UndZcFJRZDREZytwVmY0Uk0zVGRDNUVlOUVLZ2Y0NGZkZ0wydnV1YkpETGdQ?=
 =?utf-8?B?L1B3K3A1N3pDVk9JUG5qMG56K2U1UG5OWnJsVnhpNFZVWEVnRlI0M3M3OU9m?=
 =?utf-8?B?eXZEMzhLdzkrVHoxZnRibTZKN3I1c0tpd2FlRFVKL2t6L1hFMjJHYStHdjh6?=
 =?utf-8?B?b3FoVVVaYVlEbUhheXh5K09xWE0zOXBaK3B4Nko4c2VnNTk2WCsvRk5aMDJD?=
 =?utf-8?B?NzJsa1VKTXBpdDhLWHVPTERRN0RpWisxV1BuZW5UM1oxaEQ0RGl3RDhnbW9V?=
 =?utf-8?B?TlRzMFQ2QitkVzYzZFZVVGptM1hNNjJkYklsNmRZSDhPdlRFN0hhVDhmdUpm?=
 =?utf-8?B?Y3dwdS9FVVp4TmFQT2ZpRmRNSVV5UjgxekN6L0hFUTh4Y0RmM2tKcEVYTWVy?=
 =?utf-8?B?amQ0SUJYZlNXNStSOXNLSGd2d3p5WElqOWQ5SjZoR09IOGhaQVlXTTltZklB?=
 =?utf-8?B?OC9WaXVxNkpST0NxbUx0UzBiNUg2TXl6Vkd5Z1JVN0JTL0ZqZUszMGRqbDVy?=
 =?utf-8?B?a2wzWmxDMFlWSHRMV3hQYVMzS3NCRnljbW9yaWtoOTVoMllIN0lHQ1I5SFRS?=
 =?utf-8?B?V1Q0SUl3YWpSVU1QaTAwRlc3RkhBNGY4elpqcnpOazJZanlNVGJLVEs4VDQ4?=
 =?utf-8?B?K1NPZldFcGVheVVuUGhFVzR5aUJ3UmRWcTBYZGw3dmFTMWl2YkVScG1XYWty?=
 =?utf-8?B?Q1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ae9be0-4df8-4714-7e19-08dc3f9411c2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 17:20:36.7765
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YuwfwMhCM8dDOccAXJ3Kaa00jggwIfyjFppV+bU3giTMM4/Jq7W5BvifhGa762DLMsbdd5OTfg0RIIgKOZ4iPj3fyES6ZgVWQ+ycjpTOKus=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4760
X-OriginatorOrg: intel.com

Hi Babu,

On 3/7/2024 7:50 PM, Moger, Babu wrote:
> I am also thinking about replacing the newline requirement for multiple
> groups. Domains separate by "," and groups separate by ";".
> 
> Something like this..
> 
> "/c1/m1/00=_,01=_;/c1/m2/00=_,01=_;/c1/m3/00=lt,01=lt"
> 
> Thoughts?
> 

I would prefer that resctrl uses as consistent interface as possible
between the different files. There are a few files that already
take domains as input (schemata, mbm_total_bytes_config,
mbm_local_bytes_config) and they all separate domains by ";".
I thus find it most appropriate to stick with ";" between domains.

Regarding separation of groups, in schemata file for example it is
already custom to separate groups (resources in that case) with "\n".

Reinette