Received-SPF: pass (google.com: domain of linux-kernel+bounces-97403-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Prabhakar <prabhakar.csengg@gmail.com>, Geert Uytterhoeven
	<geert+renesas@glider.be>, Chris Brandt <Chris.Brandt@renesas.com>, Andi
 Shyti <andi.shyti@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Wolfram Sang
	<wsa+renesas@sang-engineering.com>
CC: "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Fabrizio
 Castro <fabrizio.castro.jz@renesas.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH 4/5] i2c: riic: Pass register offsets and chip details as
 OF data
Thread-Topic: [PATCH 4/5] i2c: riic: Pass register offsets and chip details as
 OF data
Thread-Index: AQHacX4tmFc1CI8ipE+h03wpRb2Q9LEuGoKg
Date: Fri, 8 Mar 2024 17:36:32 +0000
Message-ID:
 <OSAPR01MB1587CFE774834B31820E7D5486272@OSAPR01MB1587.jpnprd01.prod.outlook.com>
References: <20240308172726.225357-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20240308172726.225357-5-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20240308172726.225357-5-prabhakar.mahadev-lad.rj@bp.renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?tuBDkR2bH1/jcdac4j77ZrP/SvMY6g4KpqrACXXxHO14Wdsv817j5+bOYNm6?=
 =?us-ascii?Q?mZw7D2gqkrAMZsGKzlmTtFbzrf58ss7KUsJnDzr1TBE8O1E9APve+yjCtCyK?=
 =?us-ascii?Q?Zb2ztttdBPGCcWaJcILFWItOQHiFi2jAaVxk7g8LK87Bu99UZ4gwFKh9qFzQ?=
 =?us-ascii?Q?0kylAxFYjNruPq3a3JC7lbbuUQY8OpxYNzUytHRcwTBWjd33xzL8g35fl49R?=
 =?us-ascii?Q?c59fc396red+NtGdloq7plZjB6+7XSssr/5yMkTMym4PEyLsdXjg9D+t1aKd?=
 =?us-ascii?Q?b0CuW/qrrIrDPSdOXjK2aqLlA7H98CZgEj5ot6IdpuZnX29OYgAeAmgqwViR?=
 =?us-ascii?Q?ET2hF7A2uNS9lkf3JnTMww7V2WIUSSbzzyBXvJFrOAHJT2ZLcC4339YF99De?=
 =?us-ascii?Q?4EQWXotoIVxRIVCTDH/l/WhAEwKxlstByXbyuZ19/Ez7azQgfZCg30266zLp?=
 =?us-ascii?Q?MWRWU+pwbEl2TjFbMrQZcQa9iavjJYE5vpFDxQ5SyhTLVpvG0bmoJAeE2UXR?=
 =?us-ascii?Q?4r/H+ey9CUqcSTW+cj8Ghp9BMzaX8GmgEqWcw7WebH2y+JSJ8gm7RJWxrW3c?=
 =?us-ascii?Q?Y/JQRaBM+2UntIpBum5uNWjkelzHzL3k9PnMcCiL7r5euuGieqvps+h8BdBc?=
 =?us-ascii?Q?Jp3EuYH2GayVKV/G7rqNi2m4FVxMxlvFO2VcL3+312YcV1m584xhjcAGoF4p?=
 =?us-ascii?Q?BtmaBku/XBpoguK4ZOQz77DiBwaWKl1QeQ3k25Va2bWwoQCu3YxxLHQX6rip?=
 =?us-ascii?Q?97MOXo+zYQc7XEXZy9MABhQDyNnX/i+DT7G8lz4Wbwm9hATKg91PNrVbuTQm?=
 =?us-ascii?Q?iboEQ2tMj+ha7CiDC9BnsNJybgyspZeuFLryLxOu6Cj6pz2U/fj0/OwZkQ5r?=
 =?us-ascii?Q?GQ7CNZu134kZ6WFshlC/D5pctsFkxEupJZ5TY/K3klL3B16NbBEh83F9weAA?=
 =?us-ascii?Q?jj50Uj0dgOcUWEN7LtCb+oNDdEOEI+S5U8/D5z9YpV3P9TfU04+SVjyV6ZRW?=
 =?us-ascii?Q?0SzM2Ydw//HZ/mAj9sU4pUReZPdhZBDtaz/dYYQ0LFOdKt+bdPRhk9XMk2/D?=
 =?us-ascii?Q?WKaMptUSSp4UXm58BRYfDpIY6pbL2YyfA1U+CoPZjUBRrQXFkSISzDTcjCEC?=
 =?us-ascii?Q?BcYsS12qH+2hNb1N2rrzNQAq7x7anEDn4w43k0/OIznEbzoYI9EJhnEFA9d2?=
 =?us-ascii?Q?NRccsrCgOwNNTtNSiLnLZaROaIuwHsLt5K9V5V0i1XAnC/Zt0avf3gTuSK3p?=
 =?us-ascii?Q?Z88tnqsRozXB7FCEvHlwBn+hHhB3DfXqwZCQ+UNjSxrHMxo3QlE3g480io4x?=
 =?us-ascii?Q?DsfE19+BSchaJ8wbp62gVokWzZTS80ivwwHlHb3GVthfBm4XFRS9zqHyKWl+?=
 =?us-ascii?Q?qQGq+Jwm7eIzluxmc77Ujj6YXcvBNx/rnOLdTNhzWc7J5Y3W6NvUlRRBPoxy?=
 =?us-ascii?Q?3NYV/zeqoY2La1tD2AkEHqdYUFCWaX7LDxkKXyKCThL0/ZyhhwTzGx7cpEyi?=
 =?us-ascii?Q?+U03Y3G/2EUUl7tkCc0gzWfmDwhuGvD7iNzH/0Td15OXige1LkIaHR5UIg26?=
 =?us-ascii?Q?FQBig0AQgWyNBUi8e1r2kF8ZlFz9oJpxCPnwyDNlFG6u+RNnY747Di+Mnvyl?=
 =?us-ascii?Q?5A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB1587.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f16e81a0-5e3d-49fb-3837-08dc3f964b9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 17:36:32.5504
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Gc6WWXUQNubB4HGZDdbTbPrjFUM8Qso2T9RKPXk5Punbsv+ivh0s3nsF9kvyFuCYo2abW4b4SWt8vb6fR5VW/Vsi8G/K2XJdNYizrdke4vo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB6167

Hi Prabhakar,

Thanks for the patch.

> -----Original Message-----
> From: Prabhakar <prabhakar.csengg@gmail.com>
> Sent: Friday, March 8, 2024 5:27 PM
> Subject: [PATCH 4/5] i2c: riic: Pass register offsets and chip details as=
 OF data
>=20
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>=20
> With an increasing number of SoCs reusing this driver, each with slight v=
ariations in the RIIC IP, it
> becomes necessary to support passing these details as OF data. This appro=
ach simplifies the extension
> of the driver for other SoCs.
>=20
> This patch lays the groundwork for adding support for the Renesas RZ/V2H =
SoC.
>=20
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  drivers/i2c/busses/i2c-riic.c | 59 ++++++++++++++++++++++++++---------
>  1 file changed, 44 insertions(+), 15 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.=
c index
> 49a12f1ecdf9..3398d639b754 100644
> --- a/drivers/i2c/busses/i2c-riic.c
> +++ b/drivers/i2c/busses/i2c-riic.c
> @@ -46,18 +46,6 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/reset.h>
>=20
> -#define RIIC_ICCR1	0x00
> -#define RIIC_ICCR2	0x04
> -#define RIIC_ICMR1	0x08
> -#define RIIC_ICMR3	0x10
> -#define RIIC_ICSER	0x18
> -#define RIIC_ICIER	0x1c
> -#define RIIC_ICSR2	0x24
> -#define RIIC_ICBRL	0x34
> -#define RIIC_ICBRH	0x38
> -#define RIIC_ICDRT	0x3c
> -#define RIIC_ICDRR	0x40
> -
>  #define ICCR1_ICE	0x80
>  #define ICCR1_IICRST	0x40
>  #define ICCR1_SOWP	0x10
> @@ -87,6 +75,13 @@
>=20
>  #define RIIC_INIT_MSG	-1
>=20
> +#define RIIC_RZ_A_TYPE	0

> +
> +struct riic_of_data {
> +	u8 family;

Do you need family as compatible have this information?

> +	u8 regs[];
> +};
> +
>  struct riic_dev {
>  	void __iomem *base;
>  	u8 *buf;
> @@ -94,6 +89,7 @@ struct riic_dev {
>  	int bytes_left;
>  	int err;
>  	int is_last;
> +	const struct riic_of_data *info;
>  	struct completion msg_done;
>  	struct i2c_adapter adapter;
>  	struct clk *clk;
> @@ -105,14 +101,28 @@ struct riic_irq_desc {
>  	char *name;
>  };
>=20
> +enum riic_reg_list {
> +	RIIC_ICCR1 =3D 0,
> +	RIIC_ICCR2,
> +	RIIC_ICMR1,
> +	RIIC_ICMR3,
> +	RIIC_ICSER,
> +	RIIC_ICIER,
> +	RIIC_ICSR2,
> +	RIIC_ICBRL,
> +	RIIC_ICBRH,
> +	RIIC_ICDRT,
> +	RIIC_ICDRR,
> +};
> +
>  static inline void riic_writeb_reg(u8 val, struct riic_dev *riic, u8 off=
set)  {
> -	writeb(val, riic->base + offset);
> +	writeb(val, riic->base + riic->info->regs[offset]);
>  }
>=20
>  static inline u8 riic_readb_reg(struct riic_dev *riic, u8 offset)  {
> -	return readb(riic->base + offset);
> +	return readb(riic->base + riic->info->regs[offset]);
>  }
>=20
>  static inline void riic_clear_set_bit(struct riic_dev *riic, u8 clear, u=
8 set, u8 reg) @@ -453,6
> +463,8 @@ static int riic_i2c_probe(struct platform_device *pdev)
>  		}
>  	}
>=20
> +	riic->info =3D of_device_get_match_data(&pdev->dev);
> +
>  	adap =3D &riic->adapter;
>  	i2c_set_adapdata(adap, riic);
>  	strscpy(adap->name, "Renesas RIIC adapter", sizeof(adap->name)); @@ -49=
7,8 +509,25 @@ static void
> riic_i2c_remove(struct platform_device *pdev)
>  	pm_runtime_disable(&pdev->dev);
>  }
>=20
> +static const struct riic_of_data riic_rz_a_info =3D {
> +	.family =3D RIIC_RZ_A_TYPE,
> +	.regs =3D {
> +		[RIIC_ICCR1] =3D 0x00,
> +		[RIIC_ICCR2] =3D 0x04,
> +		[RIIC_ICMR1] =3D 0x08,
> +		[RIIC_ICMR3] =3D 0x10,
> +		[RIIC_ICSER] =3D 0x18,
> +		[RIIC_ICIER] =3D 0x1c,
> +		[RIIC_ICSR2] =3D 0x24,
> +		[RIIC_ICBRL] =3D 0x34,
> +		[RIIC_ICBRH] =3D 0x38,
> +		[RIIC_ICDRT] =3D 0x3c,
> +		[RIIC_ICDRR] =3D 0x40,
> +	},
> +};
> +
>  static const struct of_device_id riic_i2c_dt_ids[] =3D {
> -	{ .compatible =3D "renesas,riic-rz", },
> +	{ .compatible =3D "renesas,riic-rz", .data =3D &riic_rz_a_info },
>  	{ /* Sentinel */ },
>  };
>=20
> --
> 2.34.1
>=20