Received-SPF: pass (google.com: domain of linux-kernel+bounces-97504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Michael Kelley <mhklinux@outlook.com>
To: Will Deacon <will@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "kernel-team@android.com" <kernel-team@android.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>, Christoph Hellwig
	<hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy
	<robin.murphy@arm.com>, Petr Tesarik <petr.tesarik1@huawei-partners.com>,
	Dexuan Cui <decui@microsoft.com>, Nicolin Chen <nicolinc@nvidia.com>
Subject: RE: [PATCH v6 0/6] Fix double allocation in swiotlb_alloc()
Thread-Topic: [PATCH v6 0/6] Fix double allocation in swiotlb_alloc()
Thread-Index: AQHacW1No1NKp7IpLU2beBr9mF1JxbEuM3Zg
Date: Fri, 8 Mar 2024 19:21:23 +0000
Message-ID:
 <SN6PR02MB4157A1A03F2F1EB5A006AF27D4272@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240308152829.25754-1-will@kernel.org>
In-Reply-To: <20240308152829.25754-1-will@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?s/SHTnRy90TtaSioQb+IWg/+/cF7cUqbYQ2EIxoxiuvcuhRNkbIBlRnRzq01?=
 =?us-ascii?Q?XWJIRKxUDUeiGRHXaXIOnEYTCBGlxFxburhcf60wpujk6Wx46RuS4ByOsY/b?=
 =?us-ascii?Q?iHWXAOMmbyA+uU8EXUQ4nPcxNX/otdfOlkR3jJGG23CbjYf0KH2s5gJlIpWJ?=
 =?us-ascii?Q?T58SGPNIFVpavDtvuIu7JZOOMBlI9jIBvALFRknVIDKEw6IyEMoCZB+uqJXU?=
 =?us-ascii?Q?Vn5uVy1axC4VX/4Dne/veYnr/y9stqjpq8fzzVSQRGiPsV5hRIYXPYpSOwVT?=
 =?us-ascii?Q?x2pnseeTnZRy8OO6LIqfU8hh4FT6lr6+LP8YNhXj30TwhG5/NVhzbJ0mdRW4?=
 =?us-ascii?Q?gX3lO1Q8XYDdddmMtyxu6+gEXZ2B2uOx3SDGJjb+6SJQG69rjPvxjBnGQSfu?=
 =?us-ascii?Q?yJaRCDeioMjSRhuVPJKv1ApOgGyanBR4RuKL4vyY1cH8zGs4CMxDFv/o14xY?=
 =?us-ascii?Q?m83yGjIH1ljq5Wn5eybVvIbycBvZpqQ7yGsTjRX7xhxNhVPT/G7k9DEklmEY?=
 =?us-ascii?Q?yHL65JHYU2legR6qVC/jsDZwank2KaX2bSs1kpIro2TX7luj5jk8LtFo5YiY?=
 =?us-ascii?Q?PcnaENbaDc4tVntTdJdI+fdyhHgjukC6Pb+oCv24hOCiyD10LI+MOMa4+eVK?=
 =?us-ascii?Q?j9g2UG+Fs/sJ9JMbrPfapD0lyFyKlwFpfvGSk5nX4bAOLlWx5h/vhonpC4F0?=
 =?us-ascii?Q?qTSL5n1JtbgA9wxnmjsAKtlKFD7b83axEz96wxsgsmNovz3xy7NWSBLEyjX1?=
 =?us-ascii?Q?MjL8H8iSUwe48euvmVUVZC9pQyviUsjroahCixk7allzX1o9ej96XLYuN3Gc?=
 =?us-ascii?Q?29OjXxzl4ET+ucFcosK5cqGx5epW5Q6gR9pquzbL4RSrKSEFRSi7MSBNdfp/?=
 =?us-ascii?Q?9K0bukGdg1d6ZmAhgQVvE/veyjUj2g4m2olxluVY3yBWoHiqfGQfQ+reRdKP?=
 =?us-ascii?Q?Dr2O0mfF9S4pwwNCQPvvInI/qjzkriM33bBSljL6LSSuGgVP4nelySdjaC0L?=
 =?us-ascii?Q?LZMlf5770FcHuecyZslLuYnGhbtV1VllMryqf3FELF6r/J7WnIqzEyx4sN38?=
 =?us-ascii?Q?k6heXbQ9l4TNSWtbQLAY5b4g1E78Q5Skq0Ks3H7EBXU2tZnqll9O4TSuS+cO?=
 =?us-ascii?Q?+HDDfl2PcpIgyVln43dJLM7zacErRyKbM9LojyW+qu/Sjj0N/B6ZP6OxT1JD?=
 =?us-ascii?Q?l6Ya7IYO/VAY/77S1Df8VvMqoO6CBxxmoYnavg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 19fecae1-0aae-4e7c-3a05-08dc3fa4f18c
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 19:21:23.9152
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10249

From: Will Deacon <will@kernel.org> Sent: Friday, March 8, 2024 7:28 AM
>=20

[snip]

>=20
> Changes since v5 include:
>=20
>   - Rework the final patch to preserve page-alignment for streaming
>     requests without a DMA alignment mask
>=20
>   - Added Reviewed-by tags from Michael
>=20
> Cheers,
>=20
> Will
>=20

I've tested the full v6 of this series on an ARM64 VM in the Azure
public cloud with 64K page size, and swiotlb=3Dforce on the kernel
boot line.  The path exercised is the DMA Direct path on a synthetic
SCSI disk device with min_align_mask =3D 0xFFF.  I have a standalone
user-space test program using writev() to generate direct disk
I/Os with a variety of memory buffer alignments and physically
contiguous extents.  It's designed to test the paths through the
iovec level, scatter/gather lists, and the driver DMA descriptors
to make sure all is working correctly.

Prior to this patch series, some tests were failing with 64K page
size when swiotlb=3Dforce, but they are all working now.

Tested-by: Michael Kelley <mhklinux@outlook.com>