Received-SPF: pass (google.com: domain of linux-kernel+bounces-97521-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com
Cc: rafael@kernel.org,
	lenb@kernel.org,
	linux-acpi@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 2/2] platform/x86: wmi: Avoid returning AE_OK upon unknown error
Date: Fri,  8 Mar 2024 20:50:27 +0100
Message-Id: <20240308195027.7640-2-W_Armin@gmx.de>
In-Reply-To: <20240308195027.7640-1-W_Armin@gmx.de>
References: <20240308195027.7640-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:lRGWUd8rbD0=;S3VNApLh4SSMB/cUCUVGpwJPrjz
 h5eQf1dROgx3oZVf/8xQGNV0k6XtXXV8FWFd3Yr8w/Yabdiq+jSg34WPPEAcF3m/Ib54+cEuc
 Ub6B9cV55OsaSP6Wp/i2S/NKv+q5M+B/vBTsjjcI6XTfvp5Rqhj3cP1m/XiiJMXrhgq6ddYLa
 E6mENN2PyYknmTtjnjr4k3YeIt4A/z8CZLD8gHqd5ySbE0N+zO6aeQksHNNaBs/EMJ6QuQSh4
 3cNvv+X1ESsA7HHAx+M1uJoMJ08QFaMlPSAgrmLeat/vIZa2rD/4zJy/s9haAVFtF+ELI4WBX
 vkqGcCGxTZF3e/XM7I7KFPSLGlSqW+jijtxVgcqR06Tca/8fHjVnZn5XkcnRMiXGXDjAmYduv
 QJUESLKDgAvMKj30UFfFdKkKRlRsgcJ28z1qz0SZETLh6gn3CFoiZ1Ash1Omk2vLVCOcZhkEb
 /yo/sxM6045buMO4JYG7Ji8N0Am5nuNa3vd+eop2c72trHw9aNXwV+L3xqisriVlgvP4KE5rL
 pooYk1gxvWpTS5LMzdtT8K4qHXzacdwBSGlWmhirbTGlU2gnURealpnC2OlRqK3qAhPUNOm6p
 EDPlKkIlf9/i527HYGkBL0SsBmRYLKF2/Yc4wfEoRr1FK9TvKlTY7w5yoAeCTTZJf7VFyiuFn
 9RmK8EIGeE21bprwRQ9jKLILWR+SjkFBdS8HrEBbY6J0H9n9cI3ytzPryx3fuVewI/rKKTXxv
 mezBTxKN2GhhztIlC7eY6NCig0P77htw1B13Wwf/WegziETdaPno2aj1CKr8cZaaV4dkgML5v
 hkK2awNic2ugRPZEztS3lOvevY3K+XmkYRPAKRbR2C+Dw=

If an error code other than EINVAL, ENODEV or ETIME is returned
by ec_read()/ec_write(), then AE_OK is wrongly returned.

Fix this by only returning AE_OK if the return code is 0, and
return AE_ERROR otherwise.

Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus.

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/wmi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index e6cab1cf611a..3f75220558aa 100644
=2D-- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1216,8 +1216,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physic=
al_address address,
 		return AE_NOT_FOUND;
 	case -ETIME:
 		return AE_TIME;
-	default:
+	case 0:
 		return AE_OK;
+	default:
+		return AE_ERROR;
 	}
 }

=2D-
2.39.2