Received-SPF: pass (google.com: domain of linux-kernel+bounces-97149-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Fri, 8 Mar 2024 16:15:08 +0200 (EET)
To: Richard Fitzgerald <rf@opensource.cirrus.com>
cc: broonie@kernel.org, tiwai@suse.com, Hans de Goede <hdegoede@redhat.com>, 
    lenb@kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>, 
    linux-sound@vger.kernel.org, alsa-devel@alsa-project.org, 
    LKML <linux-kernel@vger.kernel.org>, patches@opensource.cirrus.com, 
    platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, 
    Simon Trimmer <simont@opensource.cirrus.com>
Subject: Re: [PATCH 3/3] platform/x86: serial-multi-instantiate: Add support
 for CS35L54 and CS35L57
In-Reply-To: <20240308135900.603192-4-rf@opensource.cirrus.com>
Message-ID: <ea3c3230-cdf1-c41f-47fd-8b47667f7c5c@linux.intel.com>
References: <20240308135900.603192-1-rf@opensource.cirrus.com> <20240308135900.603192-4-rf@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-2054902426-1709907308=:9765"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-2054902426-1709907308=:9765
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Fri, 8 Mar 2024, Richard Fitzgerald wrote:

> From: Simon Trimmer <simont@opensource.cirrus.com>
>=20
> Add the ACPI HIDs and smi_node descriptions for the CS35L54 and CS35L57
> Boosted Smart Amplifiers.
>=20
> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
> This patch doesn't have any build dependencies on the ASOC/HDA code so
> can be take separately.

Acked-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

> ---
>  drivers/acpi/scan.c                           |  2 ++
>  .../platform/x86/serial-multi-instantiate.c   | 28 +++++++++++++++++++
>  2 files changed, 30 insertions(+)
>=20
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index e6ed1ba91e5c..091c501bed1f 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -1725,7 +1725,9 @@ static bool acpi_device_enumeration_by_parent(struc=
t acpi_device *device)
>  =09=09{"BSG1160", },
>  =09=09{"BSG2150", },
>  =09=09{"CSC3551", },
> +=09=09{"CSC3554", },
>  =09=09{"CSC3556", },
> +=09=09{"CSC3557", },
>  =09=09{"INT33FE", },
>  =09=09{"INT3515", },
>  =09=09/* Non-conforming _HID for Cirrus Logic already released */
> diff --git a/drivers/platform/x86/serial-multi-instantiate.c b/drivers/pl=
atform/x86/serial-multi-instantiate.c
> index 8158e3cf5d6d..97b9c6392230 100644
> --- a/drivers/platform/x86/serial-multi-instantiate.c
> +++ b/drivers/platform/x86/serial-multi-instantiate.c
> @@ -329,6 +329,19 @@ static const struct smi_node cs35l41_hda =3D {
>  =09.bus_type =3D SMI_AUTO_DETECT,
>  };
> =20
> +static const struct smi_node cs35l54_hda =3D {
> +=09.instances =3D {
> +=09=09{ "cs35l54-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l54-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l54-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l54-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09/* a 5th entry is an alias address, not a real device */
> +=09=09{ "cs35l54-hda_dummy_dev" },
> +=09=09{}
> +=09},
> +=09.bus_type =3D SMI_AUTO_DETECT,
> +};
> +
>  static const struct smi_node cs35l56_hda =3D {
>  =09.instances =3D {
>  =09=09{ "cs35l56-hda", IRQ_RESOURCE_AUTO, 0 },
> @@ -342,6 +355,19 @@ static const struct smi_node cs35l56_hda =3D {
>  =09.bus_type =3D SMI_AUTO_DETECT,
>  };
> =20
> +static const struct smi_node cs35l57_hda =3D {
> +=09.instances =3D {
> +=09=09{ "cs35l57-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l57-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l57-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09{ "cs35l57-hda", IRQ_RESOURCE_AUTO, 0 },
> +=09=09/* a 5th entry is an alias address, not a real device */
> +=09=09{ "cs35l57-hda_dummy_dev" },
> +=09=09{}
> +=09},
> +=09.bus_type =3D SMI_AUTO_DETECT,
> +};
> +
>  /*
>   * Note new device-ids must also be added to ignore_serial_bus_ids in
>   * drivers/acpi/scan.c: acpi_device_enumeration_by_parent().
> @@ -350,7 +376,9 @@ static const struct acpi_device_id smi_acpi_ids[] =3D=
 {
>  =09{ "BSG1160", (unsigned long)&bsg1160_data },
>  =09{ "BSG2150", (unsigned long)&bsg2150_data },
>  =09{ "CSC3551", (unsigned long)&cs35l41_hda },
> +=09{ "CSC3554", (unsigned long)&cs35l54_hda },
>  =09{ "CSC3556", (unsigned long)&cs35l56_hda },
> +=09{ "CSC3557", (unsigned long)&cs35l57_hda },
>  =09{ "INT3515", (unsigned long)&int3515_data },
>  =09/* Non-conforming _HID for Cirrus Logic already released */
>  =09{ "CLSA0100", (unsigned long)&cs35l41_hda },
>=20
--8323328-2054902426-1709907308=:9765--