From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] PM: Acquire device locks on suspend
Date: Sun, 6 Jan 2008 23:19:36 +0100
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: Greg KH <gregkh@suse.de>, Andrew Morton <akpm@linux-foundation.org>,
       Len Brown <lenb@kernel.org>, Ingo Molnar <mingo@elte.hu>,
       ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
       LKML <linux-kernel@vger.kernel.org>,
       pm list <linux-pm@lists.linux-foundation.org>
References: <Pine.LNX.4.44L0.0801061203510.7367-100000@netrider.rowland.org> <200801062005.12097.rjw@sisk.pl> <200801062057.01677.rjw@sisk.pl>
In-Reply-To: <200801062057.01677.rjw@sisk.pl>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801062319.37698.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1935
Lines: 57

On Sunday, 6 of January 2008, Rafael J. Wysocki wrote:
> On Sunday, 6 of January 2008, Rafael J. Wysocki wrote:
> > On Sunday, 6 of January 2008, Alan Stern wrote:
> > > On Sun, 6 Jan 2008, Rafael J. Wysocki wrote:
> > > 
> > > > > If you can figure out a way to disable the warning in device_del() for 
> > > > > just the one device being unregistered by 
> > > > > device_pm_destroy_suspended(),
> > > > 
> > > > Something like this, perhaps:
> > > > 
> > > > @@ -905,6 +915,18 @@ void device_del(struct device * dev)
> > > >  	struct device * parent = dev->parent;
> > > >  	struct class_interface *class_intf;
> > > >  
> > > > +	if (down_trylock(&dev->sem)) {
> > > > +		if (pm_sleep_lock()) {
> > > > +			dev_warn(dev, "Illegal %s during suspend\n",
> > > > +				__FUNCTION__);
> > > > +			dump_stack();
> > > > +		} else {
> > > > +			pm_sleep_unlock();
> > > > +		}
> > > > +	} else {
> > > > +		up(&dev->sem);
> > > > +	}
> > > > +
> > > >  	if (parent)
> > > >  		klist_del(&dev->knode_parent);
> > > >  	if (MAJOR(dev->devt))
> > > 
> > > Bizarre, but it should work.
> > 
> > OK
> > 
> > Still, shouldn't we fail the removal of the device apart from giving the
> > warning?
> 
> Actually, having thought about it a bit more, I don't see the point in
> preventing the removal of the device from the list in device_pm_remove() if
> we allow all of the operations in device_del() preceding it to be performed.
> 
> Shouldn't we just take pm_sleep_rwsem in device_del() upfront and block on that
> if locked?

Ugh, the $subject patch looks like a city of races.  I'm struggling to close
them all, but it's getting complicated.

I'll post the result in a new thread.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/