Received-SPF: pass (google.com: domain of linux-kernel+bounces-97568-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <346188f0-5f87-4ee7-971b-a6832dfbd5eb@intel.com>
Date: Fri, 8 Mar 2024 12:46:10 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/7] vfio: Introduce interface to flush virqfd inject
 workqueue
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <kvm@vger.kernel.org>, <eric.auger@redhat.com>, <clg@redhat.com>,
	<linux-kernel@vger.kernel.org>, <kevin.tian@intel.com>
References: <20240306211445.1856768-1-alex.williamson@redhat.com>
 <20240306211445.1856768-4-alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240306211445.1856768-4-alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmJJalpQS1M5dW84aTZvdHNQZ2dhMjh1S2VMTlA2WDlMczMrZGk0MHNRV0Q0?=
 =?utf-8?B?MEVKK2JqQzVSRzFCQjhjNTByQTQya085aHRpcndXZVl3bWs5K1NXUjBaR0F6?=
 =?utf-8?B?RkpsYy9VN0tXMmxlTUU4KzE4NnFheXhFdzNXem51TzVzTWhHSVpnc2hOUnFl?=
 =?utf-8?B?SVRTTGNNOHp3YVdxZG5DSklmQkZLR3pQcXlnL2JMcWtURzJVM2s1NUFYOGNE?=
 =?utf-8?B?UC8zdm9rdVlNbTZtYUNiLzVESENtcEoxUnNGSEpUVnkyeTk0RndIWERLcHgz?=
 =?utf-8?B?ajh6ZjREc1l0VkZxTVNuN0RNdjlzVXM0U3JOSzVGSlVWL0ZKVmFwT3ErYWtD?=
 =?utf-8?B?OG5Nb1FlTGp2YTVJRUNzbGQybzBDSW5yeVVEdlpvVkFMSGhEZmtibHVvaVlY?=
 =?utf-8?B?Y09uV3NwMG5BN2hpTjBVOFdFWEtLWmZscks3NnZQaW95MG5BQ285NW9acGs4?=
 =?utf-8?B?a1RieHlTc1k5QncxSmZQMEsrYmsxNnM5aTcyTHpqRkI2K0JRditGUklMSVYv?=
 =?utf-8?B?djk2dXpsV000OXRqQzBBeGlVRTMyTU55R1NJN0hBMlVmb2wraFArSmptYUEz?=
 =?utf-8?B?NWJiVG5BWVRqekNsTk1hcFpTWm9HSGFDQURtOWpXQnYxRzBnQUhNTEJRWjF4?=
 =?utf-8?B?UDZmUUVUeFlOV2VCbEc4ZWJBWFNHK2FadWFxM1JXbVRXTVVodXY1UGpJTkNW?=
 =?utf-8?B?WldVdzdJeDFiQktud2pGMjMwRUt4OFZYZG5WVzZqVkJQYmtGVk45eGVuV3BU?=
 =?utf-8?B?TThhUzlYb0JEZ0tBV2s2K0JhZkl4YVRwalFPOXBnSWVLbS9DdU90SWhkbXhj?=
 =?utf-8?B?Z3pvMGZMZ3RNdEVvVWxHY1F5RllYbUVnTzNjVm5NUzhGMkRBdFlSYjhDdDZV?=
 =?utf-8?B?VEdKSDhsUVVrTEZMQjNvRzFGS1JNU0pKQ1oveHBOYUZIcWpoWTY3YytOeTN3?=
 =?utf-8?B?Y1RCb1NQYVJzQUt1a01zNVM2RGowN21laXpLQ0sycnNNUUpxMWtiTkpSSWNR?=
 =?utf-8?B?WXBrOTE5bWJsRldpMDU0UlBkZ2wybGRlb1BIc1Z4dUZsbWFzZ1RCU1pEZ0Qz?=
 =?utf-8?B?eEN3TFp1Unc1ZEtQZy90RnBWaEN1SlQ1UHY1bE13dUZYck5PZ1FsaXRIeEpH?=
 =?utf-8?B?bmdrbGtpMk41a2Z2WnNoWi9aNS81ODgvZld5NkF0ZmpLWENhUXRWNlIrYUJw?=
 =?utf-8?B?cStGTWxMVHJWdTkyVWFDV0dWQjhoK3h2UjJDMFhoQkorVm40aVpoNnV6TmN1?=
 =?utf-8?B?ZnUwcDJ2NG1qMEpSd2p1NGRnRE8xZml5eDdLZE9GdVVCWTBJMWZaVms0M2g3?=
 =?utf-8?B?eHVsb0VhRnl6dHRMcUVBK1g3TnhiQmFES0JPWnZqa0tEYlRQTDFKUm5mWFY0?=
 =?utf-8?B?RlRPNG00UHNHWEpROU1jZWYxTE5lekRPdVBkSStPa3EyU1NoMDZQKzFZWXps?=
 =?utf-8?B?MXJVQ282MmJEMEpJblhpaDZNRlZvWi9mTXFocHUzZmplWEc1VUNmUlNhdUcz?=
 =?utf-8?B?MC9mR083WU42YjFHbUhCeXVUbmdWVUpSTFlZRSszalhPeHQyR2lqcUxMUG1E?=
 =?utf-8?B?Q2hPSi9uZUdiTHFPWTVHQWpkY3F0clllejdmMnlBSUVOcDE5S0RIWnp0QnIx?=
 =?utf-8?B?R0NaemZrSWNQQW16bkZGOE9sUzNYSmdoQk5ja0NOcG9TWXFFaXBUM25kSkNQ?=
 =?utf-8?B?Q21UOXA4RFNMd05Tb3pFcWVTWTF2U0N5MmVTdGVyL1psK0UzYXRwRkdUMFk0?=
 =?utf-8?B?R0FuejBjTFJZVGZPWFpqSUI1ZjlyTUV0ZnZjMk5yazlZTURPK25BSUFvM1k2?=
 =?utf-8?B?RjlQOFB6YmZmTXVJZDhaU3FhbW9QV05sNDROemVHUkx1bDlOdUd6bDR2OU5X?=
 =?utf-8?B?Qk1vYU93SXpGUmNtQXUxSklDbXozSGozcE5RVGd5K3g5OGlIRG5UdFIrbm10?=
 =?utf-8?B?RnpLWUNoYkprV1JhR2FTRmlTaHBrUE5lcHNVaEVhbFpWOVdTNGZ5dW1URWt4?=
 =?utf-8?B?bkloRkVMWnZrTjdFV3BvMDRoSWp4MUhoQ3Vqb21UOUxpcjZ1NUJqUW1aYWN1?=
 =?utf-8?B?dVJuRzZMb1o3c3F1YzVsQi80MzB6bHk3dzRPcS8wWFladCtaMWEwREE5emRG?=
 =?utf-8?B?SW1TRWJYZE1CZTJzOUtzNXlVeFVucDVqWUI5eU1GUDdoUUU2emVlVmJnNGRU?=
 =?utf-8?B?K1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d875efbc-5bdd-4763-9841-08dc3fb0c9bb
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 20:46:11.2362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kaZO565ifcHY/90WlUkJJkynJbC42vU6MpY2JDkIZtC8S+XUCRxfHS3f1NcHBokYUZWo6lVpW0L1F1VGQ6dNwqovMu/KOkXhcc9mliXkM4s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6491
X-OriginatorOrg: intel.com

Hi Alex,

On 3/6/2024 1:14 PM, Alex Williamson wrote:
> In order to synchronize changes that can affect the thread callback,
> introduce an interface to force a flush of the inject workqueue.  The
> irqfd pointer is only valid under spinlock, but the workqueue cannot
> be flushed under spinlock.  Therefore the flush work for the irqfd is
> queued under spinlock.  The vfio_irqfd_cleanup_wq workqueue is re-used
> for queuing this work such that flushing the workqueue is also ordered
> relative to shutdown.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette