Received-SPF: pass (google.com: domain of linux-kernel+bounces-97569-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b57b6a87-9805-4643-a56c-e866c8a5b1b5@intel.com>
Date: Fri, 8 Mar 2024 12:46:18 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 4/7] vfio/pci: Create persistent INTx handler
Content-Language: en-US
To: Alex Williamson <alex.williamson@redhat.com>
CC: <kvm@vger.kernel.org>, <eric.auger@redhat.com>, <clg@redhat.com>,
	<linux-kernel@vger.kernel.org>, <kevin.tian@intel.com>
References: <20240306211445.1856768-1-alex.williamson@redhat.com>
 <20240306211445.1856768-5-alex.williamson@redhat.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240306211445.1856768-5-alex.williamson@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDBRSFlUWmVzV0YrdlhsT0hzc1ZEUWJCVTRMOXVPajR2eEYrRy9SM0VQaHpT?=
 =?utf-8?B?ZUk3ZGJoL29mNCtIbFB4Y1pWRmFBZDdNamYwbDBuUUpFbFVvTFJXMkc3bDhD?=
 =?utf-8?B?ZXlVaEtlVmVBS0F1WmxxUU5wSm44bENxb1Y3ZDJPYmN3NTgwNVJ6d2NZOXRL?=
 =?utf-8?B?YWUxQ29GTjkxa29vOXMvb0tMZkl0OVYzMEt6cUhhdUpObSt0Y0E0Nkk5enZB?=
 =?utf-8?B?aldBUWthbnhtTU11TmxzeFcrS2RiQlpGUTVRWldPbTVWN3psREl4ZTk2K2dz?=
 =?utf-8?B?ZXlvandyajFWSXY0S095bHhDbFRFdVpqQUVnRGNGZ3E5dlFtekxpSjk5dktZ?=
 =?utf-8?B?bThWQ3pHT2FrUFhpTXRKSi9vbHBjRmNXUU9Yd0FUWkR5ZHMvWHpIMnFkYU5a?=
 =?utf-8?B?VHNCRTduVVU5OVg3WGZaVE5hWVJabzlNcjNMbVByYS9jSlhqM2thcXM5a3NZ?=
 =?utf-8?B?UEdLYzMyTVNBMGYxQndGeEU0VFM1eXd5M1hDT3REa2VrVUk4MkxTTjZQMGxr?=
 =?utf-8?B?K3VSSVMvRHdZRmZIemFGVWtEYWY4aUNqa2o4TVRxRmtKZXdiQ1hCMGpmZ0I0?=
 =?utf-8?B?dDRBdEgvbWdVNFMwbm9NeUtXSzhWTFlsSXArU0JibjRwdmFPVWpsWHFZYkN5?=
 =?utf-8?B?dm1oZnVhWm5RNmw0NHZEcTZYVHFSTy9oQ1o5QSswazg1TmJGbkEvQTdrNysw?=
 =?utf-8?B?K0JucjZCcU9FVFcvb1BhMXhDZTIwczhDMW1nWHJ5VFNxQXcwMjJoSXNmMjlY?=
 =?utf-8?B?S2dsaEk4ZUpJeHlvaGxjNkV5TCs4cysrMmJFQ0JVMW5PR3pvN0JzdjFlNUpw?=
 =?utf-8?B?cU55WDYrTHBvVnFReGwzaDJKZVA2V2dkSDB0WC96UndnMWY2QzlscVczMzJ1?=
 =?utf-8?B?eGZYaWlkRWMrV2tVS1NHbUtGMkdJN1VnalpBR3htb2dnUzYxZXJRTTlUU2xB?=
 =?utf-8?B?S3B6eW9YTWxucG4yWWF5dUp3WXpNSFFEMjlFc1ZLUXlOS2dObGFsYkhtRjU5?=
 =?utf-8?B?Smh3Q3B2RThaR0tZemg5QzNRSDQ2WUdmSjRleXJ1RUFJZFNEZGpKT1NIc2FR?=
 =?utf-8?B?dHpJZS9wUG1SVXpWMmlxRjVlK3ZTaXhrUlFEd1BQUmZZUUVhTmV6NFYyMnNX?=
 =?utf-8?B?bmhRbXVUVDFqendSVWlhdFViMVZsTlYwNnk2MDdoVFpGNGxzUThhc2hyMXlY?=
 =?utf-8?B?N0lVUjJiVEo2KzRjbEtqS1RNVk56ek05TWxpQjd6cGtaRFV1eEJqV3gxeEs0?=
 =?utf-8?B?czZKREdBS2xPdy9oMGo2WDBXNk5vK0syZ094UUMzT3kxdVJXTjBFYlVnWHJu?=
 =?utf-8?B?b1pxMjVMNWtEdFpJdVAraVRQV01UUW1ZUEtreTNyaTVZMFUrZmtZU1R5Mmla?=
 =?utf-8?B?SDR3TmFCYUc5OFg1SE9nRHVqalZVb3BLbm9hMXFJVWZ2dTV0Y2lldHhDazhB?=
 =?utf-8?B?UHF3NkwwRmdBR3FuZ3B5RE14SVRhbmFZeXNOWGJVRWZ1d1pCQ0x3SmxabjN0?=
 =?utf-8?B?L01LSnBFZzMzSHVaT3JyU0ZyZ2pJOGM4ZkM0a3A4eENNVFg5TTRzalVOTkNR?=
 =?utf-8?B?YXV5QUtQdXpKLzkrN1FKWFgwcnZtckxBRmdlS09STmJVK3RNWG9OY1RMSnNy?=
 =?utf-8?B?Y3FEZ3E0NmtTbk55WHgyNlFJd3VlbjhFbFp2MDZaelBaNmRtZnV2aXJUbkRy?=
 =?utf-8?B?MGhiL29MdjVqd2dvdStJS2tZNUw5dmY0WC9SU0ZHS0EvbDFqNlhoSHp0ZkFD?=
 =?utf-8?B?VVdmOEZDZHdmY0lRLzQ2eVA0QVB0eDE2WFNMMEFMN1p5bFhuTnJLYUxqMml5?=
 =?utf-8?B?NFNxdjRjT0NlMTNNUEVJQ0dSOGVtbUdvYzNXUktDeWRodmhCQUIrc0d5ZWk1?=
 =?utf-8?B?U0V5Zkg1MXZla1lsSDRVTWh4dkxnclVvNFlkK1daSEhobC8yU2w1cWFObXVF?=
 =?utf-8?B?OHhrdTh4MVJhWjJCOXlCN0llbDNlZHJwbjJtcXlTRzUyK0VkbW5kWnFpZGdM?=
 =?utf-8?B?eEhtQ3pmcjZ0Yk8xOGdPL1F1S3FVWk5uOUJQQ3NIZVF2SjZLL1Q1NDZZSnZS?=
 =?utf-8?B?WFhzTGVSbExqUEl1SFVjWmhvVmQ4QjhkaGFIOW4zUTJNaHlpd2xiRmh5QkZw?=
 =?utf-8?B?bEpMTTlFMDZSR1p5RkVnWTQzTkNKQ0RGaDRFcDMzTGV6azlDVmpLdmJ1Y3dK?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e61eab70-17a2-4329-09c0-08dc3fb0ce6b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 20:46:19.0703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 91dGBwKRJaba3XfgohUmTdSK3RUrcy5DqJYfQ6BMEzIYg+JXUKKUwXMOgbQ8fQww3SCFbhCUXl/7Y+MuQR2574JiUYHZnJQkPXMR3E00nMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6491
X-OriginatorOrg: intel.com

Hi Alex,

On 3/6/2024 1:14 PM, Alex Williamson wrote:
> A vulnerability exists where the eventfd for INTx signaling can be
> deconfigured, which unregisters the IRQ handler but still allows
> eventfds to be signaled with a NULL context through the SET_IRQS ioctl
> or through unmask irqfd if the device interrupt is pending.
> 
> Ideally this could be solved with some additional locking; the igate
> mutex serializes the ioctl and config space accesses, and the interrupt
> handler is unregistered relative to the trigger, but the irqfd path
> runs asynchronous to those.  The igate mutex cannot be acquired from the
> atomic context of the eventfd wake function.  Disabling the irqfd
> relative to the eventfd registration is potentially incompatible with
> existing userspace.
> 
> As a result, the solution implemented here moves configuration of the
> INTx interrupt handler to track the lifetime of the INTx context object
> and irq_type configuration, rather than registration of a particular
> trigger eventfd.  Synchronization is added between the ioctl path and
> eventfd_signal() wrapper such that the eventfd trigger can be
> dynamically updated relative to in-flight interrupts or irqfd callbacks.
> 
> Fixes: 89e1f7d4c66d ("vfio: Add PCI device driver")
> Reported-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---

Thank you very much.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette