Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp873230lqc; Fri, 8 Mar 2024 14:32:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXdj+ryPk/VMZnL1RrbGSkHcsatUgYybBc/vG8++ojXxysPdp9Y1qfuRJuqoJGNUTX6jFmXSJIUPPc1e1WrsfwAZACWF9ZFjGPc+c4rYg== X-Google-Smtp-Source: AGHT+IGvdI3+zEvHqUD4LhEolFYhwpyc2INsH1+hdp/Tpm4ZOO/XjPi1ooqXjZQMkKaKuQf2q2VM X-Received: by 2002:a17:902:d4d1:b0:1dd:6a2d:e5c8 with SMTP id o17-20020a170902d4d100b001dd6a2de5c8mr32155plg.55.1709937155055; Fri, 08 Mar 2024 14:32:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709937155; cv=pass; d=google.com; s=arc-20160816; b=t+kqLt+WMah1jZFu7B2udrw4gI8WjkTjyYoffKm9JYiETqNRKAnMQJ/hcpKy6I92uy wC2GFB+QtgDskZE1VpL+8QHnNu/IhSlfBzCc+923GzgF5RZmtL/0ryYZS68c7YVHgwBQ 2NSSXXW/RXlm51Io2d0L3OfE5N445PEZd/ngVi6y0tmYEqz1zJDIRXvzLIbtB5EzOVBr TT0q4KPeMe/+ReDKJo2Tv1ng5ZUqfc+KwmUbJ/mYdNmh6gEg31dBL8Mry61n0sqJM4uW U6lDWSY1NYd2BeHZOIALBc7kKWlrZlZqJQpD9ubxiGmf7UJ+kt46fBGg9RzBoENbsn5t l09g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=pwOes60SqhGmD6fZ45p3rXPhDx2zuEPddRLFEizjnLQ=; fh=eJTJjt0vbx4M0Lh0ofbghe3hIDGCc0JLccg4VKdJ/8w=; b=tAUJzXuyVPgW5dVxL1go1RzccDV9OxcIo0OWw0nIxc4x4AoEuoBc7dKu5NRIHrhtEc GvhHWFGT+a2EWmkIsIuwdvCkxKN1ctQDuHnxqQYx8zaL3LdFiz9pO7KXtzRndYmKyQu4 Rz8+fsFEJ6H3KJoceA2B0dHfqP5nX3wMAcRocEKBFMBFSg8B/lPPar7SCbjE20KbKIv2 T6vat94eBGb6Cz+kdVlzTN8il/WRUbjsq15+E6ZEYi/ZDDmh7/B416fswVAITIowfqG8 cjiRaAAKAgxl3zPQsrf2hH+SqYneAraqW53lavsuISQuVP9h/LhsBLe5uGw/PadQnAQ9 XruA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-97654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t9-20020a1709028c8900b001dcd2ed9cb4si250089plo.544.2024.03.08.14.32.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 14:32:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-97654-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97654-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B8505281962 for ; Fri, 8 Mar 2024 22:32:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39DA13A1C4; Fri, 8 Mar 2024 22:32:15 +0000 (UTC) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 718191DA4D; Fri, 8 Mar 2024 22:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709937134; cv=none; b=bF5gGV/5DFraMEZ0YO/PIYVvsqd68bT2lgQBgd/90nv2wXj8tZmOJRu9U0dhnXDvFYwEYPo/W68pvjUp/iujDvEs8f+UAm4rmYxiQ8Wflrsxe9sKF27mTKj7w8O6nB1UMhZ/6rfiD084wZWQC4EQPXAFxpo63Pn/Hz4yey0R4hE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709937134; c=relaxed/simple; bh=ssGP/sKIDd40DWkEnGb8v8pNLmQIx5G0esCNsJrdJlQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tWcg3MOc4emhGcXxu4CMEa2X8uaVsQQ1rFpfUDVi9yyy+LLOa9wN0fUc4KT1LU3KFv7nqj7s+CrlOWlQ7q9bogKW9jG0AyAbjqeVWBmskOr+PMxBRjyd659bIIAoHlls9olsUUXGijRIyQekb+Y+vJKdraCANXEYWqHpn3sKmRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso2092124a12.2; Fri, 08 Mar 2024 14:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709937133; x=1710541933; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pwOes60SqhGmD6fZ45p3rXPhDx2zuEPddRLFEizjnLQ=; b=DRopFoS1ac+Hb2qnqDZD7eBGb/IBPg3DW8nk3bZS5XB2X3alW9vhVD8OuQa/8qYYbM SYnBcuR2+ne0QcBXub4jO03NhZRnuxeuCLInT8f61w/K9pBbYDMHwhgAKvLlHcsGydf3 /UUJs/JtcL7dltlv6KI+rAap/t7dhOlvLF+oCl05/ziX0z62CNsBf+2QnHORmNu7TfJm MLV/s5FXTZUy8yulUSZWxm8EqSXG1Eo3n1hrwGpxyWm8ANNjzhEcrgFasZb8/hFZ2M3x Q8iGED+aL1P6czui0WG8X+J0HCqc3GmXpfEEbw1p8aqqLC4eSCwZelo9YN/fys855bPA iCxQ== X-Forwarded-Encrypted: i=1; AJvYcCWwMdwT4ul3ewIWVcOoXfpzRAsIKJD+jC+9OnT4CeBeTy/801U+gkGQi9H4WcushNbG9AWz0fT9C5DcH/v/D+4Ydc9+MRmQ5CkaJ6WWyun4HawWnJZnE2fBSwcnNwwUlcTySpUU2fot1g== X-Gm-Message-State: AOJu0Yy38FkXklME2ozaO5QBU0yWBCCfDt0unA3QmyNVsGG4L/S46h+v npwiUzQwEyjj/70KM4LcOSZwSN9VLZL31S1mrcZqz5NdODx78VKG X-Received: by 2002:a05:6a20:daa4:b0:1a0:eea4:c612 with SMTP id iy36-20020a056a20daa400b001a0eea4c612mr70027pzb.11.1709937132754; Fri, 08 Mar 2024 14:32:12 -0800 (PST) Received: from ?IPV6:2601:647:4d7e:54f3:667:4981:ffa1:7be1? ([2601:647:4d7e:54f3:667:4981:ffa1:7be1]) by smtp.gmail.com with ESMTPSA id f49-20020a056a000b3100b006e4dad633e1sm191350pfu.177.2024.03.08.14.32.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 14:32:12 -0800 (PST) Message-ID: Date: Fri, 8 Mar 2024 14:32:11 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] scsi: ufs: Re-use compose_devman_upiu Content-Language: en-US To: Avri Altman , Bean Huo , "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bean Huo , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240305210051.10847-1-avri.altman@wdc.com> <20240305210051.10847-5-avri.altman@wdc.com> <6826cdb060609f81c970fc21b2050535f7c5a810.camel@gmail.com> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/7/24 11:26, Avri Altman wrote: > On Tue, 2024-03-05 at 23:00 +0200, Avri Altman wrote: >> Why not directly pass UTP_CMD_TYPE_SCSI or UTP_CMD_TYPE_DEV_MANAGE >> instead of using below ?: logic? > > Thanks. Will do that. While making that change, please keep the version check inside ufshcd_prepare_req_desc_hdr(). Thanks, Bart.