Received-SPF: pass (google.com: domain of linux-kernel+bounces-97693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: "Wu, Wentong" <wentong.wu@intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>, Sakari Ailus
	<sakari.ailus@linux.intel.com>
CC: "Winkler, Tomas" <tomas.winkler@intel.com>, "mchehab@kernel.org"
	<mchehab@kernel.org>, "hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: v6.8.0-rc6: mei_ace_probe / mei_vsc_probe: do not call blocking
 ops when !TASK_RUNNING
Thread-Topic: v6.8.0-rc6: mei_ace_probe / mei_vsc_probe: do not call blocking
 ops when !TASK_RUNNING
Thread-Index: AQHaam3EvCzE5l33CkGR0g/9d0yezrEgGjAAgADQ1wCAAAJ5gIAAnU4AgA0EQNA=
Date: Fri, 8 Mar 2024 23:45:44 +0000
Message-ID: <MW5PR11MB5787E3A96C8EFF3C9F8BC8908D272@MW5PR11MB5787.namprd11.prod.outlook.com>
References: <Zd9wUv1zSJ59WS8i@shine.dominikbrodowski.net>
 <Zd-BVmoFOiCxA632@kekkonen.localdomain>
 <ZeAwhhW7DSEazs0F@shine.dominikbrodowski.net>
 <ZeAymVVsI-CNj6Pc@kekkonen.localdomain>
 <ZeC2jss4IAM4aPWy@shine.dominikbrodowski.net>
In-Reply-To: <ZeC2jss4IAM4aPWy@shine.dominikbrodowski.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2MZVZ7XXftB2Cm1WQ8AX8tYmWoyHmkeC9VIdr0muwLCdplQNb1CEn+Y7wkab?=
 =?us-ascii?Q?pr9rdIK1S6LZkSRGgCaUOMZ35Q3wv3vXnxdBWg7A4Fg7BKyiYFi0PeKaXJfS?=
 =?us-ascii?Q?kUxPndO3MaLtJ0mIOTtbiJUahcTZaPuR555pRCFSVo3Fvttc1JEiG/fPbUnH?=
 =?us-ascii?Q?DknnWw5jc1lk0N+TZ/3K05o7DudEsczoL7msONDSmHwZKDjA/ziEA/wlOGNp?=
 =?us-ascii?Q?rv9jEGMl/rcym5XzKfx+fmVAoLsetSjT/ib3cHpdPrY5ac5H26evUTt+s4lj?=
 =?us-ascii?Q?vJvue3GcjglbeDoOmTKWLxLzBCu1wD/zdL+QRQGx6p+/K8mlg2gWlgYaUseh?=
 =?us-ascii?Q?tqOIlp6tXn/TTZ407JgcNwLkMzmTB+Bw8Z510bgDY85NQf2G3U/FgSWsRbED?=
 =?us-ascii?Q?160X4+2a2X1pLTnkOZbbd6mv0uxf59XYRNywLXiBj3troRvoD0kCRUMfRV4Z?=
 =?us-ascii?Q?ObRw2QPicKwmgfKNZR9CNXH8GW4GfxSHPcrUBHXiiRMLUiVUMXDwE0Y/h5p0?=
 =?us-ascii?Q?h+T0Z5fVKDwDYevcs/AGifzR/em2dbw3X4qpMviHdXuWbvhwra2nkUw4p5ni?=
 =?us-ascii?Q?dIZwyuRI4fY4y+O04r8C9QPdr6CnPmKt1+Tg52LRjQPsXgCMnqpwVqOSn12N?=
 =?us-ascii?Q?TzCSvWCb5RVgqh/3qjpfbrZmunS3TSaX+wv6CL3dsbHOdDzlLBHqGA5bm1/l?=
 =?us-ascii?Q?8ugXF/DaVTB7ZaDyPlT4fu6j2wrwZrm43tFEipRn/3h91mPSv4Q8g4vwZ/2N?=
 =?us-ascii?Q?Yiy303++mhqJvjmIv9Rrrr+q4uEwCzE7+4+zmIv5owoY66xkNrhtkkTdVSy2?=
 =?us-ascii?Q?cW9Hl5jEu/E9dv2TeaSBskvVYVTx3QWNc/gkPFsE41LhZGIXNDEI5sZZDWe6?=
 =?us-ascii?Q?EayWS+ojd7IJ4rPV/9z6lhcUjw65myJeFyp8RniXzSWifd4cp1bqyWcz813h?=
 =?us-ascii?Q?2iCDKaO0Cl3KjtAhmvUHruyLFrnK9OzHbQ1i6St70PuoP8Oe0GENsYh0upfZ?=
 =?us-ascii?Q?q0gRLPY8DIbiOvlgXAPrGSPzB9DqdGDvEHPI4nlOv6db3LAa1wcVzE9DQNQs?=
 =?us-ascii?Q?WG6Nv3arC47JpMmhAMWfHnlO8K8foAJRLWwlDDufi0uwGBbPX8JYgtKqrCQm?=
 =?us-ascii?Q?mFOPDU/hklWM4Kxnnu90jkwZaLjSpvr8af8a1iX6JT9aYDrG1cqFgey1ZbUG?=
 =?us-ascii?Q?TQ9sZjZGga+B8tGR805jQeNlDFBBrQH1mLY2ipTGBFyZZIKUh7210ACjkTdx?=
 =?us-ascii?Q?pmLPgqVUNKNGZPgIA15IjE6nMm5C2LtaR+JdvvKcNbggShickbC25jiDJpYS?=
 =?us-ascii?Q?HKtBo2q7Y1FIq/hi7h+qhG1YpNiXcW5m0jqgjmLVu1AOpanUemVK/ddCPP4Y?=
 =?us-ascii?Q?1IRlmXFqRKKjctOH8HsCSnnkjg44THhu9lmuD6m8sTX+llqKxOI18FtQX5vb?=
 =?us-ascii?Q?4QoKm58vrPEx2iWnejeDEsxXntZNfHdBcqVAyh6t8P5EdLT0EwirLB+dpB3P?=
 =?us-ascii?Q?jP2/nbcm5uDBR3av+YMiEEd+UfXxmEDhZeVrTagjRmZQ9oC1iQ87CQhoth+4?=
 =?us-ascii?Q?Kql8PnCRVY+GopGbcARMtKmM/kFQKYC1/EtYKNlx?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5787.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0dfb7b0-87a5-498d-7dfe-08dc3fc9def2
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2024 23:45:44.1117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XffrMsfEPimLAYeXIfzFuGPLOInoQr56pbHG1oGJ49ANUTuVGjBai+/gqcd6NIge7rmlrpsBFYhcp5FkZUp2jw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7285
X-OriginatorOrg: intel.com

Hi Dominik,

Did you try master branch (v6.8) without IPU6 driver? There
should be problems with the IPU6 driver you use as below:

> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras

If not, could you please help try it on your side? Thanks a lot

BR,
Wentong
> From: Dominik Brodowski <linux@dominikbrodowski.net>
>=20
> Hi Sakari,
>=20
> Am Thu, Feb 29, 2024 at 07:30:33AM +0000 schrieb Sakari Ailus:
> > On Thu, Feb 29, 2024 at 08:21:42AM +0100, Dominik Brodowski wrote:
> > > Hi Sakari,
> > >
> > > many thanks, this patch helps. Another issue persists, though:
> > >
> > >
> > > $ dmesg | cut -c16- | grep -E "(mei|vsc)"
> > > mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp
> > > 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound
> > > 0000:00:02.0 (ops i915_hdcp_ops) mei_pxp
> > > 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1: bound
> > > 0000:00:02.0 (ops i915_pxp_tee_component_ops) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2 mei
> > > intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da: deferred probe
> > > pending: (reason unknown) mei
> > > intel_vsc-5db76cf6-0a68-4ed6-9b78-0361635e2447: deferred probe
> > > pending: (reason unknown)
> >
> > You'll probably need the IPU bridge patches from that branch, too. Or
> > you can try removing the intel-ipu6 driver and modprobing it again.
>=20
> Everything is built into the kernel here - and the kernel I run is pure
> upstream (plus your patch), therefore no intel-ipu6 driver is available
> (yet) or active.
>=20
> > > During suspend entry (s2idle), the following messages are emitted:
> > >
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2
> > > PM: Some devices failed to suspend, or early wake event detected
> > > ACPI Warning: \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments -
> > > Caller passed 0, method requires 1 (20230628/nsarguments-232)
> > > intel_vsc intel_vsc: silicon stepping version is 0:2 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 vsc-tp
> > > spi-INTC1094:00: wakeup firmware failed ret: -110 intel_vsc
> > > intel_vsc: wait fw ready failed: -110 intel_vsc intel_vsc: hw_start
> > > failed ret =3D -110 fw status =3D intel_vsc intel_vsc: unexpected res=
et:
> > > dev_state =3D RESETTING fw status =3D ACPI Warning:
> > > \_SB.PC00.SPI1.SPFD.CVFD.SID: Insufficient arguments - Caller passed
> > > 0, method requires 1 (20230628/nsarguments-232) intel_vsc intel_vsc:
> > > silicon stepping version is 0:2
> >
> > I haven't tried suspending. Is this while streaming or not?
>=20
> No streaming - in fact, without intel-ipu6 available (upstream + your pat=
ch,
> see above).
>=20
>=20
> I have now tried upstream plus the ipu6 branch; there I get one message
> indicating that something is amiss:
>=20
> 	vsc-tp spi-INTC1094:00: wakeup firmware failed ret: -110
>=20
> And if I try to do a suspend&resume cycle, the machine hangs. A longer
> snippet from dmesg from upstream+ipu6 branch:
>=20
> mei_me 0000:00:16.0: enabling device (0000 -> 0002) mei_hdcp 0000:00:16.0=
-
> b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops
> i915_hdcp_ops) mei_pxp 0000:00:16.0-fbf6fcf1-96cf-4e2e-a6a6-
> 1bab8cbe36b1: bound 0000:00:02.0 (ops i915_pxp_tee_component_ops)
> intel-ipu6 0000:00:05.0: enabling device (0000 -> 0002)
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 intel_vsc intel_vsc: silico=
n
> stepping version is 0:2
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925 vsc-tp spi-INTC1094:00:
> wakeup firmware failed ret: -110
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: IPU6 in non-secure mode touch 0x0 mask 0xff
> intel-ipu6 0000:00:05.0: FW version: 20230925
> intel-ipu6 0000:00:05.0: Found supported sensor OVTI01A0:00
> intel-ipu6 0000:00:05.0: Connected 1 cameras
> intel-ipu6 0000:00:05.0: IPU6-v3[465d] hardware version 5
>=20
>=20
> Best,
> 	Dominik