Received-SPF: pass (google.com: domain of linux-kernel+bounces-97710-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <a65bb5d1-8d44-44cd-ba45-d9549fbd870e@joelfernandes.org>
Date: Fri, 8 Mar 2024 19:46:38 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] [RFC] rcu/tree: Reduce wake up for synchronize_rcu()
 common case
Content-Language: en-US
To: paulmck@kernel.org, Uladzislau Rezki <urezki@gmail.com>
Cc: linux-kernel@vger.kernel.org, frederic@kernel.org, boqun.feng@gmail.com,
 neeraj.iitr10@gmail.com, rcu@vger.kernel.org, rostedt@goodmis.org,
 Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
 Josh Triplett <josh@joshtriplett.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Lai Jiangshan <jiangshanlai@gmail.com>, Zqiang <qiang.zhang1211@gmail.com>
References: <20240307234852.2132637-1-joel@joelfernandes.org>
 <CAEXW_YQ-TZB-1gpxvf7v+QAZhHtzV5waBA1VemtgEwNktSp=ww@mail.gmail.com>
 <ccbdf4d4-6972-430c-a479-0d20b318213b@paulmck-laptop>
 <ZespK0CrkVFCu6_p@pc636> <ZetNHb6MrmHkQKJN@pc636>
 <d75fd0b2-f6e0-4102-a5d2-11c7c5487949@paulmck-laptop>
From: Joel Fernandes <joel@joelfernandes.org>
In-Reply-To: <d75fd0b2-f6e0-4102-a5d2-11c7c5487949@paulmck-laptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 3/8/2024 4:52 PM, Paul E. McKenney wrote:
> On Fri, Mar 08, 2024 at 06:38:37PM +0100, Uladzislau Rezki wrote:
>> On Fri, Mar 08, 2024 at 04:05:15PM +0100, Uladzislau Rezki wrote:
>>> On Thu, Mar 07, 2024 at 04:06:06PM -0800, Paul E. McKenney wrote:
>>>> On Thu, Mar 07, 2024 at 06:52:14PM -0500, Joel Fernandes wrote:
>>>>> On Thu, Mar 7, 2024 at 6:48 PM Joel Fernandes (Google)
>>>>> <joel@joelfernandes.org> wrote:
>>>>>>
>>>>>> In the synchronize_rcu() common case, we will have less than
>>>>>> SR_MAX_USERS_WAKE_FROM_GP number of users per GP. Waking up the kworker
>>>>>> is pointless just to free the last injected wait head since at that point,
>>>>>> all the users have already been awakened.
>>>>>>
>>>>>> Introduce a new counter to track this and prevent the wakeup in the
>>>>>> common case.
>>>>>>
>>>>>> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
>>>>>> ---
>>>>>
>>>>> Forgot to mention, this is based on the latest RCU -dev branch and
>>>>> passes light rcutorture testing on all configs. Heavier rcutorture
>>>>> testing (60 minutes) was performed on TREE03.
>>>>
>>>> Very good, thank you!
>>>>
>>>> Uladzislau, could you please pull this into the next series you send?
>>>> I can then replace your commits in -rcu with the updated series.
>>>>
>>> Absolutely. I will go through it and send out the next version!
>>>
>>
>> Joel, i sent out the v6: [PATCH v6 0/6] Reduce synchronize_rcu() latency(v6)
>>
>> Could you please rework the patch on latest tip once the series i sent is
>> settled on Paul's dev?
> 
> It is there now.

Thanks, I rebased on it and sent a v2 (along with that other comment for the
hotplug race ;-)).

 - Joel