Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp925972lqc; Fri, 8 Mar 2024 16:51:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV0m/e4t23U8qZoCeCcjRxbfS2GJ0KlZ3jBA9ULjpNHdud55YijnJ4t30m7DECOKDhYAF5hE9cx95HW8EAGqFMdwZq6EdpckfjEDQjrrQ== X-Google-Smtp-Source: AGHT+IGLLqaGlKKct4RTg8kWi2WiddWLrYwpqmubqMiusM4RngIY/efx7/l3ZhJn62Eup8oM5/LQ X-Received: by 2002:a19:384c:0:b0:513:99ff:e5e4 with SMTP id d12-20020a19384c000000b0051399ffe5e4mr329411lfj.67.1709945467220; Fri, 08 Mar 2024 16:51:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709945467; cv=pass; d=google.com; s=arc-20160816; b=hCMOduUCZkQ4BuL2Y/ReLo1FsivrhPnSe6wCQ9DZpDDBOhLSD1F9OiP/WcCfqxt5Fs Vi+DdaYBfY9pKbz3kBDqk3WinDAt/pu978zqcZvuiol6EKBujYUMsyTtwR0yHZf02y8Y 2qekdKyV35bb5/pjtPl3ngZ4GA0zwqfYNPE7gMoIzIKSaKWPABuhYb1XkYn3vxdeiEVK oBBzJE/yL9Gc/wosx8ryYd/XilynQ2IzRfFh/wTPw7lNcUi10CJymr4wscyswn4dglHp 3mvC2C7QqIMESe5ZEtYp0Dr5L9sOqDTlcsGBLtYcdOsMLsO61baQPnWYhXRdhhPKV9tQ soUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=lya7UhJlIblLkow5pi+zWUxuCvJx0mWepCjyI5q74Hw=; fh=kPO+9Mf+W+lO8YJvfRlax0vfO72lzpwIhuBXexK5YNo=; b=hsS4FokV7JCcEjsi+NcztcBCpS1vy7/ccaAHbQ41B04TDVFVD8xImkYwj2Br4ijXq/ J0d2aEWF3kXFSLT2qIGGtaF3kW7nWrQSSjnxWPJd7yrGIt0fc2wl0YEZvBUF35LHvkQM FV6wGvl4kj7UMVQpoMCj4p4MVRiLZyoE6BgUqF3Iq0gULFcnRew1ylVtfyMPEkRYBsrC 9M6eb66j9c1eykmnqnxWcH8geLYQzSiILuPPhEP2yRFbUVptWpH8n2iz+4flFdazEbzc 2CXwnqyRCd1NiNDdFqt2W7MNgWfNxBjXMeALt9zdHHNOnMpSomFXosSV9v8TmAkw6Ncb IFlQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AlYQNAi/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a9-20020a170906190900b00a449a040234si294524eje.5.2024.03.08.16.51.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 16:51:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AlYQNAi/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97711-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97711-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DDF421F21997 for ; Sat, 9 Mar 2024 00:51:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0243F15CE; Sat, 9 Mar 2024 00:50:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AlYQNAi/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EB39EA4; Sat, 9 Mar 2024 00:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709945455; cv=none; b=mor5tXienrzC8lkcyIgNxam+sOuYMTrL0nNmSCvSbHabkw//cJNuvzLFVjXpZZJBMC4TFIa0Rba3hfhnfs+Zk/I3gSItRwKZ8xm5YQmDhVcUeiktHIeKr8kqv5ULNiyvmxeQ7E3NlLi14blREQYN73IE2lovUA5FBS3ym5NZTKo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709945455; c=relaxed/simple; bh=lya7UhJlIblLkow5pi+zWUxuCvJx0mWepCjyI5q74Hw=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=IrqxUpvxfQiEaq+T9GMWutIjBEtOQNILCaRvAGbeUoAEvk3Qf9AtgyMQqMKfuxGesdUcQRT9l8y2PDZYKXeqVWfHbMKp9zpawuCWONtVdecjqh0WkzLuJU2yu58AlsPprIAutjHbgGmzMM+tZNndjKlak2Z8Xl4A1YMTD1J4nlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AlYQNAi/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 883E4C433C7; Sat, 9 Mar 2024 00:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709945454; bh=lya7UhJlIblLkow5pi+zWUxuCvJx0mWepCjyI5q74Hw=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=AlYQNAi/w+AqpTz7UMH96zryBdO4Ut6giOEm5bqpeG4djkFZMNssmyPhzGzgWYyHl AqcIsihdf2byK4CIHEI2xRmtqB2ry66/N20TaX1Tvq1i5RbIGtcDF3NbcMcCViompc 94Sgf5jSkIz768wtCVsoh4I7eUdZpOaJ5/afdxHn5o04ghQhtO0ZNd40eMbnKOSw/8 BG9HIUx8JC9T4uI/GVpAwGfM7PsMzNE3JrRLiln9ThXUgjdCuRzJYcYaomgi5OePtj uu85M6C55SmLdFWrlHkVfjD1pqr5k3YWYd32Xw4oTqOZXtBWqlBHEOrnqQ+cdECQli TJnbP80exRjEA== Message-ID: <9927a3356ce54c626ab4733844a4385b.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <022301da6fbf$aae4f7e0$00aee7a0$@samsung.com> References: <20240220084046.23786-1-shradha.t@samsung.com> <20240220084046.23786-2-shradha.t@samsung.com> <022301da6fbf$aae4f7e0$00aee7a0$@samsung.com> Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk clocks From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux@armlinux.org.uk, m.szyprowski@samsung.com, manivannan.sadhasivam@linaro.org, pankaj.dubey@samsung.com, gost.dev@samsung.com To: 'Dan Carpenter' , Shradha Todi Date: Fri, 08 Mar 2024 16:50:52 -0800 User-Agent: alot/0.10 Quoting Shradha Todi (2024-03-06 04:13:03) > >=20 > > When clk_bulk_get_all() returns zero then we return success here. > >=20 >=20 > Yes, we are returning success in case there are no clocks as well. In cas= e there > are no > clocks defined in the DT-node, then it is assumed that the driver does no= t need > any > clock manipulation for driver operation. So the intention here is to cont= inue > without > throwing error. Maybe we shouldn't even return the clks to the caller. Do you have any use for the clk pointers?