Received-SPF: pass (google.com: domain of linux-kernel+bounces-97715-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <384bf6c936fac50042389cc5f53c3199.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240303121410.240761-1-andy.shevchenko@gmail.com>
References: <20240303121410.240761-1-andy.shevchenko@gmail.com>
Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Move mask calculations out of lock
From: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, Heiko Stuebner <heiko@sntech.de>, Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Fri, 08 Mar 2024 17:06:09 -0800
User-Agent: alot/0.10

Quoting Andy Shevchenko (2024-03-03 04:14:10)
> There is no need to calculate masks under the lock taken.
> Move them out of it.
>=20
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---

Applied to clk-next

> diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fract=
ional-divider.c
> index a0178182fc72..da057172cc90 100644
> --- a/drivers/clk/clk-fractional-divider.c
> +++ b/drivers/clk/clk-fractional-divider.c
> @@ -195,14 +195,14 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsig=
ned long rate,
>                 n--;
>         }
> =20
> +       mmask =3D GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> +       nmask =3D GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> +
>         if (fd->lock)
>                 spin_lock_irqsave(fd->lock, flags);
>         else
>                 __acquire(fd->lock);
> =20
> -       mmask =3D GENMASK(fd->mwidth - 1, 0) << fd->mshift;
> -       nmask =3D GENMASK(fd->nwidth - 1, 0) << fd->nshift;
> -
>         val =3D clk_fd_readl(fd);
>         val &=3D ~(mmask | nmask);
>         val |=3D (m << fd->mshift) | (n << fd->nshift);

Should we pre-calculate the mask and shift values too!?