Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp931969lqc; Fri, 8 Mar 2024 17:07:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVoRyQU9+k4M+eVETaCDxKLPemUTdDQpYBDr4OD2yXj0cabuoKsGoIY4jNArWrcwJWS/N8DKvrgQYD3/dJGlfaCTwuqH43tzNiowEo2WA== X-Google-Smtp-Source: AGHT+IHLT+tTWrmSgo9HAZawAtRw7qE79N8VQsM1N0egxfXj39xE7qWsvRQrcN588gSPUsI3+HpB X-Received: by 2002:a05:6a21:999c:b0:1a1:67e8:ba40 with SMTP id ve28-20020a056a21999c00b001a167e8ba40mr424433pzb.13.1709946470336; Fri, 08 Mar 2024 17:07:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709946470; cv=pass; d=google.com; s=arc-20160816; b=kwV0ce6ixn3cFewTLXtMF2WzDNkg3sY3TwLK7aZfxLjeJhvtHHKbk+9ZcORRtWPmMi kPfyEBuMFM4YbcK3Nkz92El1dBhZcy1lOk60Tldo2uuNahkaC0kltEH7/5x/NNq31Lvk 8Yl8QbqUzVnNU/R4tchocgAV7anzx9Ga00vi2Q9frDJfx0jHG2pmvzZ6iRrqxe5xOasI bRqgWot9ZhLLpzIgqmBlVfGrG9xxQejs30bLFw6shdyn+HUFuHZwd34irniyYdDCU1su MVxNYP+EKWBMxiXXOH+PsTY8Tglmc34vowuhJzby9yOES+/g6v6fRCbWJKIvClcqMfGy uUKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:date:to:cc:from:subject:references:in-reply-to :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:dkim-signature; bh=0d4/5dhHEz7FfRUlkbZpqy7jl9lAa4LKfgGn/enTyDY=; fh=v5XZScf0D2FBzKJc5OXfPEHibYDC8ahIszm1I4XWmps=; b=rAyxKdH9HBLyBd56kKILKiwxafZFj9xd4CMmhC0Do5bj7oJ/KPJH8lMEP58A+TxQlS nfjEvZLVfLRqZZMD5a/c1/RT5bhbX9IuuSF00p/IAz7SDinSyTUkDnY7A+Dh/5rVRXyj gd720OWWvXRGitA3Zif+6HGSGXYTO+eHUpBQwafMx0WVp68bTUtwvk3zAsTSgNpadpZh WrgzvpdR2NcJuDuzA+7dBSaeztoGkEYX6kfTC+SYn94aivL6ToDQBIfVsfb/nRPSj4+T uoUb3tm72anwF8FTDtBq4+XgLn5i+AWqQAZVGLkhAFmAi6BpmAL/Fu7AyWJHweJVaEM0 oCxQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=okwEMuhw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97717-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a8-20020a17090a854800b0029bc5917d10si465351pjw.58.2024.03.08.17.07.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 17:07:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97717-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=okwEMuhw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97717-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97717-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 40FF7281E3A for ; Sat, 9 Mar 2024 01:07:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F282015BA; Sat, 9 Mar 2024 01:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="okwEMuhw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD4DA29; Sat, 9 Mar 2024 01:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709946438; cv=none; b=ARTQhqcsAVKd7lKX/cdYtsi+AmOYq2e1ouj1h1+WyQsxlYstG6vFA3QEIDloRdd+TXkXVUpHCX6mr3MQzG5ycxkupe8eUuXOnskxflAO8/wlSUN7U5hJ+dTwVBbj+bn7o2Te/07lqmigt0AfOvbTXBezERQTRAPH/pg65FIe1+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709946438; c=relaxed/simple; bh=0d4/5dhHEz7FfRUlkbZpqy7jl9lAa4LKfgGn/enTyDY=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=kQIGOB1mzUZRf+7lZEn4f+PY6W8v/VfixEXPjaRvoa0tAQr7xVZuZOaLDWCNot0yscpZKwoITMdohzVTkxa+NVnr22VsidfZSrY9/Jur606rC0ig43oYKpPi+nSL1VfA2gzVuulpe31laK3gbj2QktndM8N9hxKEku3ZwTdaPIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=okwEMuhw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70763C433C7; Sat, 9 Mar 2024 01:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709946437; bh=0d4/5dhHEz7FfRUlkbZpqy7jl9lAa4LKfgGn/enTyDY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=okwEMuhwqWPWKj7Bc/eTONvUO68oDHT6bA9A/EEuJ4W8wiU2iPiJXKiEJ90LBKz+r ESNK6uHoV/xvslVXrTjdnpaaG+YUP9zKn/2h016cu2PcGA9x2uQOjqDyz+SA3Z2szx eahM5W3gv/xPZH+F1q6IxeocqC7FafFIAhZd0EK3PP9IaX1X67WuAptJgSJioVvOMw 4pru9/FIBrMIlfgR/FX7OujJTHjgCJVVxtJdhtw1HXbte11WCvHBwvNH98f1M7UaXF WOWqummPJl7rJmbzWhRXCJ0QGrhr98oh3n2Tzqk5BwZONYGmx6uYbD9XDDFXzI+I/2 edcLpGE3H5hWw== Message-ID: <8c56e786b692bf9400c7f66b5d3e17b0.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240303120732.240355-1-andy.shevchenko@gmail.com> References: <20240303120732.240355-1-andy.shevchenko@gmail.com> Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Use bit operations consistently From: Stephen Boyd Cc: Michael Turquette , Andy Shevchenko To: Andy Shevchenko , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 08 Mar 2024 17:07:15 -0800 User-Agent: alot/0.10 Quoting Andy Shevchenko (2024-03-03 04:07:32) > Use BIT() where makes sense. This alings usage of bit operations > in the same pieces of code. Moreover, strictly speaking by the > letter of the C standard, left shift of 1 by 31 bits is UB (undefined > behaviour), switching to BIT() addresses that as well. >=20 > Signed-off-by: Andy Shevchenko > --- Applied to clk-next