Received-SPF: pass (google.com: domain of linux-kernel+bounces-97725-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <0fa3332abcf4593376795f52ea145722.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240301084437.16084-1-duoming@zju.edu.cn>
References: <20240301084437.16084-1-duoming@zju.edu.cn>
Subject: Re: [PATCH v4] clk: zynq: Prevent null pointer dereference caused by kmalloc failure
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, michal.simek@amd.com, Duoming Zhou <duoming@zju.edu.cn>
To: Duoming Zhou <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Date: Fri, 08 Mar 2024 17:15:37 -0800
User-Agent: alot/0.10

Quoting Duoming Zhou (2024-03-01 00:44:37)
> The kmalloc() in zynq_clk_setup() will return null if the
> physical memory has run out. As a result, if we use snprintf()
> to write data to the null address, the null pointer dereference
> bug will happen.
>=20
> This patch uses a stack variable to replace the kmalloc().
>=20
> Fixes: 0ee52b157b8e ("clk: zynq: Add clock controller driver")
> Suggested-by: Michal Simek <michal.simek@amd.com>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> ---

Applied to clk-next