Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp983267lqc; Fri, 8 Mar 2024 19:55:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXlq8Dgnwv6aSMPmLAVLFpK0SNSBr1XfGNTer8Qv3bizCRXzJA8uSLEQmxiZ5wI3VAif8FqsJYA7DM3Ss8z6g0muiJH+SWxA+3LAhuJUw== X-Google-Smtp-Source: AGHT+IEFp1TaharH0vxDJ5oO2UnApGg7WtXhm56iqdO23YyogDDdEEMTYnJj7OCcagoKrJQQIx1I X-Received: by 2002:a17:906:ca51:b0:a45:279f:3256 with SMTP id jx17-20020a170906ca5100b00a45279f3256mr287661ejb.20.1709956542108; Fri, 08 Mar 2024 19:55:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709956542; cv=pass; d=google.com; s=arc-20160816; b=Mye5+M5aoHZ/m8nHMlEqRF0n1x0ooeJMXerGSHQTQ3KsD6xeynphn+WMAtTmFjJqUG iXrXcM1iMyOFNhuN6rvsEq534pCJjwGrSQjRx7ucc4iOep+Fks1l2RodB6vfkyTxPMGm DZ5Se2fTSN+v+lbjuBq34ZXiaCasjGnt8hefmJvbyQW55lyvkezCnqUXaMBtx9pxbYXH Na/ZiZfJywTJ8czm3s1gbqzilsQxxFKLR3YrCmqSsPF1RilfZIPyDc0YbGEsHngdT1fh WNFWc+WFRQ0GIlN8Zg4KePuVVdQSWtr/5Jo5T5rgHSNiVRynvTo6k2BFVDziN1quNYbp xS0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=QPJMmB54N8EEZXhkkcTtylJQ5j9TWmzx0faLG1OCJeo=; fh=sBXKlpLw+0QtrKK+eFiTUOC2Qx1IAJE6zeI2VztYzsA=; b=k5axUgNOZCh7J6kqFyGA4x5PcfHq7utWDyINty9Moaer6aokijMtjpbywaZyiXhZdH TkjCklxc1uCidUynXpkslLQe2GzjS/hOEN1eW3uD9j/aAPONYqumy12tM0uT+7WtLb0/ KP4VDxc9VVrG3DOvt8NXgomUJyVjx218yMXuNRBwOBSR5pXg406y/60hX0uuxD+COZBu 39XWT0VMHvw6oytIwsKZ78K65S5nXNK9L/L1gIPRQsS5ACnG4Z47uCXs+BgpKqfHHYAp zA0DGuxqmj6EDWM4BfZ3LUDZh+uLbGC+cUfMGHBMxzApabR21zsqrQ5HNfb7PDslkipT m5xA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sM4Qs9ET; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qa42-20020a17090786aa00b00a4531cc9c75si426255ejc.376.2024.03.08.19.55.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 19:55:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sM4Qs9ET; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97757-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97757-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B77551F21BFD for ; Sat, 9 Mar 2024 03:55:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 463E03612A; Sat, 9 Mar 2024 03:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sM4Qs9ET" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 665E21DFE8; Sat, 9 Mar 2024 03:55:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709956531; cv=none; b=gzmqFiZ3kh56dLACDiwqycnUyHLLd8XbyqwTvNPFQNe2cJmoQ3gHpshUL6D6A3jal1ExkFANKO5sbmO8J0s96hxGyvDasOuEGUkhaxcYThWxuZHnZ0EctltsKVvWLNe+/Ma4syD63plPavd58P0PzLKzDyiWPNiuOgTKWh38SJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709956531; c=relaxed/simple; bh=cqxnRONxFqoFUHeLlMQOk9RLWMYU12XehXtvW+dv3SU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=r7JgGpwVdR7RjDBbgPw5KWVREkyIVkNvAuWRrnuHxUTqonbredHyvNYJxjYZGTmb8lCr75O+QgFclhdgd6P80SvQC639H8AaZUMIAkkuComUXRYD0IQtnf0CgH3RIDwAGQ6M4Bli7Fm8ex326LSKrm4aXREC+TsB0ERDWEN/8yo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sM4Qs9ET; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BD52C433F1; Sat, 9 Mar 2024 03:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709956530; bh=cqxnRONxFqoFUHeLlMQOk9RLWMYU12XehXtvW+dv3SU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sM4Qs9ETo7lFcytqB+dUZRGcitywoe5QpVnTaB+Gb1qLUPghLmhmX6uZfF9Q9SspY 49vo6v5lhGzBOKbolRDTxPweK0n5BUYO57gIfpAYlCTOfvJPO+tZ2/4F68jvFF6YAh Zv+mdyJWhO+n/rrHFMigEPhNepDiOhnBwNtlR6p4/4QoL+KiOY0nV7y/baUdeJJ9is MmMCG33JFuzorRhylVORKkJticmBJ0FiYHvRzRt8n6sGT4jesrgcS2EElPCpeKfPmN EFu6qHhJsSdjnqOz+kgjP7WO+fmojNwH2taMyHFfIT0WFlkmXubUw6TYcMxpdORLul wN9zMfntaM78Q== Date: Fri, 8 Mar 2024 19:55:29 -0800 From: Jakub Kicinski To: Leone Fernando Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, dsahern@kernel.org, willemb@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/4] net: dst_cache: add input_dst_cache API Message-ID: <20240308195529.57b1a4fa@kernel.org> In-Reply-To: <20240307171202.232684-3-leone4fernando@gmail.com> References: <20240307171202.232684-1-leone4fernando@gmail.com> <20240307171202.232684-3-leone4fernando@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 Mar 2024 18:12:00 +0100 Leone Fernando wrote: > +static inline u64 create_dst_cache_key_ip4(const struct sk_buff *skb) > +{ > + struct iphdr *iphdr = ip_hdr(skb); > + > + return (((u64)iphdr->daddr) << 8) | iphdr->tos; Sparse complains that you're ignoring bitwise types: include/net/dst_cache.h:170:19: warning: cast from restricted __be32 include/net/dst_cache.h:170:19: warning: cast from restricted __be32 -- pw-bot: cr