Received: by 2002:ab2:3319:0:b0:1ef:7a0f:c32d with SMTP id i25csp985465lqc; Fri, 8 Mar 2024 20:02:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXOZE6p4h2H55aVvya5Q9Xq6BKaCG4GoQ8SIwCrxgDnt+VZWA36T7+kLFS5F6clVxYWSrVPGd/EqoXrV5y+I1HmRRZd8EhdWA4Gp9GENQ== X-Google-Smtp-Source: AGHT+IGHxR+wYc67w+LNEirGwfIPt+XWHC8NzkPDtVs94gSEfHVCvsw9WpM0sovzIs3k8HnNexle X-Received: by 2002:a9d:7384:0:b0:6e5:dc2:552e with SMTP id j4-20020a9d7384000000b006e50dc2552emr1008080otk.17.1709956954414; Fri, 08 Mar 2024 20:02:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709956954; cv=pass; d=google.com; s=arc-20160816; b=L3Z+TRwXeh+bVyabBUT8G8zmRKOHCgiACPprXXPldE4aGplyytZ+/i+NuA+FzQRhn/ eR9wV30mM8yizzGtSOhxj+ioytb96m+rvoS+3PoKwSK1NzOo00nRCRAJDXkK5RzbXqsb iN9BNKi3JlwGWoS7NP+s6bKlX43mytptQomoOzNamZMgxXHoB/yBj5YvD5rOMdNOBw6q rwdVZ4kk50JJF19HclKmNCQHr4dxbcJie+bFa0G3OuaFEQmEFts2QyoelwPpkmyEPUqo 9zZ6FuneRCe+js5XZONClSbhaNipz8AxnLvGGlQ6/qtU4Rqh9eKvhUN7kwWoZVw1OmXR uI6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=BYb50n8jI04ZitPi3Q+wfbZJJAJgLq6xn4YCJg08vUY=; fh=c+WjEbzR9GtQLG4z1JEOqPT5MHi0HfVSFWNvTqNVcsU=; b=RZftf95LJuwQ5kMiKFO73sba4nVU0wml+ucvtkpinRfLGnEBCYYZ9UgtK+peESUwVk uWBGntTXBXRWEzl0ll4OCWrBky7DAHlnfmRHJCWbEC4NUVEYu2B2KgRiEGbyPIPmD/+v g3eatFwMnNo942K99hOH6xjaIwYaUOarN48lH8TiRSEniTbSK1fHKb9wIIjYdkvDNGU8 zSuv8sMg/hzOR5gxdg+LHi4/WMUL9jx43bFZr1ZjvgsIFqeIAOrhyxefIFhRw+5Uj1CU 7gymE50vPcGkQL1OQRB9jhfA887b5Xi3l//96HU/w8McF3bmUp/dei6yDG8aDAChZmfo eXVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="WNIg/8LI"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97762-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a20-20020a637054000000b005dc7e78163csi789535pgn.458.2024.03.08.20.02.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 20:02:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="WNIg/8LI"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-97762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97762-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4C598B2125D for ; Sat, 9 Mar 2024 04:02:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63AAA364C0; Sat, 9 Mar 2024 04:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WNIg/8LI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795BD3611D; Sat, 9 Mar 2024 04:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709956940; cv=none; b=ahEx3rQ7bjZm4kJtWVfhfySLLfRfpi1qPUdOKn/HDFGb8U48a+vfmk490UTKM6Ot4lSS2CB65iyNGIhpAk3ZhVT9JSkzbT7byXgsGoSf6PB4fdVgCB3dU3zs/W4YUSAg9hIqDEUvFbZab3mTL6nOGhxC0y7XKhtp/srOR45qdeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709956940; c=relaxed/simple; bh=4POfnc1a/5kHoObarFvA/ywHr33AwhH9oxhmOA8d76c=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z3/e5NnIKhZkK79pyu15U+Hyxqo+C9rJi52w1imP3dpSMH886Mr1rgWqhR9VyGiqhWRsj5t+0YeL+dV8/Qbq0d6x2aZ8+5JkUZcG6K8ZSAZ6mrmasMkm4tr7mVPUVwUa+Jfc8CioLx7WW6LYpFPhOaTjwFqLbOXAxB/RDMcAruA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WNIg/8LI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E67AC433F1; Sat, 9 Mar 2024 04:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709956940; bh=4POfnc1a/5kHoObarFvA/ywHr33AwhH9oxhmOA8d76c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WNIg/8LIxt4oDr/rEZEqeDQRwM7t01MaNgUmFLqL9hQLe7Az1LA4Zp7kvIh/mHNht eiGDp2yghrMGK7C1JjaY3NoF/KrQ+zSXp9Qkef66d3YsXIJjrNtOHOt+R0Jvjow1C8 HnQx5HXMZYmLsHS5+PHuRQsJjaO2yibikUWOgan/boeLsgm3Q+d33un9YmcPia7q24 5kxNXqtAzcA7QkXY2jb5WbuK04pfDMIPnCEpPB5G3kq5J2iuvcxieFQ7xw5KMUan5Z oO1MOi1PQTtT0ME5JUphJ/h1TvOhOp6YE88tyOwMhdK07ahXww4HB2yfVZE8a3IoOK w3CiF8WujrPHg== Date: Fri, 8 Mar 2024 20:02:18 -0800 From: Jakub Kicinski To: Oleksij Rempel Cc: Jiri Pirko , Ivan Vecera , "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Paolo Abeni , Vladimir Oltean , Simon Horman , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del_deffered operations Message-ID: <20240308200218.2e60f8a1@kernel.org> In-Reply-To: <20240308104725.2550469-1-o.rempel@pengutronix.de> References: <20240308104725.2550469-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 Mar 2024 11:47:24 +0100 Oleksij Rempel wrote: > + problem = "Failure in VLAN settings on this port might disrupt " > + "network segmentation or traffic isolation, affecting\n" > + "network partitioning.\n"; nit: checkpatch spies with its little eye that there are spaces instead of tabs here FWIW I'd also personally go for splitting the string only where the \n are, but that's up to you. -- pw-bot: cr