Received: by 2002:ab2:5d18:0:b0:1ef:7a0f:c32d with SMTP id j24csp8065lqk; Fri, 8 Mar 2024 20:57:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVoAZNMISscZofqfPHvCkH0Mke4sXxxKhJ1YMOMWCbLvzj2hlhLOFLl+MvAUIdmquOdh6Mic2VNw3t1DLzRR9PcQF4tyfp76alWHBOfLQ== X-Google-Smtp-Source: AGHT+IHp1d4AqRhB3xKbTylX//r4yvecyaPVyChvCeWOHV2BcrNKgLZxZyODMUZ6kH0OugAracdN X-Received: by 2002:ac8:7d4a:0:b0:42e:daf5:1b93 with SMTP id h10-20020ac87d4a000000b0042edaf51b93mr1712536qtb.39.1709960230556; Fri, 08 Mar 2024 20:57:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709960230; cv=pass; d=google.com; s=arc-20160816; b=PdlX9iOn4Q0eKant1GAuW8Ke2MVDuZNa0OfkZuIR0VGw1lYteFadXoGKolqV30cn5Z 1xgqRquYjFyXXzN4JtVsjQKIl7g90iApk60cD9hQesUNNJpNQjYNogVYCOe6+fVzZtrj 4GJ9EThAKTutT+weGDtvNjjeM6LytQeQt6FN9Qki/RcuzUA4qaZc8JbqAatGSNM9NcLZ BgkB4fRULTRsnFxHWS7oMLu41y/+Q4eXPDg94OAe8db4WUkUOGOVMjuuhgJ3tMTRTmL+ PwZhbL7oPSWCW/V3DUJAkQnJJWS9RYW4BkVnVMPmtfNQY8esg3x3MllR1vX11eJig8UL 5i4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; fh=nUi/659Xl8gHJYAE6Lqxo01zIuTPKy1PE4sayYkb+zA=; b=LSRdFsqbTDtjxRD3Zq/3FF6xaLqx6hfVwT5rcpeKmO4iTVxAfdOgLpqpQhaEFBNWtP IaLk3skNqJEbFcqGlVfCl7wJ5q5G9GK9+CrXr56ahQhae4zeaO87T+hcy1Z056fPaCQ/ W/TUmiiT2i1UFYxmkqv5dBPADc4kkoZS0m8OD+eS/6FzY3zjDY+74JvdDohHXU2OlEIF ChJFz1eS9rpVLoR4bjTCZGfXAy9p05MWP81cuGCSkhN05UfogClE9gKthWdx/UU7KN2m x6XK7osPWWTabprbI5XRheuv/knDAxhLghoGkGWBxZSWiG/LVPpUsWMm1tFlw6LWgqNy DeLg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Y0BDGP7h; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-97773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97773-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h16-20020ac85e10000000b0042f21206e91si1039946qtx.15.2024.03.08.20.57.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 20:57:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Y0BDGP7h; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-97773-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97773-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 40F941C20B4F for ; Sat, 9 Mar 2024 04:57:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36F802C191; Sat, 9 Mar 2024 04:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y0BDGP7h" Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDD2E18E01; Sat, 9 Mar 2024 04:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709960221; cv=none; b=AMrgLPPo2tLc2oZWkSIAFrn2ry6r56bBFQT30eCaxbWHSaNwPq9lqvmDMwUn6mAPUvBDFVNfZRj4XQBq6Ab3ACTw7Fbft/LPaZAFeW7oRRmBZbzv20VbZjsaMe9dalgCaeb5I08h6oVzlKsnT4a8E52duxzuTzRjLm659MVdbQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709960221; c=relaxed/simple; bh=d9fTii0v4jXPGCNKSpMW3BW0Oh5wmwA6rFnVlNFT3pA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=s4ZwZoT6Co1V0Gq/xL0N4d6MM/h6rSBjkOENMune7VxuYOZRA+aMtAVpUZNucfkh+bae3TFmBmY+UKtZRPxFDlQ54PEBNhkEAlwUAMEW8j0buM2R7kF3mSnJT6aynngOBSTTjrvChto2FMLJ5iCUbuO5Pjqcs1cfVzlfcdOGPKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y0BDGP7h; arc=none smtp.client-ip=209.85.222.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-7db68ed7bb1so1137835241.2; Fri, 08 Mar 2024 20:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709960219; x=1710565019; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; b=Y0BDGP7hly6pdJxinZ9Eg/P4glR44Lh+cTKlhzN6yDZ7o6LNWBfjcEXaX9Gv04S08r yErCS3zipI4VNQTCeUnWyvJBqj8FgrTOope4lK5DRYek2hO0RsnZZQEmmGXuQs+ZpqKr 49DmnE4vToWixOSm3vO1c89prU0DFASx4bXhNxdzFOWwvMcv7fvb5Df0YpcjThOc6AXi 5kcy2vu58einN5/qGlb734ONbAlajL6zfpt2ySVfjMEXPt00MWDgTfy9w7z8tAMIWwfh MURUyyJNbN9yNQhV2XHAq1b00IqU1jD1ZnbENXgQMd9DBN0znjd1x+d+JI98l/PRq5Ad IrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709960219; x=1710565019; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=osWZlmBqOmSJdGGGdtztOJyldzmIVm2zqkCVbfLVzA4=; b=i50NRCPwgPsUsqzFUu1zaA1WIbFRYlTCO3S1PW6aIjNrS6RzfhvMbe47AjMVF3ZXkp nAjFK1MHKOcbertz1/tqZbsCF9QeAXH+X0ftmlxPk9X8d/w+eYAycU5AmFWZC3OEoly8 TtPfG+2it6wGyrmecTwZYENLlOkxNBEKsJVnsaZM1a4C14d+kO+hIfqvVMcNn0ZHLSsM /J+2CqU78NFUwb5MdbJHxhOCs3E5J41j0TjfvTRCMaL9BAPBXF3TeZ6RIPU0G/o8obWw VNVXRJ7+LfbW+tNItfhxnJlzz15m5ENyhGC+HOx9puGrIhEoHTsXBqhRjE1MMfDd2Ibj 934Q== X-Forwarded-Encrypted: i=1; AJvYcCUKj19/udj3dTtNBjCn4vAM0fVlTBTy30v5YlRT+9APqBpOy/ReYf8m+SpsFLtuttD/W4ost6Ux3fxHcnfkOHnCq7+mR7FSrQsaqzbgsU0Phdoq4FF3vA1HoRyU0zWktfniqVGuFi7YBKWQ X-Gm-Message-State: AOJu0YzIgXcTwKyfr/l0+Y/+A0tjdFSJFNMt6txRPtmhfJzO0A5NLKlQ EJ0HWtb83PtwLI9EnBkWDA8mmmjAfvwliIVSYA04Dj0b/Wn+JgTxQKuFD5H0di32gbhG74xw00f bujFrTw1hJuF8eFouSyFQpvlKxGE= X-Received: by 2002:a05:6102:9a1:b0:472:eeb3:5c34 with SMTP id f1-20020a05610209a100b00472eeb35c34mr849041vsb.9.1709960218874; Fri, 08 Mar 2024 20:56:58 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240222081135.173040-1-21cnbao@gmail.com> <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org> <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org> <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> In-Reply-To: <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Sat, 9 Mar 2024 12:56:47 +0800 Message-ID: Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable To: Andrew Morton Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, vitaly.wool@konsulko.com, Barry Song , davem@davemloft.net, hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 9, 2024 at 12:42=E2=80=AFPM Andrew Morton wrote: > > On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton wrote: > > > > Okay, I understand. Since this patch improves zswap's performance, I = wanted > > > it to be integrated sooner to contribute. However, I'm perfectly will= ing to > > > respect your concerns and adhere to the community's best practices. > > > > > > > OK. I very much doubt if anyone is running those drivers on mm.git, so > > adding it now isn't likely to hurt. > > > > So I'll merge it now and shall aim to get it upstream very late in the > > next merge window. > > Nope. mm.git won't build without acomp_is_async(). > > We can merge the zswap patch via the crypto tree. Acked-by: me. Herbert Acked the acomp_is_async() patch in v5 instead of picking it up into crypto: https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/ > > Or please just resend the zswap change after 6.9-rc1 is released. > Thanks Barry Thanks Barry