Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759268AbYAFXYm (ORCPT ); Sun, 6 Jan 2008 18:24:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757026AbYAFXYf (ORCPT ); Sun, 6 Jan 2008 18:24:35 -0500 Received: from ug-out-1314.google.com ([66.249.92.170]:13328 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754911AbYAFXYe (ORCPT ); Sun, 6 Jan 2008 18:24:34 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=XJArAfU47o2o9CzxamnOntZH5DoZ85ESnu/SlxSBv/NiNTReTcY8Okvgif658ljb7p+lGVL1ExrH4kvegXKotGJIZqtVqIlId/48kyslw71YTOEUSdyGgjK0ncVaB57j2idXqXhVNlmXDUNBvSdqFMFRS/CnQ5PMGi5u0ByuGxg= Date: Mon, 7 Jan 2008 02:11:00 +0300 From: Anton Vorontsov To: Dmitry Cc: linux-kernel@vger.kernel.org, cbou@mail.ru, dwmw2@infradead.org Subject: Re: [PATCH 1/3] power_supply: add few more values and props Message-ID: <20080106231100.GA30506@zarina> Reply-To: cbouatmailru@gmail.com References: <20080106122659.GA13106@doriath.ww600.siemens.net> <20080106140903.GA23333@zarina> <20080106223049.GA13655@zarina> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 42 On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: > Hi, > > 2008/1/7, Anton Vorontsov : > > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > > [...] > > > > > + POWER_SUPPLY_ATTR(voltage_max), > > > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > > > wrt new properties, to distinct their meanings and usage. > > > > > > > > I assume you're using these new properties for non-rechargeable > > > > LiMn batteries. So, why new properties, aren't voltage_*_design > > > > ones suits that purpose? If battery is non-rechargeable it is > > > > having only design values, no? > > > > > > No, I used it for the battery driver for Sharp Zaurus SL-6000 (tosa). > > > It's connected via simple ADC so I can get only voltages. I don't know > > > max_design value for the battery, but I have 'FULL' signal which I use > > > to detect 'voltage_max' and use it for power estimations. > > > > Ah, I see. In that case the value is empiric and voltage_max is > > appropriate name indeed. > > :) Documentation patch should be pretty trivial, could you please just > make it w/o another resent cycle? Sure thing, will do. Thanks, -- Anton Vorontsov email: cbou@mail.ru backup email: ya-cbou@yandex.ru irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/