Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759210AbYAFX3S (ORCPT ); Sun, 6 Jan 2008 18:29:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756997AbYAFX3L (ORCPT ); Sun, 6 Jan 2008 18:29:11 -0500 Received: from py-out-1112.google.com ([64.233.166.178]:54457 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756107AbYAFX3K (ORCPT ); Sun, 6 Jan 2008 18:29:10 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rOXiVveG88xcvxLyV48/FmEc/aXYiEjpN4llIcBBeGU9xUQiluHEIVMwZI51sEk7tDdqKVuDYaACxv1PqSBGOaBy6kLaC7XOyRvgjI8VKN/91dSwk8Zj6EOWSp5fYoNqed+2Gtr9fl9DRr0n7s3TcAPzNqHsbNw30BQkwIotw9A= Message-ID: Date: Mon, 7 Jan 2008 02:29:06 +0300 From: Dmitry To: cbouatmailru@gmail.com Subject: Re: [PATCH 1/3] power_supply: add few more values and props Cc: linux-kernel@vger.kernel.org, cbou@mail.ru, dwmw2@infradead.org In-Reply-To: <20080106231100.GA30506@zarina> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080106122659.GA13106@doriath.ww600.siemens.net> <20080106140903.GA23333@zarina> <20080106223049.GA13655@zarina> <20080106231100.GA30506@zarina> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1759 Lines: 54 Hi, 2008/1/7, Anton Vorontsov : > On Mon, Jan 07, 2008 at 02:13:07AM +0300, Dmitry wrote: > > Hi, > > > > 2008/1/7, Anton Vorontsov : > > > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > > > [...] > > > > > > + POWER_SUPPLY_ATTR(voltage_max), > > > > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > > > > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > > > > wrt new properties, to distinct their meanings and usage. > > > > > > > > > > I assume you're using these new properties for non-rechargeable > > > > > LiMn batteries. So, why new properties, aren't voltage_*_design > > > > > ones suits that purpose? If battery is non-rechargeable it is > > > > > having only design values, no? > > > > > > > > No, I used it for the battery driver for Sharp Zaurus SL-6000 (tosa). > > > > It's connected via simple ADC so I can get only voltages. I don't know > > > > max_design value for the battery, but I have 'FULL' signal which I use > > > > to detect 'voltage_max' and use it for power estimations. > > > > > > Ah, I see. In that case the value is empiric and voltage_max is > > > appropriate name indeed. > > > > :) Documentation patch should be pretty trivial, could you please just > > make it w/o another resent cycle? > > Sure thing, will do. Thank you very much! > > Thanks, > > -- > Anton Vorontsov > email: cbou@mail.ru > backup email: ya-cbou@yandex.ru > irc://irc.freenode.net/bd2 > -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/