Received: by 2002:ab2:5d18:0:b0:1ef:7a0f:c32d with SMTP id j24csp45023lqk; Fri, 8 Mar 2024 23:15:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXO9WzA183ij3OSxfWkJBp/Bn5Pq8xVZ+izrk9PpDR5md0RM1I9/rp07u/Ch7kLivoevhcoL0CAgRRIOSPQ56uRXO5kmoUowlBFtrwdVQ== X-Google-Smtp-Source: AGHT+IGTNHKwFvzeoqf30L7GR4r+HgYAwOW/aaQ8nZnuY08x1SWpjbFUP0Y0wpKYXLfZ8oZnXmOL X-Received: by 2002:a50:f61e:0:b0:566:a526:21ea with SMTP id c30-20020a50f61e000000b00566a52621eamr929766edn.33.1709968507551; Fri, 08 Mar 2024 23:15:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709968507; cv=pass; d=google.com; s=arc-20160816; b=Nk7sN5lHi0JrS5J+pbkthUEOlvLXztZp4XvTw6dCE0hANicIcllYisNgwTipMz0YxB 3VdUQDGqYB0n7rDodjT6cU11rCIYPctS9mKPI3vvKT8q2ft2853UsJufoKDY2gcTKXtg Wf0uZiGrUYVIiZ6FS0DuSc84fE/dXJ1BAGnFRUdZqbor6T0oR34qDNxBbJuyGe9av4b3 J94GXek1Esip0UVwIkstYQJLk17+bDqFMbvQKkZFyufQQIDLftn9Frvku7zaaPHwZPUT enU5YrqCoMk9jLdindOb18SLiZwRQdrvApCCq8EVukBh3K7s/Pn9JEccuGRR/h61VW57 /shQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Wj0a7M7l17B7oSix7RsEEFA/BNZJuUH9b3WzsB1M9ns=; fh=oSYg153VkCL7TT8PosKhdNrGWThydDWIaMH2RAkKIfY=; b=LXf2kEy0JRzLHDRgvS2I/2K3dCpdKYaNsbfIswrO7yhO2TCzBMyr562VTa9SwqUGhh CTl7mAhM8Iy+Z3fHvSV0zJB0NVn2O5W+PE5D+lOh9mharLEMt+pVjn2wPrlKDWVDGYsG U5ACfHG6tOJZvkV6lLapDP868V+nt9HyZxpZqBPm0ici8sySb94wkch0uuxX6GqKzCt7 nSQpgAag+ylzuTSWWed2Be2b98VQYDVIRwXINWBo94Zy2zepyySnrynAMGac+POnxjZw 19D7x87A4zCefwFd1v/tvqig0rR6dQ20S4WXWgyDu40MxZ8JMKLimkGG6glKtmU80ikZ zgYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=18L9XkYH; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-97794-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97794-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id f8-20020a056402150800b00568213e30dasi528071edw.377.2024.03.08.23.15.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 23:15:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97794-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=18L9XkYH; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-97794-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97794-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 49B981F2185E for ; Sat, 9 Mar 2024 07:15:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7569B36AFE; Sat, 9 Mar 2024 07:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="18L9XkYH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B836249F5; Sat, 9 Mar 2024 07:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709968497; cv=none; b=npgD8Uln8+vTVpHyFfvWDkqHV4nPbAygrbANCkH4OiFT1HTX75sJq8d8jazsV5mZEVXnxsXZ1QP3vTU1RFTWrQhndkhdU9xTru+7J1jVHMZhPA6VIbZz1/rLe1vWFsnsQHc3UryHlFUqbw1Tn3SefnMs8k2cM4D2RgokZYlw7hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709968497; c=relaxed/simple; bh=PwI5R2vM7donkPrkZefO+Qimv4iRpNjz1gHWr3VgWhE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hqUTPvIyJabPf2DqwXxfFd9Aw3Xbvqi1jKCzfi7lgy07nSAjiAVBJKa8N8x+bkObNq58jkUdu7/IvmyBtADqMOQVqaAHJL0bWcz6jtI/sqUEoq6zxI7Zzp+Y5n0/mDeI1EPc4oEG0h2YOt2fw68lxVpZGa8n4lRQWGWBLOk2qNk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=18L9XkYH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F8C3C433F1; Sat, 9 Mar 2024 07:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1709968496; bh=PwI5R2vM7donkPrkZefO+Qimv4iRpNjz1gHWr3VgWhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=18L9XkYHVg4UtJU+bFoBNsnhmzRc+ekCdd/kKZOX+AGf6ijVyHRGsDd7RBmADRpyC csjAEVT7HR0v52eCjSU29R2/aLBLDKwK8RywKgDQ/V12ZFIenLWKmhIkg/YJg+XD6y a1MWg7j2sn+Z6KL8rL3KfORYCF3LNPkvqevj1VtQ= Date: Sat, 9 Mar 2024 07:14:48 +0000 From: Greg KH To: Dingyan Li <18500469033@163.com> Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] USB: Use EHCI control transfer pid macros instead of constant values. Message-ID: <2024030910-hurled-ibuprofen-1b52@gregkh> References: <37bdd932-07a4-4514-a5cc-b70d48c962a6@rowland.harvard.edu> <20240309033709.14604-1-18500469033@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240309033709.14604-1-18500469033@163.com> On Sat, Mar 09, 2024 at 11:37:09AM +0800, Dingyan Li wrote: > Macros with good names offer better readability. Besides, also move > the definition to ehci.h. > > Signed-off-by: Dingyan Li <18500469033@163.com> > Reviewed-by: Alan Stern > --- > V1 -> V2: Replacement in more places where Alan pointed out. > This should be v3, as you have added Alan's reviewed-by, and added the proper versioning information. Please resend it as such as our tools can't dig it out from the end of the thread like this :( thanks, greg k-h