Received-SPF: pass (google.com: domain of linux-kernel+bounces-97811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: rrameshbabu@nvidia.com
Cc: ahmed.zaki@intel.com,
	aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com,
	andrew@lunn.ch,
	corbet@lwn.net,
	davem@davemloft.net,
	dtatulea@nvidia.com,
	edumazet@google.com,
	gal@nvidia.com,
	hkallweit1@gmail.com,
	jacob.e.keller@intel.com,
	jiri@resnulli.us,
	joabreu@synopsys.com,
	justinstitt@google.com,
	kory.maincent@bootlin.com,
	kuba@kernel.org,
	leon@kernel.org,
	linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	liuhangbin@gmail.com,
	maxime.chevallier@bootlin.com,
	netdev@vger.kernel.org,
	pabeni@redhat.com,
	paul.greenwalt@intel.com,
	przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org,
	richardcochran@gmail.com,
	saeed@kernel.org,
	tariqt@nvidia.com,
	vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com,
	wojciech.drewek@intel.com
Subject: [PATCH RFC v2 3/6] net/mlx5e: Introduce timestamps statistic counter for Tx DMA layer
Date: Sat,  9 Mar 2024 00:44:37 -0800
Message-ID: <20240309084440.299358-4-rrameshbabu@nvidia.com>
In-Reply-To: <20240309084440.299358-1-rrameshbabu@nvidia.com>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?man5AUH11nHWLpaBo8adj6z4kmXDm2hu3phwD7tJFq8W7DRNVScQMARrt3QY?=
 =?us-ascii?Q?hXtNCJkPm3x0fEBLZHXg1yAzGsnFKSGKMBy01GasS1wY2mB6GT9lxjdY90Er?=
 =?us-ascii?Q?FE0qzMcuSiAK+HqG+cSZlQcEVPd5loxyL0oRC8Rxw5AtZYSyyQ4PePmu9ovr?=
 =?us-ascii?Q?dxSjhFgkUv+qNpvt8mGuK9Z6/zTzuY7LdEv0rWLPToqqUP2KXIDCnZO/F7sd?=
 =?us-ascii?Q?/V9Gle+k7/tgik0L1CN+2HqPhFlUYlmQ+agOhZ0NXe8vQkaSF0hnVyKFjtFr?=
 =?us-ascii?Q?FjPRRqSAboV/YoRsy0dDZ3hm0zjVEf67teAyYUQXXqrvuov8G+qSvckLRSLl?=
 =?us-ascii?Q?OYDvh3etsS6q9Z/7jwPmYkV1/BixdwZ4+rJFqiGMSd2jREzvABrdcoxRyTRy?=
 =?us-ascii?Q?6t5tWPb8RG6preHEHJCh9zePkA5mYdrD+B933FlfYiv+k1TvIuLhDmqzmsoI?=
 =?us-ascii?Q?W86MdUed/qzr/MaOx1L/FkbnNm2EPZaZ3XN5Rg1ACVMdrkCDy2pKzEopkzqI?=
 =?us-ascii?Q?Q2eer9YKYLl1silIWXutQJFHcJBclMZ8tnR+azeyfvMGxwfEPRYP5DPQWsKG?=
 =?us-ascii?Q?AYnKqCoxMVEp/pZTP/etfWIvv+zhe/qsG7Yzg5W+aoGlj6jGDRf5CNuPWyuh?=
 =?us-ascii?Q?0j9/yP5rbqjy2bxnE3u+ouMw2Q4m28xNqWe2YcW6yJayuEIgsjTu44t9BPvM?=
 =?us-ascii?Q?0HuU167+LwwgJxceeOF5qr/ZGYH+T/ov/tf02V1pmm0BvhG5StgVEwXGiPyR?=
 =?us-ascii?Q?W0mO/zH3uYFyStGSF1Iwwl5zLSQfqeplGiC8oJwIVl3BgK+I84yk8hb+PEnu?=
 =?us-ascii?Q?NdniMAfTjUkqA3IB/ul3swJ0klgVODIEt4G1MO5wE8PT6L/uyThhHAntk/qJ?=
 =?us-ascii?Q?0pNwWJKxMJFDEFW6ZRLvSPtaFDd6auFWIqZiC2ASxdbm5o/gHZtKg7CCO2fW?=
 =?us-ascii?Q?VdFH+3y0Vf/kcV/eT8N8V/XMvT7ydNt0XEdo1jxZdeXLAfFcfSaJisbPxa2e?=
 =?us-ascii?Q?C/F2qaoStwruFwrL3sLuxsy4EBdR9jo3yMuF7yMz+yB03OwPOE9l8KYexhus?=
 =?us-ascii?Q?m20fTRU7a7HKnGK6hfEfjPgHxJSaVtmAuLvmK0dCFn/tdVIGNa4PJnYYKHPY?=
 =?us-ascii?Q?d6089vpw7+cYWpwP/Ahr3PawxwfNYKMDwYrxbpdW1xRc6QT4Ol91BWpxmx1u?=
 =?us-ascii?Q?k1ZQ7Rx+wseGuN9K/84m9BrX6whrqsbBoAgWtbnNHcLIva7LjqYAgh5iPEF3?=
 =?us-ascii?Q?L/DB1v/+E5vSgX+LD/Bj6+V2lxhCDrfW4ReNHThbwOeK0+y+bNVhQb+H6jMJ?=
 =?us-ascii?Q?SlS7pm8VCLRcP4G/sGcac+FiYp3fDeKd7IW0nNeQrf6wiTeaJhFQiNUfVMIc?=
 =?us-ascii?Q?+O30zsjLwm/A44q+ySjbkg8XBHiaeOGftdobEox/bQCny1WAvk+TuOXNqalY?=
 =?us-ascii?Q?QxLvom35ylzFd79Kn12cxZ66bqrh5bkU5NGuLaEzjAKHheuGP60QFIWF0qHg?=
 =?us-ascii?Q?L2hcn79vsTJnGPKyo6IUz1i8aul+73GNOIb9Pm8YoFT4HnY4eOVfUefQGD1Y?=
 =?us-ascii?Q?rfbjGkYdJ8SLgd6P3P9RmTGBBetWhXZNN+BQk+vaPpqIxHSXFi05OeK/1ifg?=
 =?us-ascii?Q?VQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ae9d297-2aff-42f0-9346-08dc401532e3
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2024 08:44:57.3947
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oEkB38Conwe5FeCbMerGIG2Kr/UZDg8Rjlv5J3pB1iLPBhL1NN88Bmwqitee5TSGCRNYxPYrXm0qVqugJ2i0kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9394

Count number of transmitted packets that were hardware timestamped at the
device DMA layer.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
---
 .../device_drivers/ethernet/mellanox/mlx5/counters.rst      | 5 +++++
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c          | 2 ++
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.h          | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/en_tx.c             | 6 ++++--
 4 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
index 5464cd9e2694..fed821ef9b09 100644
--- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
+++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
@@ -300,6 +300,11 @@ the software port.
        in the beginning of the queue. This is a normal condition.
      - Informative
 
+   * - `tx[i]_timestamps`
+     - Transmitted packets that were hardware timestamped at the device's DMA
+       layer.
+     - Informative
+
    * - `tx[i]_added_vlan_packets`
      - The number of packets sent where vlan tag insertion was offloaded to the
        hardware.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 7e63d7c88894..bc31196d348a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -2046,6 +2046,7 @@ static const struct counter_desc sq_stats_desc[] = {
 	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, csum_partial_inner) },
 	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, added_vlan_packets) },
 	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, nop) },
+	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, timestamps) },
 	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, mpwqe_blks) },
 	{ MLX5E_DECLARE_TX_STAT(struct mlx5e_sq_stats, mpwqe_pkts) },
 #ifdef CONFIG_MLX5_EN_TLS
@@ -2198,6 +2199,7 @@ static const struct counter_desc qos_sq_stats_desc[] = {
 	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, csum_partial_inner) },
 	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, added_vlan_packets) },
 	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, nop) },
+	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, timestamps) },
 	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, mpwqe_blks) },
 	{ MLX5E_DECLARE_QOS_TX_STAT(struct mlx5e_sq_stats, mpwqe_pkts) },
 #ifdef CONFIG_MLX5_EN_TLS
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
index 03f6265d3ed5..3c634c5fd420 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
@@ -429,6 +429,7 @@ struct mlx5e_sq_stats {
 	u64 stopped;
 	u64 dropped;
 	u64 recover;
+	u64 timestamps;
 	/* dirtied @completion */
 	u64 cqes ____cacheline_aligned_in_smp;
 	u64 wake;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
index 5c166d9d2dca..5acba323246e 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
@@ -748,11 +748,13 @@ static void mlx5e_consume_skb(struct mlx5e_txqsq *sq, struct sk_buff *skb,
 		u64 ts = get_cqe_ts(cqe);
 
 		hwts.hwtstamp = mlx5e_cqe_ts_to_ns(sq->ptp_cyc2time, sq->clock, ts);
-		if (sq->ptpsq)
+		if (sq->ptpsq) {
 			mlx5e_skb_cb_hwtstamp_handler(skb, MLX5E_SKB_CB_CQE_HWTSTAMP,
 						      hwts.hwtstamp, sq->ptpsq->cq_stats);
-		else
+		} else {
 			skb_tstamp_tx(skb, &hwts);
+			sq->stats->timestamps++;
+		}
 	}
 
 	napi_consume_skb(skb, napi_budget);
-- 
2.42.0