Received-SPF: pass (google.com: domain of linux-kernel+bounces-97812-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: rrameshbabu@nvidia.com
Cc: ahmed.zaki@intel.com,
	aleksander.lobakin@intel.com,
	alexandre.torgue@foss.st.com,
	andrew@lunn.ch,
	corbet@lwn.net,
	davem@davemloft.net,
	dtatulea@nvidia.com,
	edumazet@google.com,
	gal@nvidia.com,
	hkallweit1@gmail.com,
	jacob.e.keller@intel.com,
	jiri@resnulli.us,
	joabreu@synopsys.com,
	justinstitt@google.com,
	kory.maincent@bootlin.com,
	kuba@kernel.org,
	leon@kernel.org,
	linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	liuhangbin@gmail.com,
	maxime.chevallier@bootlin.com,
	netdev@vger.kernel.org,
	pabeni@redhat.com,
	paul.greenwalt@intel.com,
	przemyslaw.kitszel@intel.com,
	rdunlap@infradead.org,
	richardcochran@gmail.com,
	saeed@kernel.org,
	tariqt@nvidia.com,
	vadim.fedorenko@linux.dev,
	vladimir.oltean@nxp.com,
	wojciech.drewek@intel.com,
	Saeed Mahameed <saeedm@nvidia.com>
Subject: [PATCH RFC v2 2/6] net/mlx5e: Introduce lost_cqe statistic counter for PTP Tx port timestamping CQ
Date: Sat,  9 Mar 2024 00:44:36 -0800
Message-ID: <20240309084440.299358-3-rrameshbabu@nvidia.com>
In-Reply-To: <20240309084440.299358-1-rrameshbabu@nvidia.com>
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?8lOi2hH6tsq/A3KOPh3uuRSnI6cPLNph+ju3VJLhTxpJmbT63CEIWgCqYFig?=
 =?us-ascii?Q?xJemNowF4mFSk1OeZGMeegLVvCqRZyxP5TWV6flgki9HUMzDT/GXVoJLhIyW?=
 =?us-ascii?Q?jWoEa5jcDljz/o8ckKVw+lIK2qDSnwSaifMBWZiv+NsXe0MDM6KUUBqYNPux?=
 =?us-ascii?Q?U68EMnDyitd0kdx8Cyg81qZF4E234kMOKi+P1TRifvW7voAQKPLtQO9XUY/O?=
 =?us-ascii?Q?VCdTn9YcJHBD8ri2uq+7iGixGA4YbpuqA/VOE9zX+eldB3P8ynTbG0VFwJmD?=
 =?us-ascii?Q?qOKdQJRetndVqIWprlbNaGOzxYNB8TKYed1k++ggW8jtAajGvtWycUtRcPUx?=
 =?us-ascii?Q?G98MjXqxEhmdn59Epep9WEFXq+Tml4FQcJel/W/L0yQgj5Fa79pe1PzEXTC2?=
 =?us-ascii?Q?c8fZDcCsMhxGIoDQ2vRUAbhpaRr9iVK8f3V7FOak86Y/nTNOvPUOI6+jrIbM?=
 =?us-ascii?Q?Z3D4sK1GT2UF/M4FPVPFsF8CfRx6C9UuzGW7JwBnuR0zQoXfe5FMUuQRbxg/?=
 =?us-ascii?Q?DKCrRcWCjUtMT+1uWW8OgjejpSdnzH8v7+MIE0YgCRnaAmzdpKGMIBw3XP7a?=
 =?us-ascii?Q?hbfQ+PapY5RAq3LJLUn3JI/v+ML0mhyhDp1GypEmcSLDrZXgaNEaN/waI2FO?=
 =?us-ascii?Q?tCfIB88aJf9RxvglPz5YhmPlOg4DePpds1ADH1VQWSzz6/rJLuqB7MRiTnWE?=
 =?us-ascii?Q?sEHmtAF74B81uXWlYn5jg7sUxuBNqQQG2vV4aasAVczL8tKhr4tU4DgxG/jb?=
 =?us-ascii?Q?TyhhAT8tceXSthH1nXVlh9JuHtBq9t2aWc6z7UqsU7UarP2vleTAJRKg/6Oe?=
 =?us-ascii?Q?yHTzhUjOaKrESQ/UxlCEpNSoDqtk4uz6djalRCaWm5v8JyLRpvDuHVTU4xkb?=
 =?us-ascii?Q?Kprl9meZZZMpN2uStGuJCsudJdUUmFVR+OlbOQDup1QUMOZy7ri0ZA9FGMSw?=
 =?us-ascii?Q?PUrjwEZ/wXOP1zg8L2h1/UEcd1RSvCUtwuPve6Df09OnpAs3jywvwGvOzBgz?=
 =?us-ascii?Q?Fq5s9PU50xddR/7kBF0+G+mW9K866O5+RQkFfUZo/nqD9DTxKQ8O7MDJfzSP?=
 =?us-ascii?Q?X4CrknBkbGUPBxNZUgwSGtpfdoKqRD9k4kDHgnqqb6cEVz2mTo/oaDTAwOqb?=
 =?us-ascii?Q?lzjdUU00DnlfnCr5WWG2Af4yexx6rFj0rfM9A5yOjmAbbbiC4YVGOtVgmVtc?=
 =?us-ascii?Q?aQY1pccMuo1iIR3vAsvHTF5d12sQxYpYMrACiBFiFajERyM61myYhXE7H9Nx?=
 =?us-ascii?Q?+aIrsyzemP9AYaA0eeJxvkjHC3nfU6lFJPYuYm5/opOO77uDC52s+4Ipy3Od?=
 =?us-ascii?Q?yJX2NvkeIx9pdkI1ZnSBvTgLG8BH9b0XJKAeZlxEuys3to4bWXQfoooCHGkL?=
 =?us-ascii?Q?69LxZP38DHaAGr5yVoKzA1nP9pMgmwxNVkUbf9Vfs0Rn5mqn7+l+pd3/ynMz?=
 =?us-ascii?Q?l2grg4Lp8FcOa44odsVcqVZYSQj1r28rGFifO0KzDYTqgyIK92uTInhyN1V8?=
 =?us-ascii?Q?LFcjAr+vgTovAZ9dU1Dcz/qmDbshvNgc+/sYUfmNfBKr7ffbfPn0UJniEC57?=
 =?us-ascii?Q?C4QBn+E6kCfykdEd+0z+ENeZqjXk+oQDPEjc2WOvv751RUtbjKwpNibfCZY0?=
 =?us-ascii?Q?CA=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8922ad58-ca86-40a0-ad3a-08dc40153253
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2024 08:44:56.4011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jyH4pHdWEcddYapr7xj5lcZCdbNktwGvjBoU0m0YIXhBO4zGw0Kt9TJtPMNEyxA1aFr3+D5Ebwyovd5qZplWyA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB9394

Track the number of times a CQE was expected to not be delivered on PTP Tx
port timestamping CQ. A CQE is expected to not be delivered if a certain
amount of time passes since the corresponding CQE containing the DMA
timestamp information has arrived. Increment the late_cqe counter when such
a CQE does manage to be delivered to the CQ.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 .../device_drivers/ethernet/mellanox/mlx5/counters.rst      | 6 ++++++
 drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c            | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c          | 1 +
 drivers/net/ethernet/mellanox/mlx5/core/en_stats.h          | 1 +
 4 files changed, 9 insertions(+)

diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
index f69ee1ebee01..5464cd9e2694 100644
--- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
+++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
@@ -702,6 +702,12 @@ the software port.
        the device typically ensures not posting the CQE.
      - Error
 
+   * - `ptp_cq[i]_lost_cqe`
+     - Number of times a CQE is expected to not be delivered on the PTP
+       timestamping CQE by the device due to a time delta elapsing. If such a
+       CQE is somehow delivered, `ptp_cq[i]_late_cqe` is incremented.
+     - Error
+
 .. [#ring_global] The corresponding ring and global counters do not share the
                   same name (i.e. do not follow the common naming scheme).
 
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
index fd4ef6431142..1dd4bf7f7dbe 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
@@ -169,6 +169,7 @@ static void mlx5e_ptpsq_mark_ts_cqes_undelivered(struct mlx5e_ptpsq *ptpsq,
 		WARN_ON_ONCE(!pos->inuse);
 		pos->inuse = false;
 		list_del(&pos->entry);
+		ptpsq->cq_stats->lost_cqe++;
 	}
 	spin_unlock(&cqe_list->tracker_list_lock);
 }
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 4b96ad657145..7e63d7c88894 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -2158,6 +2158,7 @@ static const struct counter_desc ptp_cq_stats_desc[] = {
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, abort) },
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, abort_abs_diff_ns) },
 	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, late_cqe) },
+	{ MLX5E_DECLARE_PTP_CQ_STAT(struct mlx5e_ptp_cq_stats, lost_cqe) },
 };
 
 static const struct counter_desc ptp_rq_stats_desc[] = {
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
index 12b3607afecd..03f6265d3ed5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h
@@ -461,6 +461,7 @@ struct mlx5e_ptp_cq_stats {
 	u64 abort;
 	u64 abort_abs_diff_ns;
 	u64 late_cqe;
+	u64 lost_cqe;
 };
 
 struct mlx5e_rep_stats {
-- 
2.42.0