Received: by 2002:ab2:5d18:0:b0:1ef:7a0f:c32d with SMTP id j24csp107714lqk; Sat, 9 Mar 2024 02:41:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVME6I1gEmLEGPREQSZlNwdhadt5i9QpDQdu/So/10fZX7EzNqLr2vdnW8F7xa+ioAGexPE8PJlb2xraw2YXcY+d6o12UE7zGETCb0KBQ== X-Google-Smtp-Source: AGHT+IExK+3jrB886W2P9xlOr1WAR7HvPnoa3ZjMJT4t+940QN1bzXofDHX7dlfuNFTQLol/TsHB X-Received: by 2002:a17:906:3997:b0:a3e:eb81:ab5b with SMTP id h23-20020a170906399700b00a3eeb81ab5bmr780765eje.54.1709980872557; Sat, 09 Mar 2024 02:41:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709980872; cv=pass; d=google.com; s=arc-20160816; b=FU2Zmea2j7sw5AmQmeJp0+fJQDgGYuKzWMQlvROQlQLjgWkoSJshqSXPb8k+vO4GJ5 raQneoSXAiqhAq1u8dR9ntDBAxtTt80FE+nREL/uTVdz6MKSPb2sPtsHkwULeooUnPcq 1TQZUsRIr8WjURHkmeow441P8M3nOyiifd5/nPh72Y81Vd7YDYaitPBbOpydxSs1aeV9 qAXb4OMrsmTgAhex9tz1i1PDmxtgmjPZPKp83jjxXfz9MKx0BTowmzkokrt8Op0T9+BV 7SC0EqgomvuWNpdUBYR1nAUp8DOEj+T8GUocP8SP4sYKGPq1+AsqC7IxBGs5i3Ce+r9g 3zxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=/zwcDfLfy6H/xwTNg7xVsc+HCBPAWPPDyK8ncs4w+gs=; fh=VV4KVxwd0QUau0gVxD40loPo/fsfZF6RxLwIeItTNTU=; b=jsYwU84qlMwGSnMyAX7hhiRrCyMQ2B4aN2JRYH9ljbAR3Z4wr1z39ai67xXBgRC++W KdFVWd28EnS1clqmYtmGt/PnGj04fWX1STHfl69wr7hcBIxhDmOXyHEZgnKgRSAmT2gE OausIDR8cMnvwI8ZqVrijXe1F0ngPWfGfT+P74tiNX5TAiauy9UTmfRCtq7y0g2SBiOi 6h/vvqoauOQSDnJbVuubxw2dY0CvjIw++FSpHdtlBcaRxrTPPSDeSoROmY7geR7Vn4I8 1mTM6XnJsNJXKZZnq/Trla7vj7iqw7nSrgjvUE1SjKHl1VAUC2z2vSz7ZWwYfHoj3+dq qGeA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T+stfkch; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-97856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97856-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k16-20020a1709067ad000b00a4469b1cec8si676761ejo.714.2024.03.09.02.41.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 02:41:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-97856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T+stfkch; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-97856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-97856-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4D08E1F217F9 for ; Sat, 9 Mar 2024 10:41:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B22CD2DF92; Sat, 9 Mar 2024 10:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T+stfkch" Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5216C28E22 for ; Sat, 9 Mar 2024 10:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709980863; cv=none; b=rbIpMUu4HF73XRf9QuwjZcewnp+RwiuzI7Iy3xMP7UsDNO2TYbddIlysOuNobs90BObeH6ynFrHh28dSMY5jX/fzAq5scekneY5TPeUrhMSuJW+Tsip34VxHkMJSptyuX5yupymAfBNLdm1ZjTLsinr6Tf/2QqXfMxX1qx0YTXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709980863; c=relaxed/simple; bh=Dh9V2PfB348Arae8187yykw+A7d4pAIxQgkMlEODmIY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=aM2ToreXpFSdCBJs/OSLSKKInMrI/XzLfNaAI7yYdxipD4ZgjJQDl8X1z9DgWxWgYVL33JHVc/14EEPWnRchAWVUgDRzH5XneLYNa0ueaBdhUYJwzTApHMfLeNLlXVaDLpSEU4qkhfVnsksLJ8u/T9Ww8pd25se3Kkhb4iy0WCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=T+stfkch; arc=none smtp.client-ip=209.85.219.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-db4364ecd6aso1903153276.2 for ; Sat, 09 Mar 2024 02:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709980861; x=1710585661; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/zwcDfLfy6H/xwTNg7xVsc+HCBPAWPPDyK8ncs4w+gs=; b=T+stfkchbw3OzdhVTmml7wBSaHenkNjauK1L1qMQKhTAvvGdhPD7hBCiyo5MdNF/pE 10bEQswQKQ+p1NQbdguDlUAOYKU19ywyp5araFn/nZJLZoYe7teiKXkl/AatHLWzAdjr kbTwfhptcVhnmySU3No7yrH2gAb1hsaEEuqSYUd4CVTukpXM4CIUkoCrMpkxVVAVdrGY xUDEt6VXUPJOXM+fot8W3bHdCAZ4gjUhzIFBI/rkTy+puCfc46n5qIk32BB07ePWmvs9 uzWYwUH0rzHUVO3EdPGceDh9Za/BqBv58TAr4ZUzxMgO+D6JvXp2iqVUFGtSpMu6NGB4 JtGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709980861; x=1710585661; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/zwcDfLfy6H/xwTNg7xVsc+HCBPAWPPDyK8ncs4w+gs=; b=matQ6d/8nqDMtT1sjBEbsrRVswFlAXgUV0ZEDr6wZZlC2daZSNTXgBQs0D4MKaLS4O nUyqbJlXWGc+0ubOUcDqnhKg72Z3iIMgKnaI668YjPYWPfJSF7T8YWSO4zX5y3cZ7lds H5t7f0vX0SvGiliU9LF8kOdD0pJjsRBq86EAP1Jt5PFjtxJpGvrCsetlTYdZC1MgYS0h Qs5DDJ5S3QbbyouSg1oAmVmD7rzQpFK/QoSDyiQKPn8GjPHFiY9fKZFmtlttgk2WLzQc 3oUTu56Q07zVI0bIzNQiIkA4oIMQaECXX4mVOwE5Cle1pzfkwX/8ksxMO7jlqkAcCv6v +aKA== X-Forwarded-Encrypted: i=1; AJvYcCU2KwYz0TRYBYAsiC/Q401UYeMv179KtepdMjrCEI06IDETz13zojrjM/aFFOm18aNn9xVbhu7HUudLjid7NPKccnhjIGhijHX0nRRu X-Gm-Message-State: AOJu0YwwDWQV4o47+Xp7roMk6n6Y5xjFADdI7jreE53AMo8wgoeBA5gS wCQoTqCthkt6K3puj7RshGcD7vxijPWt3FDwY0aZ7uEpElGjDmDcHytKH1jkc58NCJMmd++3v04 p3zGSZOwfGbbwWcyub8UwMa63rsZL5dnCz0T3jA== X-Received: by 2002:a25:b325:0:b0:dcf:f535:dad6 with SMTP id l37-20020a25b325000000b00dcff535dad6mr667006ybj.56.1709980861366; Sat, 09 Mar 2024 02:41:01 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240308-topic-rb1_lmh-v1-0-50c60ffe1130@linaro.org> <20240308-topic-rb1_lmh-v1-2-50c60ffe1130@linaro.org> In-Reply-To: <20240308-topic-rb1_lmh-v1-2-50c60ffe1130@linaro.org> From: Dmitry Baryshkov Date: Sat, 9 Mar 2024 12:40:50 +0200 Message-ID: Subject: Re: [PATCH 2/3] thermal: qcom: lmh: Check for SCM avaiability at probe To: Konrad Dybcio Cc: Bjorn Andersson , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thara Gopinath , Amit Kucheria , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sat, 9 Mar 2024 at 00:08, Konrad Dybcio wrote: > > Up until now, the necessary scm availability check has not been > performed, leading to possible null pointer dereferences (which did > happen for me on RB1). > > Fix that. > > Fixes: 53bca371cdf7 ("thermal/drivers/qcom: Add support for LMh driver") > Cc: > Signed-off-by: Konrad Dybcio > --- > drivers/thermal/qcom/lmh.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry