Received-SPF: pass (google.com: domain of linux-kernel+bounces-97923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <CANn89iJRXjYTojFyHN6s1Qu9Vkkk6RwxPF=bAKPjOg9zT-GupA@mail.gmail.com>
 <tencent_4E77E34FDA2F438430621DF220620A882407@qq.com>
In-Reply-To: <tencent_4E77E34FDA2F438430621DF220620A882407@qq.com>
From: Jason Xing <kerneljasonxing@gmail.com>
Date: Sat, 9 Mar 2024 22:49:19 +0800
Message-ID: <CAL+tcoAHN_-c6eVuOY=O_8xJ_KLPS9yUpeW524nuSMo5RXd3jw@mail.gmail.com>
Subject: Re: [PATCH] net: mark racy access on sk->sk_rcvbuf
To: linke li <lilinke99@qq.com>
Cc: edumazet@google.com, alexander@mihalicyn.com, davem@davemloft.net, 
	dhowells@redhat.com, kuba@kernel.org, kuniyu@amazon.com, leitao@debian.org, 
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, 
	willemb@google.com, wuyun.abel@bytedance.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 9, 2024 at 10:10=E2=80=AFPM linke li <lilinke99@qq.com> wrote:
>
> > OK, but what about __sock_queue_rcv_skb() in the same file ?
>
> I notice that, but I am not very sure whether there is a data race. If it
> is a similar situation, then the same patch should be applied too.

During that process, I see no lock owning the socket, so sk->sk_rcvbuf
should also be read locklessly.

Thanks,
Jason

>
>