Received-SPF: pass (google.com: domain of linux-kernel+bounces-97941-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c7f88cb9-8035-4a8a-8e3b-532453fa9f32@gmail.com>
Date: Sat, 9 Mar 2024 16:35:21 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: trivial-devices with vdd-supply: true
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1ee8fc6f-5299-4ba5-bb61-14b4351c0708@gmail.com>
 <7856f1b7-e12a-4530-82c5-416ec66e1885@linaro.org>
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
In-Reply-To: <7856f1b7-e12a-4530-82c5-416ec66e1885@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 09.03.24 16:00, Krzysztof Kozlowski wrote:
> On 09/03/2024 13:22, Javier Carrasco wrote:
>> Hi,
>>
>> I am trying to figure out the current policy to add trivial devices
>> (I2C/SPI devices with at most one interrupt) to trivial-devices.yaml or
>> include a dedicated file.
>>
>> Apparently, bindings for the same sort of devices where "vdd-supply" is
>> provided require their own file, and I wonder why there is no
>> "vdd/supplied/whatever-trivial-devices.yaml".
>>
>> Instead, files with trivial bindings + "vdd-supply: true" are added on a
>> regular basis. That property is not saying anything specific about the
> 
> Anything needing supply is not really trivial anymore, because we want
> the supply name to match more or less what's in datasheet.
> 

That seems to be the case for devices with multiple supplies, but for a
single supply "vdd" seems to be preferred over any name in the datasheet
like "vcc", probably due to a copy+paste effect?

> Solution is sometimes to allow generic "power-supply", like panels have,
> AFAIR. If you have new device, just add new binding for it or add the
> device to existing binding with very, very similar device.
> 
> See also:
> https://lore.kernel.org/all/YUz+psAILnF5L5GH@robh.at.kernel.org/
> https://lore.kernel.org/all/20210921131804.GC1864238@roeck-us.net/
> https://lore.kernel.org/all/CAL_JsqKJgvK8g+zbzLCBxnKbgAioBcdHWNAvqe4Z9BzkNMwPpA@mail.gmail.com/
> 
> 
>> device beyond that it needs a supply, which is very common. Is that
>> intended and no more generic bindings are desired?
>>
>> On the other hand, trivial-devices.yaml includes several devices that do
>> require a single supply (e.g. several sensors), but it is not explicitly
>> documented. Did the requirement of providing vdd-supply arise after
>> those devices were added to trivial-devices? I think that some devices
> 
> You would need to analyze the history... requirement of providing
> supplies was kind of always. Just like trivial devices were.
> 
>> that were added to trivial-devices in the last months could have also
>> had a vdd-supply property, so I am not sure about the rules to choose
>> one way or another.
> 
> https://lore.kernel.org/all/20230505204810.GB3506915-robh@kernel.org/
> 
> Best regards,
> Krzysztof
> 

Thank you for the references. In that case a device in
trivial-devices.yaml is better than no bindings at all, but if a supply
is required (which is often the case), dedicated bindings or addition to
existing bindings from a very, very similar device is better.

Best regards,
Javier Carrasco