Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754390AbYAGB7m (ORCPT ); Sun, 6 Jan 2008 20:59:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753046AbYAGB7g (ORCPT ); Sun, 6 Jan 2008 20:59:36 -0500 Received: from mga09.intel.com ([134.134.136.24]:48823 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752806AbYAGB7f (ORCPT ); Sun, 6 Jan 2008 20:59:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.24,251,1196668800"; d="scan'208";a="276237496" Subject: Re: [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device From: Yi Yang Reply-To: yi.y.yang@intel.com To: Alan Stern Cc: David Brownell , pavel@ucw.cz, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Organization: Intel Date: Mon, 07 Jan 2008 09:52:59 +0800 Message-Id: <1199670779.3551.7.camel@yangyi-dev.bj.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 (2.10.1-4.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 25 On Fri, 2008-01-04 at 11:38 -0500, Alan Stern wrote: > On Fri, 4 Jan 2008, David Brownell wrote: > > > > > This patch changes empty output to "unsupported" in order that a user knows > > > > wakeup feature isn't supported by this device when he/she > > > > 'cat /sys/devices/.../power/wakeup', please consider to apply, > > > > thanks. > > > > > > What about simply removing "wakuep" file if wakeup is not supported? > > > > It may not *stay* unsupported, so I think changing it in either > > of those permanent ways would be confusing/misleading. > > How about changing it to say "unavailable"? That doesn't imply > permanence. This should be an option. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/