Received-SPF: pass (google.com: domain of linux-kernel+bounces-98020-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <232dcca6-d4b0-4c5a-9e17-d9c194a67a71@gmx.de>
Date: Sat, 9 Mar 2024 20:10:08 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] platform/x86: wmi: Avoid returning AE_OK upon
 unknown error
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
 hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com
Cc: rafael@kernel.org, lenb@kernel.org, mario.limonciello@amd.com,
 linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240308210519.2986-1-W_Armin@gmx.de>
 <20240308210519.2986-2-W_Armin@gmx.de>
 <42aa0678-4472-4964-b84e-33beb0a23058@linux.intel.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <42aa0678-4472-4964-b84e-33beb0a23058@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:bQLXA/Vtssg=;CT9Pwn50BiNYHjGT7XPhvyIqIlS
 RLcj0xxPfT5Zl4y8pjH1MTwZNBe106baIhBQAr/6JLnw0kW9yrIyJwva1dWUkC30SmMknrrgk
 Avb06p0ol5JJcQcDujMSS3HkNE8ZvbzhRoxkgFM+QfhVVHtbK1HoARi3HXtbNO0w15KedNDKA
 2mfDXXGKCcUOu7SWviFyPCDIB1xlc2widQHX02Rz1dN2BnSB0ihK+5Lt5DCnkDM8OSf0pGwFL
 y0CiJ025AbgPPw1wNsIfIwHE208Guc5SBVwBpGK45WviGdnGueb4CHwOeRJggs4O+ciD1kNg8
 Pj55RezL3wnm/uIZhdFoMnPcPTSqJs4sySXyALn8pz8AaJl6+JQEL1vYmW+KW7GrI4NSXBqHu
 WW1GROanmMctJEmt2MwS+px2IRyxsAPTZ5dqBj8gEfYIcb0LJoTv4BBnJfEi7KxWmRxUpq5+M
 i3SQ86eHTHxj0IRZtuYRD15ZcSIOYtg91RTLMcEXYbANSFMpuSwXJ9Ef9+/hejelRMdOixjaV
 zDj5zGIebqwKhRyHmnC41ZThzyFBb/UPHeIKLGeXmyB/fQzx62Kle6MRk9FMTGeXMt6flyZ1a
 KUiHQtOvbNqxoeeT8iJFx3ZMPjkPYlzv8UKOQaFfTB/yHl1Nmk7eeyNOlSe5bQ/umkwBMn3K7
 dbr5BhpbQQdkQ4DdbHzp8R7wtMgRUKAS5GBT12fl2AcJ1LROgDMU6FYXPrN+aG/7aXeXo+Y4Z
 1cIYqOfjJReTAvs39r06Zz4E23bG1tWfkZ0Nb4RaY+WtCEK3EIX09f5sKKolh8s05WIldDMKb
 hgwYVzCwVruadiP+0KwWjaNUV2htBi7aNkIV5M6BsugcM=

Am 09.03.24 um 18:41 schrieb Kuppuswamy Sathyanarayanan:

> On 3/8/24 1:05 PM, Armin Wolf wrote:
>> If an error code other than EINVAL, ENODEV or ETIME is returned
>> by ec_read()/ec_write(), then AE_OK is wrongly returned.
>>
>> Fix this by only returning AE_OK if the return code is 0, and
>> return AE_ERROR otherwise.
>>
>> Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus.
>>
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> Reviewed-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>> ---
>>   drivers/platform/x86/wmi.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
>> index d9bf6d452b3a..84d1ccf6bc14 100644
>> --- a/drivers/platform/x86/wmi.c
>> +++ b/drivers/platform/x86/wmi.c
>> @@ -1218,8 +1218,10 @@ acpi_wmi_ec_space_handler(u32 function, acpi_phy=
sical_address address,
>>   		return AE_NOT_FOUND;
>>   	case -ETIME:
>>   		return AE_TIME;
>> -	default:
>> +	case 0:
>>   		return AE_OK;
>> +	default:
>> +		return AE_ERROR;
>>   	}
> After checking the callers of acpi_wmi_ec_space_handler() it looks like =
there is no benefit in returning different ACPI status per error values. I=
t is not being used. why no just return for result < 0 AE_ERROR and return=
 for other cases?

Hi,

those handler functions are being called in acpi_ev_address_space_dispatch=
(), which uses the return value to print error messages.
So it makes sense to return different ACPI error values here.

Thanks,
Armin Wolf

>>   }
>>
>> --
>> 2.39.2
>>
>>