Received: by 2002:ab2:5d18:0:b0:1ef:7a0f:c32d with SMTP id j24csp337895lqk; Sat, 9 Mar 2024 12:34:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU21u2atNxftXkaahQ2j7/wdDqfATSsZXC19C3Xt/XQ0/MMuFjocoPexsLdNvV+j8/XCLtV5Xe1lISYLDPBCJ3S1pCGkSrinCTCw2fwjQ== X-Google-Smtp-Source: AGHT+IHmPV79h64fGOVB8lcsW/3lSIYfZfnjosogV9qnVrIXZ+djV6bD3BntR779PVgcJuD0TL0h X-Received: by 2002:a05:622a:1107:b0:42e:f5bd:b30c with SMTP id e7-20020a05622a110700b0042ef5bdb30cmr3590664qty.57.1710016446625; Sat, 09 Mar 2024 12:34:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1710016446; cv=pass; d=google.com; s=arc-20160816; b=ytrkgqTP+K0PppJcFVC6OpfojjQ/BjOLPqd2B+0b22Vx8miCzpq5igzKi9lqXZmil4 PTgYkspk4MB173ovN+8eRCz6kySi9KVhPzmxeproW/mLIFRX4OW/FisJwdLMocW4OKCz DlEvMaDwMwB6HoRz2LunEZiwl2ye6PdITAEgzJc42dh2DAif1OpkGtwS1jqB0dhm+qxm DlJ4R4lE40Xiy78kKcjg8Pdmkx/+EXYW2I4FeTIbskUOSkrZxkV4b1qEP27aihJt6j1B krZd79Cupp2dMAMZot7tcxpaydZxgZkpLMbydH7AVQIeUZysElZXnreU0ImL0AQ6wc8J YMqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=wsLvds74XFvPRZt+5SLhXxXFTA14aJAZhNEVhjPIrvk=; fh=I08OICYdMavStwtz2M9L832HUkRdoaRXRsnNhrtww1U=; b=KeC/WFAR18A9Wb175f0n6qwlYZtlTYrP61vLChFBRBDHOvAqK+rfnlQGrUUJjGKCmj hHg6K29g2uwmzGvLPel/ZsKJp8OL22rv+VS2SwmKsN4Xd+E8WTNHAds8MatUK7pY/R+k GzG1wQ7uOQJ8wEkp4c/ce9HXyb149HTrA+YIhexlwef+uDCozMqvqk603fTC8ulCC8xm IU5OFlH7Wmn7Br0jdg1yLljIgbaz95qpOoE/8Rt47ivt7XoqgkcgSHJqZukF1fyVoKr2 N/JbzRBJ7XrFWasBkOl83soCOFKEoXZj+TFa0J/BZK4scO5ZYZHvahCs/zPYYo9gA8aP ok7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H0VGmGZX; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-98033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98033-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d12-20020ac85d8c000000b0042f142a346dsi2345613qtx.55.2024.03.09.12.34.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 12:34:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=H0VGmGZX; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-98033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98033-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D0E91C20B64 for ; Sat, 9 Mar 2024 20:34:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B821C1C3E; Sat, 9 Mar 2024 20:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="H0VGmGZX" Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BF422F07 for ; Sat, 9 Mar 2024 20:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710016437; cv=none; b=tvVcXyuByOcVk+hLb1Fe3p3zEAyEgjUUbDk4tEdR9X1nty+jW7iU5zUsogmTxjqm7oFlXFp6dK5pn9Qf3gpuKY1jF028n34ngf2RMIFg0oAsgTsuLDynBIvjWuRcb9pan1dJ6qJNyOTNGUHvXkkivs9wyszvYBx+SmQNzse9q+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710016437; c=relaxed/simple; bh=EcVIXfIICY3Ok2eDXhdHjNP9eppBGwoPoBbQbWCdGQs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=GvjWiv58EEASa3l6nsLTGphskyQki1SEfivj1xH/yO3+UxWjXWb3Grye8O7L+6jI3Z6QAdusmrTqrcdKMlWai1sPswllFd0zOqfEA1tfUQ1uIUAmJInilOA859oVx5UQknSOW7NygnhDOSzVbJrSlOZyi6L50eW6cZFgVREE1C4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=H0VGmGZX; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5d4d15ec7c5so2722507a12.1 for ; Sat, 09 Mar 2024 12:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710016435; x=1710621235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wsLvds74XFvPRZt+5SLhXxXFTA14aJAZhNEVhjPIrvk=; b=H0VGmGZXyUF+OV3/clYF/ovjxWbHc2nKovGKsUKXgr4m0F4BoSTLxopfmw7MHCxtJS Qf384rAFnF8rjq+UkIiawNKdPbYQytf8KSQAl8XnilBaIEKmxR84O4F8DTBPjC9KoslF 3L0f/k9BPEJqOdpVWpBiJaTXmfgwoZieyRfVE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710016435; x=1710621235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wsLvds74XFvPRZt+5SLhXxXFTA14aJAZhNEVhjPIrvk=; b=IHRnbzq0kBfnUfGlo/LpDPk/13AGvNlssc5u3t4rKpjQ90fLiJZxE3oizdgqFSxegJ wX4739MUr3PSL5r6OaSuqioaYXYpyi+0gZeTADTuUjnYN0eaIoXZgRyrBCodkurj+Dir tna4Ukr7YIjHIn5Zi4t5Fcj2QbEHtc89j4f5ztij26U6FWaBGUf8ee0To2avpvhuqSGD YR7ADA7cONrpfrFF1AC6UmH2FSOrGslYb1SH5bcpnjkVZsZOv2liKGzZzcDPDZujxwis UnA0tPePjMuYv7sYrFiy1nmNvemda7U1BrWDf76IvmWY3TT4q1pPAC0SeoFq/bf1hA5e af0A== X-Forwarded-Encrypted: i=1; AJvYcCWLyjwmkGLKjrcXZNAtwATwojWyQOLx9R8CWYZRi5H8P/dGJGwjA+Y5aqQX/Xd0Q5wKnhd2fXUvgCK9lSAkszOiOO4felNDIo4fJajv X-Gm-Message-State: AOJu0Yz/8hjIlMxs2w6L1/wmz1Hd6AsoMMWImYo7PJIhFenOO3b2ALOW 55SOXv6M0HJ6GXxXL64WDrYHNSVIhOtTWdck/Ns6eQs1gbnJ7zn2Q9rur1igzw== X-Received: by 2002:a05:6a20:72a6:b0:1a3:11b7:a0de with SMTP id o38-20020a056a2072a600b001a311b7a0demr317316pzk.15.1710016434950; Sat, 09 Mar 2024 12:33:54 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id a18-20020a637f12000000b005e49bf50ff9sm1644000pgd.0.2024.03.09.12.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 12:33:54 -0800 (PST) From: Kees Cook To: Tony Luck , "Guilherme G. Piccoli" , Christophe JAILLET Cc: Kees Cook , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] pstore/zone: Don't clear memory twice Date: Sat, 9 Mar 2024 12:33:51 -0800 Message-Id: <171001642971.4101342.15404186717889149238.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Sat, 09 Mar 2024 09:24:27 +0100, Christophe JAILLET wrote: > There is no need to call memset(..., 0, ...) on memory allocated by > kcalloc(). It is already zeroed. > > Remove the redundant call. > > Applied to for-next/pstore, thanks! [1/1] pstore/zone: Don't clear memory twice https://git.kernel.org/kees/c/c8d25d696f52 Take care, -- Kees Cook