Received-SPF: pass (google.com: domain of linux-kernel+bounces-98058-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240309210230.239045-1-kirill.shutemov@linux.intel.com> <20240309210230.239045-2-kirill.shutemov@linux.intel.com>
In-Reply-To: <20240309210230.239045-2-kirill.shutemov@linux.intel.com>
Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Date: Sat, 9 Mar 2024 16:02:58 -0800
Message-ID: <CAC41dw-ptOjRuOLefeu2-k_K1sigKVNxRxh+-9SHNooMfH660A@mail.gmail.com>
Subject: Re: [PATCH 1/4] x86/tdx: Introduce tdg_vm_wr()
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@intel.com, 
	hpa@zytor.com, seanjc@google.com, ele.reshetova@intel.com, 
	rick.p.edgecombe@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 9, 2024 at 1:02=E2=80=AFPM Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
>
> Add a helper to write to a TD-scope metadata field and use it to set
> NOTIFY_ENABLES.
>

Add a note about why you create this helper function. I think the
intention is to reuse it
to update other TD-scope fields.

> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  arch/x86/coco/tdx/tdx.c | 20 +++++++++++++++-----
>  1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c
> index cc67f7380055..5ffe5ef99536 100644
> --- a/arch/x86/coco/tdx/tdx.c
> +++ b/arch/x86/coco/tdx/tdx.c
> @@ -77,6 +77,20 @@ static inline void tdcall(u64 fn, struct tdx_module_ar=
gs *args)
>                 panic("TDCALL %lld failed (Buggy TDX module!)\n", fn);
>  }
>
> +static inline u64 tdg_vm_wr(u64 field, u64 value, u64 mask)
> +{
> +       struct tdx_module_args args =3D {
> +               .rdx =3D field,
> +               .r8 =3D value,
> +               .r9 =3D mask,
> +       };
> +
> +       tdcall(TDG_VM_WR, &args);
> +
> +       /* Old value */
> +       return args.r8;

Since the update failure will panic, any use for returning the old value?

> +}
> +
>  /**
>   * tdx_mcall_get_report0() - Wrapper to get TDREPORT0 (a.k.a. TDREPORT
>   *                           subtype 0) using TDG.MR.REPORT TDCALL.
> @@ -902,10 +916,6 @@ static void tdx_kexec_unshare_mem(void)
>
>  void __init tdx_early_init(void)
>  {
> -       struct tdx_module_args args =3D {
> -               .rdx =3D TDCS_NOTIFY_ENABLES,
> -               .r9 =3D -1ULL,
> -       };
>         u64 cc_mask;
>         u32 eax, sig[3];
>
> @@ -924,7 +934,7 @@ void __init tdx_early_init(void)
>         cc_set_mask(cc_mask);
>
>         /* Kernel does not use NOTIFY_ENABLES and does not need random #V=
Es */
> -       tdcall(TDG_VM_WR, &args);
> +       tdg_vm_wr(TDCS_NOTIFY_ENABLES, 0, -1ULL);
>
>         /*
>          * All bits above GPA width are reserved and kernel treats shared=
 bit
> --
> 2.43.0
>