Received-SPF: pass (google.com: domain of linux-kernel+bounces-98137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f23e2390-a054-4958-98a1-103327fb6bd5@gmx.de>
Date: Sun, 10 Mar 2024 07:27:29 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 1/2] platform/x86: wmi: Support reading/writing 16 bit
 EC values
To: sathyanarayanan.kuppuswamy@linux.intel.com
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, rafael@kernel.org,
 lenb@kernel.org, mario.limonciello@amd.com, linux-acpi@vger.kernel.org,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240308210519.2986-1-W_Armin@gmx.de>
 <a6152da8-5f3a-458b-bc48-4bc654677ece@linux.intel.com>
 <2fcd7176-108a-47dc-8096-99a5b6a69641@gmx.de>
 <CAC41dw88TfH472rFG2+WnG=BuHThBXSUfWOzRV0aJacdYHjFOQ@mail.gmail.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <CAC41dw88TfH472rFG2+WnG=BuHThBXSUfWOzRV0aJacdYHjFOQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:iFk5KlLPr8w=;4aPoaGbHCA1tww3bw20A+WPNalQ
 HcSTlOLgb7YNvJ923Od0dq2paLBi8zgq9Em+GHY73jdWLz5kluG66jRJ/xIgEDQm7xpvjIHp8
 zFX8E93dPFbc5M7lnMzRjVzgqKe7tuaUqOUiHpLvKQHHCJDulzODKgH34fVYqhNJQqNKCVm34
 nYhTkqTZad67WFOnjxl7epd5VuMzQJ/GK/eyPnxhE+bUtsk04b9Qc1k3Ds72Cy/UuzraCeY2M
 M7KuQG86m5KMMPKnC/MKdO5CAOyES2fUcP3nWNRDPmP1XEZVyU/UAOOGdjh8dnCL6G8k1MnbP
 FJOND4Zy1DmspVzFQbyEk8noUoov0o7C2Fl3Yu+ETHNEfj85AzxMGuFsCE6JnzX3VQ/Lzb5io
 vJaGPYwyw1bS4G/YYR+EHBVQGQaAxkxipFTXLWNdECicGl8BRfhe3g30Ii873esWebMj5VFg8
 jtJKM53NpMmkLEX/dw1+RcdqvLfsWQKAAn+VfklmDju2lYC6qkr1jRbOcXsg7xDrbl2Pu2/ln
 DAVkOhRihKE3Z8wk7i8mrChR3qvwOf/2CituAbAmOS2a9o5SnOeY0PhXRejYVpEg23cMhBL4h
 CjgkzPsBNyenm1fcTB2AwoT8XA4iTKggm0GPJlZ8jFp29t40RIvXZnRJnJe+AtvX3eIhZqWox
 cJXdt8aCJ/zJOfN1SVLL75WiNgPGrgfXEHZCKirf/3F6O6uU7t2gUTqduW1vk5GioS7AEM23J
 xrcSQKXAPNHmlbm2kDvmfRL8HJDv5jMB+PjUjBQ7i0VI/mt5ydpww8TevA+A7e3DrDpxEU19B
 ZnlxGiF5Nq0PZeMNXGMZ+tl175FE4CVykyxHu0TrYr/as=

Am 10.03.24 um 03:39 schrieb Kuppuswamy Sathyanarayanan:

> On Sat, Mar 9, 2024 at 11:17=E2=80=AFAM Armin Wolf <W_Armin@gmx.de> wrot=
e:
>> Am 09.03.24 um 18:07 schrieb Kuppuswamy Sathyanarayanan:
>>
>>> On 3/8/24 1:05 PM, Armin Wolf wrote:
>>>> The ACPI EC address space handler currently only supports
>>>> reading/writing 8 bit values. Some firmware implementations however
>>>> want to access for example 16 bit values, which is prefectly legal
> /s/prefectly/perfectly
>
>>>> according to the ACPI spec.
>>>>
>>>> Add support for reading/writing such values.
>>>>
>>>> Tested on a Dell Inspiron 3505 and a Asus Prime B650-Plus.
>>>>
>>>> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
>>>> ---
>>>> Changes since v3:
>>>> - change type of variable i to size_t
>>>>
>>>> Changes since v2:
>>>> - fix address overflow check
>>>>
>>>> Changes since v1:
>>>> - use BITS_PER_BYTE
>>>> - validate that number of bytes to read/write does not overflow the
>>>>     address
>>>> ---
>>>>    drivers/platform/x86/wmi.c | 49 ++++++++++++++++++++++++++++++----=
----
>>>>    1 file changed, 39 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
>>>> index 1920e115da89..d9bf6d452b3a 100644
>>>> --- a/drivers/platform/x86/wmi.c
>>>> +++ b/drivers/platform/x86/wmi.c
>>>> @@ -1153,6 +1153,34 @@ static int parse_wdg(struct device *wmi_bus_de=
v, struct platform_device *pdev)
>>>>       return 0;
>>>>    }
>>>>
>>>> +static int ec_read_multiple(u8 address, u8 *buffer, size_t bytes)
>>>> +{
>>>> +    size_t i;
>>>> +    int ret;
>>>> +
>>>> +    for (i =3D 0; i < bytes; i++) {
>>>> +            ret =3D ec_read(address + i, &buffer[i]);
>>>> +            if (ret < 0)
>>>> +                    return ret;
>>>> +    }
>>>> +
>>>> +    return 0;
>>>> +}
>>> Why not use ec_transaction?
>> Hi,
>>
>> because ec_transaction() is meant to send raw commands to the EC. And A=
FAIK read/write transactions can only transfer a
>> single byte at once, so using ec_transaction() would yield no benefit h=
ere.
>  From the implementation, I don't see any length restriction. If it is
> a functional restriction, then fine.
>
> int ec_transaction(u8 command,
>                     const u8 *wdata, unsigned wdata_len,
>                     u8 *rdata, unsigned rdata_len)
> {
>          struct transaction t =3D {.command =3D command,
>                                  .wdata =3D wdata, .rdata =3D rdata,
>                                  .wlen =3D wdata_len, .rlen =3D rdata_le=
n};
>
>          if (!first_ec)
>                  return -ENODEV;
>
>          return acpi_ec_transaction(first_ec, &t);
> }
> EXPORT_SYMBOL(ec_transaction);

Since we are using the ACPI_EC_COMMAND_READ/_WRITE, we can only read/write=
 a single byte, as specified
in ACPI (12.3.1 and 12.3.2).

Thanks,
Armin Wolf

>>>> +
>>>> +static int ec_write_multiple(u8 address, u8 *buffer, size_t bytes)
>>>> +{
>>>> +    size_t i;
>>>> +    int ret;
>>>> +
>>>> +    for (i =3D 0; i < bytes; i++) {
>>>> +            ret =3D ec_write(address + i, buffer[i]);
>>>> +            if (ret < 0)
>>>> +                    return ret;
>>>> +    }
>>>> +
>>>> +    return 0;
>>>> +}
>>> Same as above.
>>>> +
>>>>    /*
>>>>     * WMI can have EmbeddedControl access regions. In which case, we =
just want to
>>>>     * hand these off to the EC driver.
>>>> @@ -1162,27 +1190,28 @@ acpi_wmi_ec_space_handler(u32 function, acpi_=
physical_address address,
>>>>                         u32 bits, u64 *value,
>>>>                         void *handler_context, void *region_context)
>>>>    {
>>>> -    int result =3D 0;
>>>> -    u8 temp =3D 0;
>>>> +    int bytes =3D bits / BITS_PER_BYTE;
>>>> +    int ret;
>>>> +
>>>> +    if (!value)
>>>> +            return AE_NULL_ENTRY;
>>>>
>>>> -    if ((address > 0xFF) || !value)
>>>> +    if (!bytes || bytes > sizeof(*value))
>>>>               return AE_BAD_PARAMETER;
>>>>
>>>> -    if (function !=3D ACPI_READ && function !=3D ACPI_WRITE)
>>>> +    if (address > U8_MAX || address + bytes - 1 > U8_MAX)
>>>>               return AE_BAD_PARAMETER;
>>>>
>>>> -    if (bits !=3D 8)
>>> Since you want to support only 16 bit reads/writes, can you check for =
>16
>> The 16 bit reads/writes where meant as an example, ACPI code can reques=
t much larger values.
>> The WMI EC handler should be able to handle those, just like the regula=
r ACPI EC handler.
>>
> Got it.
>
>> Thanks,
>> Armin Wolf
>>
>>>> +    if (function !=3D ACPI_READ && function !=3D ACPI_WRITE)
>>>>               return AE_BAD_PARAMETER;
>>>>
>>>>       if (function =3D=3D ACPI_READ) {
>>>> -            result =3D ec_read(address, &temp);
>>>> -            *value =3D temp;
>>>> +            ret =3D ec_read_multiple(address, (u8 *)value, bytes);
>>>>       } else {
>>>> -            temp =3D 0xff & *value;
>>>> -            result =3D ec_write(address, temp);
>>>> +            ret =3D ec_write_multiple(address, (u8 *)value, bytes);
>>>>       }
>>>>
>>>> -    switch (result) {
>>>> +    switch (ret) {
>>>>       case -EINVAL:
>>>>               return AE_BAD_PARAMETER;
>>>>       case -ENODEV:
>>>> --
>>>> 2.39.2
>>>>
>>>>