Received-SPF: pass (google.com: domain of linux-kernel+bounces-98140-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <d7ab3fd4-6c7a-4ff9-a870-535af51256e5@intel.com>
Date: Sun, 10 Mar 2024 14:41:42 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [linus:master] [readahead] ab4443fe3c: vm-scalability.throughput
 -21.4% regression
Content-Language: en-US
To: Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
CC: Yujie Liu <yujie.liu@intel.com>, Oliver Sang <oliver.sang@intel.com>,
	<oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>, Guo Xuenan <guoxuenan@huawei.com>,
	<linux-fsdevel@vger.kernel.org>, <ying.huang@intel.com>,
	<feng.tang@intel.com>
References: <202402201642.c8d6bbc3-oliver.sang@intel.com>
 <20240221111425.ozdozcbl3konmkov@quack3>
 <ZdakRFhEouIF5o6D@xsang-OptiPlex-9020>
 <20240222115032.u5h2phfxpn77lu5a@quack3>
 <20240222183756.td7avnk2srg4tydu@quack3> <ZeVVN75kh9Ey4M4G@yujie-X299>
 <dee823ca-7100-4289-8670-95047463c09d@intel.com>
 <20240307092308.u54fjngivmx23ty3@quack3>
 <ZeoFQnVYLLBLNL6J@casper.infradead.org>
From: "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <ZeoFQnVYLLBLNL6J@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjNjcVFyZnNSdWM3UVZKZWdLWmwvVUtZR000OU0zMW5LY3hadlpzbjlUelYv?=
 =?utf-8?B?M1E5d1FrMS8vbDRZZnAzOFhzWjZteGhDL0oxWXJIcmR3azMzSnpyUlVuRzQw?=
 =?utf-8?B?K25xT1FhY3JxdjlyRUZvMDFlSVlORTdxMm9TbEZWaFVwdFRHQVd2WVNZck8v?=
 =?utf-8?B?NUNGbk9ibVdOaEUyT1QvazBCWjdDZVpQS21WOGxjWEhtTTlXVVVRT2lLeUxF?=
 =?utf-8?B?UnA4RmdXQkd2NHc2ZE90VkN5U0FDN0o3cnlCdktCYUlTckFIM29CdnZDR0hk?=
 =?utf-8?B?YVlhdHQ5Z0hNZDBZQVpUbTRkV1dLODdBZlh1aFRUT1p5bTBQbEs2VW0yY2xV?=
 =?utf-8?B?UFlWbXJHNlZsRGsrTFJjMHErZTNFc3FOcm9Mc2ZDbjBmUW1RODZBZENUQ3ZI?=
 =?utf-8?B?dmlWNUtnamZzZE9RTXh6M0JyV0ZnRm9TWFBWOWExUzBoZ0VLZVlkWnJPb0Fs?=
 =?utf-8?B?Uy8wQ2dDeDlvdFN4YXZTVldzcENJZWd3WkVVK0h2MEVIeWVxWlg5cTdmWTZP?=
 =?utf-8?B?Z1lXTGNmcjFPNllVdE1qazg5K3NCa3I3SHJ1Y0lTNnlVblJCT1F0cEEyZ3NI?=
 =?utf-8?B?TnFJUUp4LzR4bDhYVkY4aEQzWXZ2cFJoMlNSTzVpaXJKMWdFa2VOREhGTVg0?=
 =?utf-8?B?blUyTVU5Q0lhcExvbExnRzBxWUhzTkpMV0lTV29XSkN0R2FacncxZU1PZjlr?=
 =?utf-8?B?Z2ExVGhOcjRxSEN6OHZ5czFkTXRmc2ZPRVcwTGZMU1FqRkpLNHhYV0xXei9l?=
 =?utf-8?B?ZEFvWDErbnQ2cUlMSlkxSDVrYkxXclZLQXk1bThyVVl6c3ZtbjFUR2NLZTI5?=
 =?utf-8?B?TjNkRitlSHJYY3VvL3BVRlQxNFRtOGJsUThqeTM1NEZ5TjRVR2tmMVVBME00?=
 =?utf-8?B?OGY1YW5kUGNxYytIdUNtNXdKNU8wSGZJUGZSUzFialVtK0t6Q3dQdUhzVkpE?=
 =?utf-8?B?aFdGcUxnK0dJTXNpUUdDbW42N1hzd05qbW1TQ2Q5L01GQ0craTZ1dXc5ZWQy?=
 =?utf-8?B?dlJsdm9rZ2lCODJBZEdzelJRRzlhOVRhcG5PMHIyMzhnSHdzbkhaSkcreVdi?=
 =?utf-8?B?eEU5QTZRa0FnQ1FBQ24zVWtEV2NKZnpEd3QyVFdMM1NTdW5yaDZHSHNRT0Uy?=
 =?utf-8?B?eHhPLyt2UnJCdUswd1JST2dKNEliRmZTUkNpS0FVY0RKeUlRNmtuOUQzb1p1?=
 =?utf-8?B?eVFWQ1p0R2FLdVNlcUVSNEdydGtWd3VtbmtaUEF6MytWc21GSjJwcmR4dVpL?=
 =?utf-8?B?SWI3TUlpSld6dm9rZEViUFdmVEpzcHFhTjdRVU5mUW1QRnViR01QVFlweSti?=
 =?utf-8?B?ZEpJQ0k5WDNmdGs1cXo3M0ZXaEk0OHB4dStTbzdZWXV3b3phMmdySUZlaEh5?=
 =?utf-8?B?a2Q5eDZ3S08yV0lNaUZFRExLRnp5UTBueTVMbW5mWVpHZnl6Njk4STlpWDZR?=
 =?utf-8?B?Y2JQVDVSVHNPenltVlo3aU1jR3FDSFFGdXJGMmsraUZwbnQvUGtnbG5QS0xH?=
 =?utf-8?B?cHlJUjl3ejFvd3hwTkJQWEs4czFRV0x2Y3ErYk5kMmtzYUNJc2hQNXNQT25h?=
 =?utf-8?B?c04rVGh1QnIzeVlhVHdZMHJtN3B5NDU4Y0tzYzQ4Zk5wVC9ZS1RtS05WaFd4?=
 =?utf-8?B?bkRUSHNFcjZuMXUvMUs5TEdkNEZQM1pWRUNtcWMyc09xVlZNajRpNm9Pbzhj?=
 =?utf-8?B?bGJYNk43cUtPZFFMUkdmSExzSXpCZEZxUC9aZC9JZEhuTm0wRzg3ZFlmNzZ0?=
 =?utf-8?B?T1JoVzU3eENJNGdaQjRDbWMxNENLejNTbWpYWVBJZ00wemZjTCs0NDNGTXhX?=
 =?utf-8?B?VjFPZ1I0Qk9temFZQTAvRkdxaFlvalROM29yZ2RGcCtzYnJDRUNjbzlHK0Fi?=
 =?utf-8?B?eHRzeHFuUzAzUWNlTXI2Ly9DL0FSemRNa0lWTE5sUEIrdjYyUFYvMXJlakVM?=
 =?utf-8?B?bnE5cE54NzhVbUxqOGU2aE50L2IyNXc4eW44VFI5K2laYWZNc3plVTlXZm8v?=
 =?utf-8?B?Q1lMQVY0ZmJ3Zm9qK3g1N0c2YWxSTkRxTjhzMW1NRW5iL3JyOFE3RzlaODk4?=
 =?utf-8?B?SXR0TzBYVk9jYkRaZGZSZVIyYldiR283WTRvWFhpQkY2YndGeWowV1hDVG5o?=
 =?utf-8?B?dGUyYmVoZm5YbGpzUVVFVlcwMUJ0OUZmNHZqcTRXNDNTZWFTbitkcmJmeGI4?=
 =?utf-8?B?d1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bace1491-bbeb-4ba9-8586-08dc40cd27ba
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2024 06:41:46.1470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WnvTE5oWi8sO7nm72pRfhvQNiZIz5WU4/d3R4L0agYGaE0GoZ/6QFsJ0I5+nseVPzo9N/00KSQ2C5OJOCFmJYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6399
X-OriginatorOrg: intel.com

Hi Matthew,

On 3/8/2024 2:19 AM, Matthew Wilcox wrote:
>   		/* Align with smaller pages if needed */
>   		if (index & ((1UL << order) - 1))
>   			order = __ffs(index);
> +		/* Avoid wrap */
> +		if (index + (1UL << order) == 0)
> +			order--;
>   		/* Don't allocate pages past EOF */
> -		while (index + (1UL << order) - 1 > limit)
> +		while (index + (1UL << order) - 1 > last)
The lockup is related with this line. When index == (last + 1),
deadloop here.


Regards
Yin, Fengwei

>   			order--;