Received: by 2002:ab2:c01:0:b0:1ef:a04a:229c with SMTP id b1csp21604lqb; Sun, 10 Mar 2024 00:02:39 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUT4QE/nbqt+HNHAtXZ9k7nv7BcNz2b0brCT/H1SBlxS+KQuV2kkd2GwSlNcH9EQVkMADibnQTAAstqChdzJ7AbhTl8/woCYcmyW/0iow== X-Google-Smtp-Source: AGHT+IHbffUQrQpGCNsIPPVAu8UPkglaVqKHZ3bPtFAASzpm6GxOj4RHu58fAewKX7cgiM2MC9Sw X-Received: by 2002:a05:651c:1212:b0:2d2:9a8b:f45e with SMTP id i18-20020a05651c121200b002d29a8bf45emr2003460lja.14.1710057759373; Sun, 10 Mar 2024 00:02:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1710057759; cv=pass; d=google.com; s=arc-20160816; b=b8VVjq6stf7WbOoYFy1FG0h4j5+YJCSZslE/mWngHV5U+YA+7ZEiTqlfK+I2CXxUf0 3iHoZqOcc3kO4Tz19yJ2cr/f0BeqRcNn4QGImJyFWVlqt0EItOWjV6y31Q3t7LiErfS4 U2QoZjQzsHmZcFztcGWvkZnugIwZkZibi1hmJ/ELqZZQIremHdjsqYEwR/p8psgizCh+ Xp4zPCGc1JQyIW6glT1xbJ5KoNldoTF8djx6i8mWY5ZtPc4/3oDa+fKn/YAO0zkav/vm roLU1XWlxLUsGUDFLlByvAjcJJknYQ38aWBpDrp86rsgDHgsA2zEBJ+sPLfb4q2yD4gP f6tQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=HLIWN6w7FT+0JO8mg2HnWOB9OyrhO/qM5roGMOblw7A=; fh=oO4/55DbVaLeQZmSjab6jDopfW7RZOGG4wZ9kDLOb1o=; b=kS7XKKqLwp4YIDmhmpEKIHX9BlAdnU5MSkgA120W3P6pSl3nzIrWhZEcUXN92jXSmD jnShPt8Im8aM2qTMvMUZQsasoO8sO2m4F1i0Y78uEm+S4D/p0oVSZQhtu+HmEM8iYV9F yywKuDoEvvqWt7gSgi3fojYTkj1RsdcSXhD6WE4FBTA4CCCdyHjW2TeXPPaUG9FAUnm0 IhZaJzOOaZWsRbWYifEVndkm6A6/yD+Abi/B/YuygTSYlPRt7XlraxR02AcDyVqg6/Z8 rEJK89pA4B8Yj3kTYst//s50L9wyqMaIxvTHX7y/QCMd47ZU+5WJfLno65LdH3Upq+fI pL+g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="B5+E/0eQ"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id m29-20020a50931d000000b00564432b527dsi1458361eda.551.2024.03.10.00.02.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 00:02:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="B5+E/0eQ"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98148-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98148-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1CBF01F22A95 for ; Sun, 10 Mar 2024 08:02:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14C361804A; Sun, 10 Mar 2024 08:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="B5+E/0eQ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 300F4111A1; Sun, 10 Mar 2024 08:02:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710057748; cv=none; b=N4NTqp2LjWLruY2OV7SMCu4o7BosvHOs5/kdlGJ+cyjdRRUD+GJcJsQ+gYO/w5sOIkV2Wc4KudcGmpyvCT25bjN9oJRKDLQutgwVo0jW2qr7HFXjR++MMI0+bP6+faE4c1U0ZAt1VvJzjmb2c2/MOv8MZ+6/RuBBa5aOVsEDUuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710057748; c=relaxed/simple; bh=or3Sro/KI5eZgOzU2rxwbRh5kkJTQswE6RZfe0KbjYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eLiAEQmaxlJXhRUB8vmCKSbTggRDa/VhiUj62iVWsg2GyIbodNQnU7Tt9XCGE8LTHQRD1ByPK8RNQcCo4hmMWLzUrC//fTNsHoKaywTmlQ3zegGNKxJXr0JtSE3e7wqG+D/tnlloKHr10lksHKUhqVQH+eK369AgABzusPBN0/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=B5+E/0eQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CC7FC433C7; Sun, 10 Mar 2024 08:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710057747; bh=or3Sro/KI5eZgOzU2rxwbRh5kkJTQswE6RZfe0KbjYs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B5+E/0eQQuyywzUxcgt1i2idkrWQ5BoW+q0AvwI+3YzGEqnrYqdMF2iWSKaZ/SNn8 WI+OQS1UOV/7XAkNoZkyqvDPQtirbD3Q7cGYm5NNyXRg02DzG+L1c3ApV1OP2SDyJ1 3j4Nzag8HGNPzXVzNDyCYBdgYDu8qRVVBuZ7CI4XNjBa5n6RClRtQPCO1DiVAbVq8U Hq5eDyR1mdKj+opgkfjnwW5OO5x8vnoq4ZjcKEQwqn8VkFLDAVobWtGNcd0pUkctXt 8WVdE212AZ4bBeyhnI1C/RYRyZ04LLExECLgvXtBjBX1SbKSyuRMFYo/vpRXF0iXWd NaQKhji2qKswA== Message-ID: <760b371e-7b02-423f-9ef6-b26ba3ccaf59@kernel.org> Date: Sun, 10 Mar 2024 09:02:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 4/4] net: dsa: realtek: add LED drivers for rtl8366rb Content-Language: en-US To: Luiz Angelo Daros de Luca , Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240310-realtek-led-v1-0-4d9813ce938e@gmail.com> <20240310-realtek-led-v1-4-4d9813ce938e@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240310-realtek-led-v1-4-4d9813ce938e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/03/2024 05:52, Luiz Angelo Daros de Luca wrote: > This commit introduces LED drivers for rtl8366rb, enabling LEDs to be > described in the device tree using the same format as qca8k. Each port > can configure up to 4 LEDs. > > If all LEDs in a group use the default state "keep", they will use the > default behavior after a reset. Changing the brightness of one LED, > either manually or by a trigger, will disable the default hardware > trigger and switch the entire LED group to manually controlled LEDs. > Once in this mode, there is no way to revert to hardware-controlled LEDs > (except by resetting the switch). > > Software triggers function as expected with manually controlled LEDs. > > Signed-off-by: Luiz Angelo Daros de Luca > Reviewed-by: Linus Walleij Again, this is the first version, so how could you have a review? Best regards, Krzysztof