Received-SPF: pass (google.com: domain of linux-kernel+bounces-98163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sun, 10 Mar 2024 08:54:20 +0000
From: Stafford Horne <shorne@gmail.com>
To: Dawei Li <set_pte_at@outlook.com>
Cc: jonas@southpole.se, stefan.kristiansson@saunalahti.fi,
	linux-openrisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] openrisc: Use asm-generic's version of fix_to_virt() &
 virt_to_fix()
Message-ID: <Ze11PL6CILWUWlqw@antec>
References: <TY3P286MB35670C95140EEC4DD181AEE4CA262@TY3P286MB3567.JPNP286.PROD.OUTLOOK.COM>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TY3P286MB35670C95140EEC4DD181AEE4CA262@TY3P286MB3567.JPNP286.PROD.OUTLOOK.COM>

On Sat, Mar 09, 2024 at 06:24:07PM +0800, Dawei Li wrote:
> Openrisc's implementation of fix_to_virt() & virt_to_fix() share same
> functionality with ones of asm generic.
> 
> Plus, generic version of fix_to_virt() can trap invalid index at compile
> time.
> 
> Thus, Replace the arch-specific implementations with asm generic's ones.
> 
> Signed-off-by: Dawei Li <set_pte_at@outlook.com>

Thanks, I have reviewed and tested this and it looks good.

I will queue for the next merge window.

-Stafford