Received-SPF: pass (google.com: domain of linux-kernel+bounces-98172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 10 Mar 2024 12:00:27 +0200
From: Leon Romanovsky <leon@kernel.org>
To: Junxian Huang <huangjunxian6@hisilicon.com>
Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linuxarm@huawei.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH for-next] RDMA/hns: Support congestion control algorithm
 parameter configuration
Message-ID: <20240310100027.GC12921@unreal>
References: <20240308105443.1130283-1-huangjunxian6@hisilicon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240308105443.1130283-1-huangjunxian6@hisilicon.com>

On Fri, Mar 08, 2024 at 06:54:43PM +0800, Junxian Huang wrote:
> From: Chengchang Tang <tangchengchang@huawei.com>
> 
> hns RoCE supports 4 congestion control algorithms. Each algorihm
> involves multiple parameters. Add port sysfs directory for each
> algorithm to allow modifying their parameters.

Unless Jason changed his position after this rewrite [1], we don't allow
any custom driver sysfs code.

[1] https://lore.kernel.org/all/cover.1623427137.git.leonro@nvidia.com/

> 
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> ---
>  drivers/infiniband/hw/hns/Makefile          |   2 +-
>  drivers/infiniband/hw/hns/hns_roce_device.h |  20 ++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c  |  59 ++++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h  | 132 ++++++++
>  drivers/infiniband/hw/hns/hns_roce_main.c   |   3 +
>  drivers/infiniband/hw/hns/hns_roce_sysfs.c  | 346 ++++++++++++++++++++
>  6 files changed, 561 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/infiniband/hw/hns/hns_roce_sysfs.c

Thanks