Received: by 2002:a05:6500:1b8a:b0:1ef:a0f1:aef6 with SMTP id df10csp49411lqb; Sun, 10 Mar 2024 04:47:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWD0pneevpbCGX/YWVD2HaM4gsZi7X/upRGqTbSPo3uujgjAw2DzNml8B9DJt6sycFALOfDGCnCBi6rY/f+NQRA5U1Vo6gl1E8s0TnPgg== X-Google-Smtp-Source: AGHT+IFjyBY3++lcz/98saxiXgvsiAFqQKwOcpwnWuijbFZM7PIkhoqCq9MSB01tjyFjVixcQfBg X-Received: by 2002:a17:903:24e:b0:1dc:df24:e321 with SMTP id j14-20020a170903024e00b001dcdf24e321mr3947854plh.6.1710071261492; Sun, 10 Mar 2024 04:47:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710071261; cv=pass; d=google.com; s=arc-20160816; b=SlCu35FCIHj6NY9luTpP9XtEPTm47r3OdC9L7DKTv8nzw+SiVqFIKEDfiFQMdPubtY LZS7AKS3mA4hP9mJ54B+NECy7yH+T49CuXnZnVgbvAzHf5q6N9XQE2bR9hjXUhM0CaBS x3jYzpdBhn4Bz61diEWEExPS7EGEOHXqgpG5LdNY4Zotmjw9bkPkiEM5i1nWur9NAQON xnsA/CtIl9liqNM9n68thVSPJXhj45c+Jdr4Z/PNlXtz9P1hUMU685P9K3y8eopvpUak p85qEgFJu1esUTfmFfjbGuaLGipprQ1d4kr39EQ7mas8B2fFk5qQPC0FwwoJxWm9Zjht 3Ncg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=pBSiOC1XkqPgjZwOTh5fs0avsv2+eceKSrbCsteOo0U=; fh=7nFBnQ9n+ArY+7GOEPgxRXmJm0rzXrWZvzrfN23Lzls=; b=HI37W+cXFPKAUZjpDpb/9z7zBjfsMxbQe05sjjwtyiyplSpi1j8OB3ZwrCc0Jw/Uw+ 4lnqeU6baoEgaGP9hszPNmls9bfyuxWF96o6HGhecPdoO9eA5RTY5Mj/JREE+aDDmTSC kHkdeuO3saCSsn4fV6nR3cXP/9LV57exkUlHHfqrkSZPiAekOxXfERgBqRunKFyjlspu rYDQKHXnWiI6cHeiucc+OIG254lgH8e3dddf2d5K8XRabrgPum0siMpn+82ujXb01AaU RmWF8Wc+WE4c67x7QbqvzBjaqi6tQek+yS5teamDEsgpIztblXjS53cI0SgjoGS17vOo aQ/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=etY1OeDO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98206-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98206-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q4-20020a17090311c400b001dc9222b1besi542887plh.503.2024.03.10.04.47.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 04:47:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98206-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=etY1OeDO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98206-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98206-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4B4DEB20CBC for ; Sun, 10 Mar 2024 11:47:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B03CA1EB46; Sun, 10 Mar 2024 11:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="etY1OeDO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB02200C4; Sun, 10 Mar 2024 11:47:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710071247; cv=none; b=i1l/dxzd11PYCrycrmVPCKsNoOMy/jAGve9fV15RoCuTK2dxnhAsXymbXb91yxHBB7L+T6+d1v0AiWCuOidYAiR+EFDKYjjbQ8hbzs1LEBRzyEEZmeTJZ9BLB/HCNYoAWV9AaY9wDgPy+iO0Qs2PIZ2N5SEr1+vL0wuxc/gjLy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710071247; c=relaxed/simple; bh=w++wtHcAjnMPZ4xggSk/xRDmNpp2orf89xQr/JLgNzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QTFjE6ZTbrDMeQiT+c2aAot8VwiDSXPkSO+/kTiIFCpI+5N/mKJMuU3Ufgmpot/yWjtpE1RO89mafXKdXDMqMyLqqRP5BtR8qRFaaoAemOUrPznmGIbgMWLIDmhyH+vKRWgruu3/8eQvSXkeKBUFTycw7R5e+0hm0OW1FWarGLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=etY1OeDO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FEF2C433F1; Sun, 10 Mar 2024 11:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710071247; bh=w++wtHcAjnMPZ4xggSk/xRDmNpp2orf89xQr/JLgNzg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=etY1OeDOqLL1dL/Exp+b+PfywlXIVwI97JgpAz77g6/MWMr7oJFxcU/DRTUw8xvKI SSA7cs6KMCST2a7EMD3FaZtYdgzebN/khHnzUmhZ2gQEp2xXt4zgV/DZFk3au0ejNC TeBvoRTw3R0ZAWwDOCok2bgD4uCs3cUFN/D8LSu9hlEn/LO2srhs1OO7qR2iCldT8R GO/Yzt35FtNzDNKEMw/zDH+WhKXYi3VbZxBD4/zVxCIWTGpUQNycWWWu21cE8MmHIP lvI2RvlGwmI41P7Z4RTL66oTt3aygjAn3i96QDwANMR6oHA5xJ5a6z6YIRUW4IcIc/ 9VhJ2j+R/cmtQ== Message-ID: <09793a72-bfe5-4cb5-a6da-ffee565e6956@kernel.org> Date: Sun, 10 Mar 2024 12:47:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/4] net: dsa: realtek: keep default LED state in rtl8366rb Content-Language: en-US To: Simon Horman Cc: Luiz Angelo Daros de Luca , Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240310-realtek-led-v1-0-4d9813ce938e@gmail.com> <20240310-realtek-led-v1-2-4d9813ce938e@gmail.com> <388b435f-13c5-446f-b265-6da98ccfd313@kernel.org> <20240310113738.GA1623@kernel.org> From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240310113738.GA1623@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/03/2024 12:37, Simon Horman wrote: >>> >>> The code to disable LEDs was simplified only changing each LED group to >>> the RTL8366RB_LED_OFF state. Registers RTL8366RB_LED_0_1_CTRL_REG and >>> RTL8366RB_LED_2_3_CTRL_REG are only used when the corresponding LED >>> group is configured with RTL8366RB_LED_FORCE and they don't need to be >>> cleaned. The code still references an LED controlled by >>> RTL8366RB_INTERRUPT_CONTROL_REG, but as of now, no test device has >>> actually used it. Also, some magic numbers were replaced by macros. >>> >>> Signed-off-by: Luiz Angelo Daros de Luca >>> Reviewed-by: Linus Walleij >> >> This is the first version, so where did review happen? > > FWIIW, I think this relates to review of an RFC of this patch-set. > > https://lore.kernel.org/netdev/CACRpkda8tQ2u4+jCrpOQXbBd84oW98vmiDgU+GgdYCHuZfn49A@mail.gmail.com/ OK, then this is v2. RFC is state of patch, not some sort of version. Or just use b4 which handles this automatically... Best regards, Krzysztof